dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Apr 2023
8:58 am

Dara Navaei

Merged DEN-15199

Options
    • -13
    • +16
    ./Modes/ModeFill.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
    • -0
    • +22
    ./Services/SystemComm.c
    • -0
    • +114
    ./Services/SystemCommMessages.c
    • -0
    • +13
    ./Services/SystemCommMessages.h
8:55 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -1
    • +1
    ./Services/SystemComm.c
    • -4
    • +7
    ./Services/SystemCommMessages.c
8:52 am

Dara Navaei

Done

Done

8:50 am

Dara Navaei

Done

Done

8:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:49 am

Dara Navaei

Done

Done

8:49 am

Dara Navaei

Done.

Done.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:42 am

Dara Navaei

Brought the code back.

Brought the code back.

8:41 am

Sean Nash

Why did we blank title/instructions?

Why did we blank title/instructions?

8:38 am

Sean Nash

Acking even if payload length > 0?

Acking even if payload length > 0?

8:36 am

Sean Nash

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

8:33 am

Sean Nash

This is an output.

This is an output.

8:33 am

Sean Nash

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

8:25 am

Dara Navaei

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95

Options
    • -5
    • +6
    ./Controllers/DrainPump.c
8:22 am

Dara Navaei

DEN-15199 added to code to check for dialin check in

Options
    • -2
    • +2
    ./Controllers/DrainPump.c
    • -1
    • +7
    ./Controllers/ROPump.c
    • -6
    • +6
    ./Modes/ModeFill.c
    • -0
    • +18
    ./Services/SystemComm.c
    • -2
    • +80
    ./Services/SystemCommMessages.c
    • -0
    • +10
    ./Services/SystemCommMessages.h
Tuesday 25 Apr 2023
8:47 am

jtaylor  (deleted user)

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alar...

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alarm. If problems continue, we should consider increasing the trigger interval, decreasing the clear interval, and/or resetting the alarm when the target is set to zero (or taking a large step).

Monday 24 Apr 2023
5:11 pm

Sean Nash and dcox  (deleted user)

5:11 pm

Sean Nash

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the pe...

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the persistence is being cleared all the time while mixing, essentially rendering the alarm disabled. I don't think we should reset here.

3:33 pm

jtaylor  (deleted user)

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

3:29 pm

jtaylor  (deleted user)

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on i...

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on it's way to being triggered.

3:19 pm

Dara Navaei

What does MAG stand for?

What does MAG stand for?

3:17 pm

Dara Navaei

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

2:08 pm

Dara Navaei

Why are we resetting the persistent alarms here?

Why are we resetting the persistent alarms here?

12:40 pm

Dara Navaei

Done

Done

12:40 pm

Dara Navaei

Done

Done

10:48 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:04 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.