dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2023
10:47 am

Dara Navaei

DEN-15660 addressed the code review comments

Options
    • -5
    • +5
    ./Controllers/TemperatureSensors.c
    • -21
    • +24
    ./Modes/ModeChemicalDisinfect.c
    • -2
    • +0
    ./Modes/ModeDrain.c
    • -12
    • +2
    ./Modes/ModeFill.c
    • -28
    • +16
    ./Modes/ModeGenIdle.c
    • -2
    • +0
    ./Modes/ModeGenIdle.h
9:58 am

Dara Navaei

Nelson is not part of the commercial code.

Nelson is not part of the commercial code.

9:57 am

Dara Navaei

Done

Done

9:08 am

Dara Navaei

Done

Done

9:06 am

Dara Navaei

Done

Done

8:53 am

Dara Navaei

Nelson support is only in debug mode.

Nelson support is only in debug mode.

8:51 am

Dara Navaei

Done

Done

8:49 am

Dara Navaei

Done

Done

8:47 am

Dara Navaei

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is real...

The un-averaged TDi and TRo are used for dialysate temperature checking and trimmer heater control I think we should keep them to be able to have a full picture if needed unless the CAN bus is really flooded.

8:44 am

Dara Navaei

This is a time and not timeout.

This is a time and not timeout.

8:42 am

Dara Navaei

Done

Done

8:41 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

8:39 am

Dara Navaei

Done

Done

8:21 am

jtaylor  (deleted user)

Tuesday 11 Jul 2023
5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:42 pm

wbracken  (deleted user)

Correct indentation

Correct indentation

5:41 pm

wbracken  (deleted user)

Indentation needs to be corrected.

Indentation needs to be corrected.

5:30 pm

wbracken  (deleted user)

handleEmptyBottleFlag is only an input

handleEmptyBottleFlag is only an input

4:03 pm

Dara Navaei

DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
DG-DEN-15702_Alarm 150 Inlet Water Conductivity High Does Not Disappear ON Standby Screen When
3:37 pm

Darren Cox <darren_m@cox.net>

DEN-15702 Check VPI Open for Inlet Conductivity, Pressure, temperature. If VPI Closed, clear alarms.

Options
    • -8
    • +17
    ./Controllers/ConductivitySensors.c
    • -8
    • +17
    ./Controllers/Pressures.c
    • -10
    • +24
    ./Controllers/TemperatureSensors.c
    • -14
    • +11
    ./Modes/ModeStandby.c
3:12 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:11 pm

Dara Navaei

Merge branch 'DEN-15660-test_configuration_treatment_recovery' into develop

Options
    • -0
    • +8
    ./Modes/ModeFill.c
3:11 pm

Dara Navaei

DEN-15809 added code to clear the dialysate generation alarm 147

Options
    • -0
    • +8
    ./Modes/ModeFill.c
    • -1
    • +13
    ./Modes/ModeGenIdle.c
    • -0
    • +1
    ./Modes/ModeGenIdle.h
2:58 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
2:54 pm

Dara Navaei

DEN-15809 updated the code to trigger another alarm if the empty bottle alarms have been triggered.:

Options
    • -1
    • +6
    ./Modes/ModeDrain.c
    • -3
    • +25
    ./Modes/ModeGenIdle.c
    • -0
    • +1
    ./Modes/ModeGenIdle.h
12:28 pm

Sean Nash

9:08 am

Sean Nash

What about acid?

What about acid?

9:06 am

Sean Nash

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place? With this approach, you're just stuck in fill start state until user clears the alarm.

This looks strange. If we have a empty bottle alarm, shouldn't we just not start a fill in the first place?
With this approach, you're just stuck in fill start state until user clears the alarm.

8:54 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h