dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 11 Aug 2023
9:35 am

Dara Navaei

Merge branch 'DEN-16149-expedite_tx-configuration-does-not-work' into develop

Options
    • -7
    • +0
    ./Modes/ModeFill.c
9:34 am

Dara Navaei

DEN-16149 deleted the previous code

Options
    • -7
    • +0
    ./Modes/ModeFill.c
9:13 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
9:13 am

Dara Navaei

Merged DEN-16149

Options
    • -9
    • +8
    ./Controllers/ConcentratePumps.c
    • -3
    • +90
    ./Modes/ModeDrain.c
    • -25
    • +16
    ./Modes/ModeFill.c
    • -2
    • +6
    ./Services/SystemComm.c
    • -1
    • +34
    ./Services/SystemCommMessages.c
    • -2
    • +5
    ./Services/SystemCommMessages.h
9:10 am

Dara Navaei

DEN-16149 added a check to mode fill to not transition to deliver state if the reservoir is already at the level

Options
    • -0
    • +7
    ./Modes/ModeFill.c
Thursday 10 Aug 2023
8:38 am

Dara Navaei

DG Staging Unreviewed Commits
DG Staging Unreviewed Commits
8:36 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
8:36 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeDrain.h
    • -2
    • +2
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Modes/ModeFill.h
    • -2
    • +2
    ./Modes/ModeGenIdle.c
    • -2
    • +2
    ./Modes/ModeGenIdle.h
    • -2
    • +2
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
    • -2
    • +2
    ./Services/SystemCommMessages.h
8:15 am

Michael Garthwaite

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Options
    • -22
    • +3
    ./Modes/ModeFill.c
    • -5
    • +2
    ./Services/SystemCommMessages.c
8:13 am

Michael Garthwaite

Wednesday 09 Aug 2023
5:50 pm

wbracken  (deleted user) and Sean Nash

5:36 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
    • -1
    • +1
    ./Controllers/DrainPump.c
    • -2
    • +2
    ./Controllers/FlowSensors.c
    • -1
    • +1
    ./Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
5:29 pm

Dara Navaei

5:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

wbracken  (deleted user) and Sean Nash

4:55 pm

wbracken  (deleted user)

That's what it looked like when reviewed HD side. RESOLVED IN CODE WALKTHROUGH

That's what it looked like when reviewed HD side.

RESOLVED IN CODE WALKTHROUGH

4:44 pm

Dara Navaei

DEN-16125 updated the concentrate pumps code to set the direction speed of the concentrate pumps when the measured speed is called

Options
    • -8
    • +7
    ./Controllers/ConcentratePumps.c
    • -1
    • +1
    ./Controllers/ConcentratePumps.h
    • -0
    • +1
    ./Controllers/DrainPump.c
    • -2
    • +2
    ./Controllers/FlowSensors.c
    • -2
    • +2
    ./Modes/ModeFill.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.c
4:25 pm

Michael Garthwaite

Merge branch 'staging' into DEN-15634-bad-fill-states-and-signal-updating-inconsistently

Options
    • -7
    • +14
    ./Services/SystemCommMessages.c
4:24 pm

Michael Garthwaite

DEN-15634: code review comments.

Options
    • -0
    • +1
    ./Modes/ModeDrain.h
4:22 pm

Michael Garthwaite

Fixed!

Fixed!

3:10 pm

Sean Nash

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

For DG, it's not used (yet at least). But there are common macros that call this function, so had to change HD and DG versions of this function.

3:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:05 pm

Sean Nash

Move blank line up one.

Move blank line up one.

3:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:03 pm

Sean Nash

Move blank line down one.

Move blank line down one.

2:44 pm

Michael Garthwaite

DEN-15634: code review comments.

Options
    • -1
    • +1
    ./Modes/ModeDrain.c
1:48 pm

wbracken  (deleted user)

Where is outside used?

Where is outside used?

1:43 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH