dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Sep 2023
8:52 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
8:50 am

Dara Navaei

DEN-15973 updated the chemical disinfect

Options
    • -1
    • +7
    ./Modes/ModeChemicalDisinfect.c
Thursday 14 Sep 2023
6:06 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
6:04 pm

Dara Navaei

DEN-15973 updated chem disinfect

Options
    • -1
    • +3
    ./Modes/ModeChemicalDisinfect.c
5:45 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
5:37 pm

Dara Navaei

DEN-15973 updated chemical disinfect

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
5:01 pm

Dara Navaei

DEN-16432 fixed the heat disinfect temperature out of range trial count error

Options
    • -2
    • +3
    ./Modes/ModeHeatDisinfect.c
4:23 pm

Sean Nash

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

4:05 pm

Dara Navaei

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State
3:36 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
3:35 pm

Dara Navaei

DEN-15973 updated the chemical disinfect

Options
    • -2
    • +3
    ./Modes/ModeChemicalDisinfect.c
1:28 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
1:27 pm

Dara Navaei

Merged DEN-15973

Options
    • -1
    • +1
    ./Services/SystemComm.c
    • -2
    • +2
    ./Services/SystemCommMessages.c
    • -2
    • +2
    ./Services/SystemCommMessages.h
1:26 pm

Dara Navaei

DEN-15973 updated chemical disinfect

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
1:17 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./DGCommon.h
10:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:28 am

Dara Navaei

Done

Done

10:27 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -4
    • +4
    ./Modes/ModeStandby.c
9:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

9:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:49 am

Dara Navaei

9:48 am

Dara Navaei

DEN-15973 addressed the code review comments

Options
    • -12
    • +12
    ./Controllers/Pressures.c
    • -1
    • +5
    ./Modes/ModeStandby.c
    • -1
    • +1
    ./Modes/OperationModes.h
9:44 am

Dara Navaei

Done

Done

9:42 am

Dara Navaei

Done

Done

9:38 am

Sean Nash

You at least need to add a comment explaining what they are.

You at least need to add a comment explaining what they are.

9:38 am

Dara Navaei

Done

Done

9:37 am

Sean Nash

No, these are the minimum values to trigger the alarm. But they are named maximums.

No, these are the minimum values to trigger the alarm. But they are named maximums.

9:37 am

Dara Navaei

Yes these are for software configuration disable only so I did not make any #defines for them.

Yes these are for software configuration disable only so I did not make any #defines for them.