dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Jun 2020
9:03 am

Dara Navaei

DEN-2379 Addressed code review comments, removed dead code, and continued with unit testing and integration testing

Options
    • -4
    • +6
    ./Controllers/Heaters.c
    • -53
    • +24
    ./Controllers/TemperatureSensors.c
    • -0
    • +1
    ./Services/FPGA.h
Tuesday 02 Jun 2020
11:28 am

Dara Navaei

DEN-2379 Unit tested the override functions in SystemCommMessages

Options
    • -23
    • +30
    ./Controllers/Heaters.c
    • -21
    • +36
    ./Controllers/TemperatureSensors.c
    • -0
    • +7
    ./Modes/ModeInitPOST.c
    • -0
    • +4
    ./Tasks/TaskPriority.c
Monday 01 Jun 2020
12:59 pm

Sean Nash

Added safety shutdown override command support.

Options
    • -5
    • +95
    ./Drivers/SafetyShutdown.c
    • -1
    • +16
    ./Drivers/SafetyShutdown.h
    • -0
    • +4
    ./Services/SystemComm.c
    • -0
    • +12
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
  6. … 1 more file in changeset.
10:50 am

Dara Navaei

DEN-2379 Added code review comments

Options
    • -140
    • +0
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
10:40 am

Dara Navaei

DEN-2379 fixed a typo

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -7
    • +7
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Controllers/TemperatureSensors.h
10:17 am

Dara Navaei

DEN-2379 Addressed code review comments

Options
    • -11
    • +11
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/Heaters.h
    • -10
    • +10
    ./Controllers/TemperatureSensors.c
    • -10
    • +10
    ./Controllers/TemperatureSensors.h
    • -1
    • +1
    ./Services/SystemCommMessages.c
Sunday 31 May 2020
4:53 pm

Dara Navaei

DEN-2379 Addressed code review comments, added POST for Heaters module, continued working unit testing and integration testing. Removed .db and .xml files from VectorCAST git repositories

Options
    • -70
    • +161
    ./Controllers/Heaters.c
    • -60
    • +267
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeInitPOST.c
    • -4
    • +1
    ./Services/SystemCommMessages.c
Friday 29 May 2020
5:52 pm

Sean Nash

Moved DGModes.h to common folder and renamed to DGDefs.h.

Options
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.h
    • -1
    • +1
    ./Modes/ModeDrain.h
    • -1
    • +1
    ./Modes/ModeFault.h
    • -1
    • +1
    ./Modes/ModeFill.h
    • -1
    • +1
    ./Modes/ModeFlush.h
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.h
    • -1
    • +1
    ./Modes/ModeInitPOST.h
    • -1
    • +1
    ./Modes/ModeRecirculate.h
    • -1
    • +1
    ./Modes/ModeService.h
    • -1
    • +1
    ./Modes/ModeSolo.h
    • -1
    • +1
    ./Modes/ModeStandby.h
    • -0
    • +1
    ./Modes/OperationModes.c
    • -1
    • +1
    ./Modes/OperationModes.h
    • -1
    • +1
    ./Services/Reservoirs.c
2:57 pm

Dara Navaei

DEN-2379 Added dialin support functions

Options
    • -2
    • +2
    ./Controllers/TemperatureSensors.h
    • -0
    • +8
    ./Services/SystemComm.c
    • -1
    • +42
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
12:56 pm

Dara Navaei

DEN-2379 work in progress, added publication and broadcast functions and continues with unit testing and integration testing

Options
    • -2
    • +1
    ./Controllers/Heaters.c
    • -2
    • +111
    ./Controllers/TemperatureSensors.c
    • -0
    • +3
    ./Controllers/TemperatureSensors.h
    • -0
    • +28
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
Thursday 28 May 2020
10:35 pm

Dara Navaei

DEN-2379 Added publish functions for the heaters module and continued with unit testing

Options
    • -26
    • +141
    ./Controllers/Heaters.c
    • -0
    • +3
    ./Controllers/Heaters.h
    • -6
    • +10
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.h
    • -1
    • +1
    ./DGCommon.h
    • -2
    • +57
    ./Services/SystemCommMessages.c
    • -0
    • +6
    ./Services/SystemCommMessages.h
3:01 pm

Sean Nash

Fixed load cell publishing as integers bug. Increased I term in PI control for RO pump. Changed CAN interrupts from FIQ to IRQ to see if resolves intermittent lock up.

Options
    • -1
    • +1
    ./Controllers/LoadCell.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -7
    • +18
    ./Services/CommBuffers.c
  4. … 5 more files in changeset.
11:06 am

Dara Navaei

DEN-2379 Addressed code review comments

Options
    • -4
    • +4
    ./Controllers/Heaters.c
    • -4
    • +4
    ./Services/SystemComm.c
    • -0
    • +14
    ./Services/SystemCommMessages.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
9:46 am

Dara Navaei

DEN-2379 Started VectorCAST

Options
    • -4
    • +3
    ./Controllers/Heaters.c
    • -5
    • +7
    ./Controllers/TemperatureSensors.c
Wednesday 27 May 2020
5:56 pm

Dara Navaei

DEN-2379 Addressed some of the code review comments

Options
    • -31
    • +53
    ./Controllers/Heaters.c
5:25 pm

Dara Navaei

DEN-2379 Addressed some of the code review comments

Options
    • -54
    • +80
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -180
    • +139
    ./Controllers/TemperatureSensors.c
    • -3
    • +1
    ./Controllers/TemperatureSensors.h
    • -0
    • +21
    ./Services/FPGA.c
Tuesday 26 May 2020
4:43 pm

Sean Nash

Cast load cell data earlier for conversion equation.

Options
    • -4
    • +4
    ./Controllers/LoadCell.c
10:39 am

Sean Nash

UF fixes. Doxygen fixes.

Options
    • -0
    • +4
    ./Controllers/DrainPump.c
    • -42
    • +81
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/LoadCell.c
    • -5
    • +4
    ./Controllers/Pressures.c
    • -0
    • +4
    ./Controllers/ROPump.c
    • -59
    • +71
    ./Controllers/TemperatureSensors.c
    • -0
    • +5
    ./Controllers/TemperatureSensors.h
    • -2
    • +2
    ./Controllers/Valves.h
    • -1
    • +2
    ./DGCommon.h
    • -1
    • +1
    ./Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    ./Modes/ModeChemicalDisinfect.h
    • -1
    • +1
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeDrain.h
    • -1
    • +1
    ./Modes/ModeFault.c
    • -2
    • +2
    ./Modes/ModeFault.h
  16. … 23 more files in changeset.
Saturday 23 May 2020
10:12 am

Dara Navaei

DEN-2379 Added a function to compensate for the heaters thermocouples

Options
    • -12
    • +35
    ./Controllers/Heaters.c
    • -46
    • +246
    ./Controllers/TemperatureSensors.c
    • -13
    • +17
    ./Controllers/TemperatureSensors.h
    • -0
    • +9
    ./Services/FPGA.c
    • -0
    • +2
    ./Services/FPGA.h
Thursday 21 May 2020
9:59 am

Dara Navaei

DEN-2379 updated the code with the code review addresses

Options
    • -29
    • +31
    ./Controllers/Heaters.c
    • -0
    • +9
    ./Controllers/Heaters.h
    • -20
    • +29
    ./Controllers/TemperatureSensors.c
    • -0
    • +10
    ./Controllers/TemperatureSensors.h
    • -0
    • +1
    ./Modes/ModeInitPOST.c
    • -3
    • +3
    ./Services/FPGA.c
Wednesday 20 May 2020
1:02 pm

Dara Navaei

DEN-2379 addressed some of the code review comments

Options
    • -17
    • +17
    ./Controllers/Heaters.c
    • -27
    • +23
    ./Controllers/TemperatureSensors.c
    • -0
    • +5
    ./Controllers/TemperatureSensors.h
Tuesday 19 May 2020
10:44 pm

Dara Navaei

DEN-2379 added inlet water temperature range check

Options
    • -7
    • +4
    ./Controllers/Heaters.c
    • -18
    • +36
    ./Controllers/TemperatureSensors.c
10:33 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-2652 Corrected typo in comment

Options
    • -1
    • +1
    ./Controllers/Valves.h
6:01 pm

Dara Navaei

DEN-2379 Added flow sensor reader to the module

Options
    • -4
    • +5
    ./Controllers/Heaters.c
    • -28
    • +19
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Tasks/TaskGeneral.c
9:34 am

Sean Nash

More updates to modes.

Options
    • -1
    • +5
    ./Controllers/DrainPump.c
    • -3
    • +0
    ./Controllers/Valves.c
    • -4
    • +4
    ./Modes/ModeDrain.c
    • -4
    • +17
    ./Modes/ModeFill.c
    • -3
    • +7
    ./Modes/ModeRecirculate.c
    • -5
    • +10
    ./Modes/ModeStandby.c
Monday 18 May 2020
7:02 pm

Sean Nash

Fixed compile errors.

Options
    • -0
    • +3
    ./Modes/ModeDrain.c
    • -0
    • +1
    ./Modes/ModeFill.c
6:59 pm

Sean Nash

Updated modes.

Options
    • -0
    • +14
    ./Modes/ModeDrain.c
    • -4
    • +4
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -5
    • +28
    ./Services/Reservoirs.c
3:24 pm

Sean Nash

Added DG_ prefix to DG op modes to differentiate from HD op modes.

Options
    • -2
    • +2
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -2
    • +2
    ./Modes/ModeStandby.c
    • -53
    • +53
    ./Modes/OperationModes.c
    • -2
    • +2
    ./Modes/OperationModes.h
    • -9
    • +9
    ./Services/Reservoirs.c
    • -3
    • +3
    ./Services/SystemCommMessages.c
3:07 pm

Sean Nash

Moved DG modes and sub-modes to a common header. Include sub-mode in DG op mode broadcast msg.

Options
    • -13
    • +22
    ./Modes/ModeChemicalDisinfect.c
    • -1
    • +6
    ./Modes/ModeChemicalDisinfect.h
    • -19
    • +27
    ./Modes/ModeDrain.c
    • -2
    • +7
    ./Modes/ModeDrain.h
    • -13
    • +22
    ./Modes/ModeFault.c
    • -1
    • +6
    ./Modes/ModeFault.h
    • -26
    • +33
    ./Modes/ModeFill.c
    • -1
    • +4
    ./Modes/ModeFill.h
    • -13
    • +22
    ./Modes/ModeFlush.c
    • -1
    • +6
    ./Modes/ModeFlush.h
    • -13
    • +22
    ./Modes/ModeHeatDisinfect.c
    • -1
    • +6
    ./Modes/ModeHeatDisinfect.h
    • -28
    • +33
    ./Modes/ModeInitPOST.c
    • -1
    • +7
    ./Modes/ModeInitPOST.h
    • -22
    • +24
    ./Modes/ModeRecirculate.c
  16. … 12 more files in changeset.
10:54 am

Sean Nash

Addressed code review feedback.

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/ROPump.c