dgfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 04 Dec 2020
4:06 pm

Quang Nguyen <qnguyen@diality.com>

Temporary fixes for check persistent alarms

Options
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -5
    • +5
    ./Controllers/ConductivitySensors.c
    • -2
    • +2
    ./Controllers/Pressures.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./DGCommon.h
    • -1
    • +1
    ./Modes/ModeFill.c
    • -1
    • +0
    ./Modes/ModeFill.h
    • -8
    • +0
    ./Services/MessagePayloads.h
    • -4
    • +4
    ./Services/SystemComm.c
    • -0
    • +19
    ./Services/SystemCommMessages.c
    • -1
    • +4
    ./Services/SystemCommMessages.h
Thursday 03 Dec 2020
2:11 pm

Dara Navaei

DEN-5855 addressed code review comments and continued with dev testing

Options
    • -2
    • +3
    ./Controllers/ConcentratePumps.c
    • -5
    • +8
    ./Controllers/ConductivitySensors.c
    • -46
    • +11
    ./Controllers/DrainPump.c
    • -1
    • +1
    ./Controllers/DrainPump.h
    • -2
    • +4
    ./Controllers/Pressures.c
    • -1
    • +1
    ./Controllers/ROPump.c
    • -2
    • +3
    ./Controllers/TemperatureSensors.c
    • -1
    • +3
    ./Modes/ModeFill.c
    • -0
    • +8
    ./Modes/ModeInitPOST.c
    • -8
    • +0
    ./Services/MessagePayloads.h
    • -2
    • +2
    ./Services/PIControllers.c
    • -1
    • +3
    ./Services/PIControllers.h
    • -52
    • +19
    ./Services/SystemCommMessages.c
    • -4
    • +0
    ./Services/SystemCommMessages.h
  15. … 4 more files in changeset.
Wednesday 02 Dec 2020
4:58 pm

Dara Navaei

DEN-5864 addressed code review comments and continued with dev testing

Options
    • -47
    • +3
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Controllers/ROPump.h
    • -3
    • +3
    ./Modes/ModeFill.c
    • -2
    • +3
    ./Modes/ModeRecirculate.c
    • -3
    • +3
    ./Services/PIControllers.c
    • -0
    • +1
    ./Services/PIControllers.h
    • -7
    • +3
    ./Services/SystemComm.c
    • -54
    • +24
    ./Services/SystemCommMessages.c
    • -6
    • +3
    ./Services/SystemCommMessages.h
12:47 pm

Dara Navaei

DEN-5873 added TODO comments for the persistent alarm checks

Options
    • -0
    • +1
    ./Controllers/ConcentratePumps.c
    • -0
    • +3
    ./Controllers/ConductivitySensors.c
    • -0
    • +2
    ./Controllers/Pressures.c
    • -0
    • +1
    ./Controllers/TemperatureSensors.c
12:35 pm

Dara Navaei

DEN-5873 made some temporary changes in the code to be able to use the latest changed from peristent alarm driver

Options
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -5
    • +5
    ./Controllers/ConductivitySensors.c
    • -2
    • +2
    ./Controllers/Pressures.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Modes/ModeFill.c
    • -8
    • +0
    ./Services/MessagePayloads.h
11:26 am

Dara Navaei

DEN-5873 addressed code review comments and continued with dev testing

Options
    • -19
    • +20
    ./Controllers/UVReactors.c
    • -1
    • +1
    ./Modes/ModeInitPOST.c
    • -8
    • +4
    ./Services/SystemComm.c
    • -53
    • +22
    ./Services/SystemCommMessages.c
    • -6
    • +3
    ./Services/SystemCommMessages.h
  6. … 1 more file in changeset.
Tuesday 01 Dec 2020
2:30 pm

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -12
    • +4
    ./Controllers/TemperatureSensors.c
    • -1
    • +1
    ./Controllers/UVReactors.c
    • -1
    • +1
    ./Controllers/UVReactors.h
    • -1
    • +1
    ./Tasks/TaskGeneral.c
12:57 pm

Dara Navaei

DEN-5846 addressed code review comments and continued with dev testing

Options
    • -16
    • +26
    ./Controllers/Fans.c
10:56 am

Dara Navaei

DEN-5846 addressed code review comments

Options
    • -1
    • +1
    ./Services/FPGA.c
10:38 am

Dara Navaei

DEN-5846 ran VectorCAST

Options
    • -19
    • +1
    ./Controllers/Heaters.c
    • -0
    • +1
    ./Controllers/Thermistors.c
    • -0
    • +8
    ./Services/SystemComm.c
    • -0
    • +3
    ./Services/SystemCommMessages.h
Monday 30 Nov 2020
10:02 pm

Dara Navaei

DEN-5846 ran vectorCAST and addressed code review comments

Options
    • -69
    • +60
    ./Controllers/Fans.c
    • -4
    • +4
    ./Controllers/Fans.h
    • -88
    • +166
    ./Controllers/TemperatureSensors.c
    • -46
    • +44
    ./Controllers/Thermistors.c
    • -2
    • +1
    ./Controllers/Thermistors.h
    • -2
    • +2
    ./Drivers/InternalADC.c
    • -0
    • +16
    ./Modes/ModeInitPOST.c
    • -0
    • +48
    ./Services/FPGA.c
    • -0
    • +6
    ./Services/FPGA.h
    • -4
    • +0
    ./Services/SystemComm.c
    • -3
    • +2
    ./Services/SystemCommMessages.c
    • -7
    • +7
    ./Services/SystemCommMessages.h
  13. … 1 more file in changeset.
Saturday 28 Nov 2020
5:26 pm

Dara Navaei

DEN-5873 initial commit of the unit test and integration test of the UV reactors

Options
    • -20
    • +33
    ./Controllers/UVReactors.c
    • -0
    • +2
    ./Modes/ModeInitPOST.c
  3. … 1 more file in changeset.
Friday 27 Nov 2020
9:19 pm

Dara Navaei

DEN-5864 ran unit test and integration test on the RO pump driver

Options
    • -13
    • +29
    ./Controllers/ROPump.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
11:36 am

Dara Navaei

DEN-5855 unit and integration tested the drain pump driver

Options
    • -4
    • +8
    ./Controllers/DrainPump.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
Thursday 26 Nov 2020
6:17 pm

Dara Navaei

DEN-5864 start unit test and integration test for the fans and thermistors drivers

Options
    • -54
    • +90
    ./Controllers/Fans.c
    • -1
    • +1
    ./Controllers/Heaters.c
    • -86
    • +164
    ./Controllers/TemperatureSensors.c
    • -1
    • +8
    ./Controllers/TemperatureSensors.h
    • -61
    • +40
    ./Controllers/Thermistors.c
    • -2
    • +4
    ./Tasks/TaskGeneral.c
  7. … 1 more file in changeset.
Wednesday 25 Nov 2020
10:31 am

Dara Navaei

DEN-5864 initial commit of the branch

Options
    • -617
    • +946
    ./Controllers/ROPump.c
    • -45
    • +63
    ./Controllers/ROPump.h
    • -4
    • +5
    ./Modes/ModeFill.c
    • -1
    • +1
    ./Modes/ModeRecirculate.c
    • -0
    • +15
    ./Services/AlarmMgmt.h
    • -8
    • +0
    ./Services/MessagePayloads.h
    • -219
    • +240
    ./Services/PIControllers.c
    • -50
    • +51
    ./Services/PIControllers.h
    • -986
    • +998
    ./Services/SystemComm.c
    • -64
    • +136
    ./Services/SystemCommMessages.c
    • -137
    • +147
    ./Services/SystemCommMessages.h
9:12 am

Dara Navaei

DEN-5855 initial commit of the branch

Options
    • -452
    • +591
    ./Controllers/DrainPump.c
    • -40
    • +59
    ./Controllers/DrainPump.h
    • -2
    • +2
    ./Modes/ModeDrain.c
    • -0
    • +15
    ./Services/AlarmMgmt.h
    • -7
    • +0
    ./Services/MessagePayloads.h
    • -219
    • +240
    ./Services/PIControllers.c
    • -50
    • +51
    ./Services/PIControllers.h
    • -986
    • +986
    ./Services/SystemComm.c
    • -61
    • +76
    ./Services/SystemCommMessages.c
    • -137
    • +142
    ./Services/SystemCommMessages.h
8:20 am

Dara Navaei

DEN-5846 initial commit of the branch

Options
    • -0
    • +575
    ./Controllers/Fans.c
    • -0
    • +52
    ./Controllers/Fans.h
    • -0
    • +571
    ./Controllers/Thermistors.c
    • -0
    • +57
    ./Controllers/Thermistors.h
    • -1
    • +3
    ./Drivers/InternalADC.h
    • -0
    • +15
    ./Services/AlarmMgmt.h
    • -0
    • +150
    ./Services/FPGA.c
    • -63
    • +77
    ./Services/FPGA.h
    • -986
    • +990
    ./Services/SystemComm.c
    • -1120
    • +1271
    ./Services/SystemCommMessages.c
    • -137
    • +151
    ./Services/SystemCommMessages.h
    • -1
    • +7
    ./Tasks/TaskGeneral.c
Tuesday 24 Nov 2020
11:46 pm

Dara Navaei

DEN-5873 initial commit of the branch

Options
    • -0
    • +570
    ./Controllers/UVReactors.c
    • -0
    • +54
    ./Controllers/UVReactors.h
    • -0
    • +6
    ./Modes/ModeInitPOST.c
    • -0
    • +15
    ./Services/AlarmMgmt.h
    • -986
    • +994
    ./Services/SystemComm.c
    • -1148
    • +1307
    ./Services/SystemCommMessages.c
    • -137
    • +152
    ./Services/SystemCommMessages.h
    • -3
    • +15
    ./Tasks/TaskGeneral.c
9:23 pm

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -119
    • +105
    ./Controllers/Heaters.c
    • -0
    • +2
    ./Controllers/Heaters.h
    • -7
    • +6
    ./Controllers/TemperatureSensors.c
    • -0
    • +1
    ./Controllers/TemperatureSensors.h
Monday 23 Nov 2020
5:56 pm

Dara Navaei

DEN-3421 addressed code review comments

Options
    • -7
    • +7
    ./Controllers/Fans.c
    • -21
    • +9
    ./Controllers/Heaters.c
    • -0
    • +11
    ./Controllers/Heaters.h
    • -9
    • +9
    ./Controllers/TemperatureSensors.c
    • -2
    • +2
    ./Controllers/TemperatureSensors.h
    • -1
    • +1
    ./Modes/ModeHeatDisinfect.c
    • -8
    • +0
    ./Services/MessagePayloads.h
    • -15
    • +7
    ./Services/SystemCommMessages.c
    • -5
    • +3
    ./Services/SystemCommMessages.h
Sunday 22 Nov 2020
4:27 pm

Dara Navaei

DEN-3421 added board temperature sensors to the temperature sensors driver

Options
    • -4
    • +3
    ./Controllers/Fans.c
    • -108
    • +167
    ./Controllers/TemperatureSensors.c
    • -0
    • +6
    ./Controllers/TemperatureSensors.h
    • -59
    • +26
    ./Controllers/Thermistors.c
    • -12
    • +3
    ./Controllers/Thermistors.h
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -1
    • +1
    ./Services/FPGA.c
    • -1
    • +1
    ./Services/FPGA.h
Saturday 21 Nov 2020
10:09 am

Dara Navaei

DEN-3421 addressed the code review comments. Worke on the thermistors and fans drivers

Options
    • -97
    • +48
    ./Controllers/DrainPump.c
    • -7
    • +8
    ./Controllers/DrainPump.h
    • -17
    • +28
    ./Controllers/Fans.c
    • -123
    • +24
    ./Controllers/ROPump.c
    • -9
    • +4
    ./Controllers/ROPump.h
    • -2
    • +0
    ./Controllers/TemperatureSensors.c
    • -14
    • +16
    ./Controllers/Thermistors.c
    • -0
    • +6
    ./Modes/ModeInitPOST.c
    • -1
    • +1
    ./Services/AlarmMgmt.h
    • -7
    • +5
    ./Services/SystemComm.c
    • -66
    • +26
    ./Services/SystemCommMessages.c
    • -4
    • +1
    ./Services/SystemCommMessages.h
    • -1
    • +4
    ./Tasks/TaskGeneral.c
Tuesday 17 Nov 2020
11:16 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Updated UT and IT

Options
    • -1
    • +1
    ./Services/SystemCommMessages.c
  2. … 2 more files in changeset.
10:39 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Addressed code review

Options
    • -1
    • +1
    ./Services/SystemComm.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
    • -1
    • +1
    ./Services/SystemCommMessages.h
Monday 16 Nov 2020
10:25 pm

Dara Navaei

DEN-3421 continued adding more details to the drivers and addressed code review comments

Options
    • -182
    • +188
    ./Controllers/DrainPump.c
    • -5
    • +6
    ./Controllers/DrainPump.h
    • -2
    • +2
    ./Controllers/Fans.c
    • -152
    • +158
    ./Controllers/ROPump.c
    • -8
    • +12
    ./Controllers/ROPump.h
    • -2
    • +2
    ./Modes/ModeDrain.c
    • -2
    • +2
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -0
    • +13
    ./Services/SystemComm.c
    • -35
    • +100
    ./Services/SystemCommMessages.c
    • -3
    • +9
    ./Services/SystemCommMessages.h
2:13 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Refactor control pump separately and add reverse motor dir

Options
    • -84
    • +136
    ./Controllers/ConcentratePumps.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.h
    • -2
    • +4
    ./Modes/ModeFill.c
    • -1
    • +2
    ./Modes/ModeRecirculate.c
    • -1
    • +2
    ./Modes/ModeStandby.c
    • -6
    • +6
    ./Services/SystemCommMessages.c
  7. … 3 more files in changeset.
Sunday 15 Nov 2020
5:59 pm

Dara Navaei

DEN-3421 addressed code review comments and reviewed all the doxygen texts in RO pump

Options
    • -16
    • +12
    ./Controllers/Fans.c
    • -2
    • +0
    ./Controllers/Fans.h
    • -298
    • +377
    ./Controllers/ROPump.c
    • -5
    • +8
    ./Controllers/ROPump.h
    • -10
    • +10
    ./Controllers/Thermistors.c
    • -2
    • +2
    ./Controllers/Thermistors.h
    • -71
    • +64
    ./Controllers/UVReactors.c
    • -1
    • +1
    ./Controllers/UVReactors.h
    • -1
    • +1
    ./DGCommon.h
    • -2
    • +7
    ./Modes/ModeHeatDisinfect.c
    • -0
    • +10
    ./Modes/ModeHeatDisinfect.h
    • -1
    • +2
    ./Services/AlarmMgmt.h
    • -2
    • +12
    ./Services/FPGA.c
    • -1
    • +1
    ./Services/FPGA.h
    • -1
    • +18
    ./Services/SystemComm.c
  16. … 3 more files in changeset.
Friday 13 Nov 2020
3:36 pm

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Prevent division by zero when pumps on with zero flow rate

Options
    • -16
    • +18
    ./Controllers/ConcentratePumps.c
11:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-3504: Turn concentrate pumps during mode transition

Options
    • -1
    • +3
    ./Modes/ModeRecirculate.c
    • -1
    • +2
    ./Modes/ModeStandby.c
    • -3
    • +1
    ./Services/Reservoirs.c