dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Mar 2021
10:38 am

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -0
    • +1
    ./App/DGCommon.h
    • -1
    • +10
    ./App/Modes/ModeInitPOST.c
    • -0
    • +1
    ./App/Services/SystemComm.c
    • -1
    • +1
    ./App/Services/SystemCommMessages.h
10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Sunday 28 Mar 2021
10:34 am

Dara Navaei

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

10:34 am

Dara Navaei

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

The enum was in the document that we received from the systems team. We can discuss with them and change it if needed.

10:33 am

Dara Navaei

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

That is right. I added another build switch to only run POST on RTC and NVDataMgmt only.

10:24 am

Dara Navaei

Done.

Done.

10:23 am

Dara Navaei

Done.

Done.

Saturday 27 Mar 2021
6:21 pm

qnguyen  (deleted user)

if we skip POST, do we want to execute RTC POST test and other POST tests?

if we skip POST, do we want to execute RTC POST test and other POST tests?

6:14 pm

qnguyen  (deleted user)

Revert line deletion.

Revert line deletion.

6:13 pm

qnguyen  (deleted user)

Add break.

Add break.

12:26 pm

Dara Navaei

DEN-5963 worked on heat disinfect mode

Options
    • -6
    • +8
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Controllers/ROPump.c
    • -38
    • +37
    ./App/Controllers/TemperatureSensors.c
    • -88
    • +175
    ./App/Modes/ModeHeatDisinfect.c
12:07 pm

Dara Navaei

I moved the function to above and before the actuators.

I moved the function to above and before the actuators.

12:06 pm

Dara Navaei

Done.

Done.

12:03 pm

Dara Navaei

DEN-5980 merged staging and resolved the merge conflicts

Options
    • -19
    • +17
    ./App/Controllers/DrainPump.c
    • -0
    • +42
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/DGCommon.h
    • -40
    • +63
    ./App/Services/AlarmMgmt.c
    • -3
    • +6
    ./App/Services/AlarmMgmt.h
    • -0
    • +11
    ./App/Services/SystemComm.c
    • -21
    • +186
    ./App/Services/SystemCommMessages.c
    • -6
    • +29
    ./App/Services/SystemCommMessages.h
    • -1
    • +1
    ./App/Tasks/TaskGeneral.c
    • -14
    • +20
    ./App/Tasks/TaskPriority.c
    • -0
    • +2
    ./source/sys_main.c
Friday 26 Mar 2021
6:05 pm

Sean Nash

Merge branch 'DEN-7091-pre-treatment-mode' into develop

Options
    • -1
    • +1
    ./App/Modes/OperationModes.c
6:04 pm

Sean Nash

DEN-7091: broadcast alarm condition clear when cleared with alarm.

Options
    • -1
    • +2
    ./App/Services/AlarmMgmt.c
Thursday 25 Mar 2021
10:42 am

Sean Nash

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

Yes, jobs are added to queue from General Task and removed from queue from Background Task. Need queue operations to be protected.

Wednesday 24 Mar 2021
12:38 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -0
    • +1
    ./App/Controllers/DrainPump.c
    • -1
    • +2
    ./App/Tasks/TaskGeneral.c
    • -2
    • +2
    ./App/Tasks/TaskPriority.c
    • -1
    • +1
    ./source/sys_main.c
12:37 pm

Dara Navaei

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for ...

This section is monitoring the RPM of the drain pump and makes decision accordingly. This must be commented out until we figure out how to convert counts into RPM properly. I added a TODO note for that.

12:26 pm

Dara Navaei

Done.

Done.

12:25 pm

Dara Navaei

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

Yes. This state machine is only used when a record data is scheduled to be sent to Dialin in batches.

12:23 pm

Dara Navaei

Changed them to NVDataMgmt NVDataMgmt.

Changed them to NVDataMgmt NVDataMgmt.

12:23 pm

Dara Navaei

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

12:21 pm

Dara Navaei

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.