Activity dgfirmware/firmware

1:42 pm

Dara Navaei

More
497e638
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1

DEN-7568 work in progress

- -1
- +1
./App/Controllers/ROPump.c
- History
- Source
- Diff
./App/Controllers/ROPump.c

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

More
Re: DG-DEN-7568-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

9:32 am

Dara Navaei

More
Re: DG-DEN-7568-1
replied to qnguyen (deleted user)

Done.

6:25 pm

Sean Nash

More
e94cf93
changed 2 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1 DG-DEN-8030-1

DEN-7605: Integrated DG voltage monitor into DG f/w.

- -1
- +5
./App/Tasks/TaskGeneral.c
- History
- Source
- Diff
./App/Tasks/TaskGeneral.c
- -0
- +2
./source/sys_main.c
- History
- Source
- Diff
./source/sys_main.c

6:22 pm

Sean Nash

More
35de566
changed 10 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 214 more DG-DEN-7605-1 DG-DEN-8030-1

DEN-7605: Added new DG voltages monitor module. Updated internal ADC driver.

- -0
- +454
./App/Controllers/Voltages.c
- History
- Source
./App/Controllers/Voltages.c
- -0
- +89
./App/Controllers/Voltages.h
- History
- Source
./App/Controllers/Voltages.h
- -2
- +56
./App/Drivers/InternalADC.c
- History
- Source
- Diff
./App/Drivers/InternalADC.c
- -4
- +6
./App/Drivers/InternalADC.h
- History
- Source
- Diff
./App/Drivers/InternalADC.h
- -0
- +8
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -0
- +92
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -0
- +10
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h
- -11
- +11
./DG.dil
- History
- Source
- Diff
./DG.dil
- -1
- +1
./include/adc.h
- History
- Source
- Diff
./include/adc.h
- -5
- +5
./source/adc.c
- History
- Source
- Diff
./source/adc.c

4:24 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Only two places call this function. Should we inline and remove this function?

3:08 pm

Dara Navaei

More
3eb7c2e
changed 11 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1 DG-DEN-7605-1 DG-UCOMMITS-38

DEN-7568 merged staging and resolved merge conflicts

- -0
- +8
./.launches/DG.launch
- History
- Source
- Diff
./.launches/DG.launch
- -27
- +21
./App/Controllers/ROPump.c
- History
- Source
- Diff
./App/Controllers/ROPump.c
- -82
- +85
./App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
./App/Controllers/TemperatureSensors.c
- -35
- +191
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c
- -1
- +3
./App/Modes/ModeStandby.h
- History
- Source
- Diff
./App/Modes/ModeStandby.h
- -0
- +8
./App/Services/AlarmMgmt.h
- History
- Source
- Diff
./App/Services/AlarmMgmt.h
- -91
- +87
./App/Services/Reservoirs.c
- History
- Source
- Diff
./App/Services/Reservoirs.c
- -23
- +36
./App/Services/Reservoirs.h
- History
- Source
- Diff
./App/Services/Reservoirs.h
- -5
- +46
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -55
- +533
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -5
- +57
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h

12:19 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Check and remove unused include (ConductivitySensors.h, TemperatureSensors.h, etc.)

12:17 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Remove unused defines

12:15 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Align or remove extra space.

12:12 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Should result be set the the return of startDGFlush() and stopDGFlush() functions?

12:11 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Update to latest revision. This function should be deleted.

12:05 pm

Dara Navaei

More
63e6ce4
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 215 more DG-DEN-7568-1

DEN-7568 work in progress

- -44
- +39
./App/Modes/ModeFlush.c
- History
- Source
- Diff
./App/Modes/ModeFlush.c

12:05 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

DG_MODE_SOLO does not have DG_STANDBY_MODE_STATE_IDLE.

12:03 pm

Dara Navaei

More
DG-DEN-5963-1
Closed

12:01 pm

qnguyen (deleted user)

More
Re: DG-DEN-7568-1
commented on review

Revert the deleted comment.

11:35 am

qnguyen (deleted user) , pmontazemi (deleted user) and Sean Nash

More
DG-DEN-5963-1
finished reviewing

10:55 am

Sean Nash

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:38 am

pmontazemi (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

10:36 am

Dara Navaei

More
c8fa40d
changed 1 file
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-5963-1

DEN-5963 addressed a code review comment

- -1
- +1
./App/Controllers/Thermistors.c
- History
- Source
- Diff
./App/Controllers/Thermistors.c

10:36 am

qnguyen (deleted user)

More
Re: DG-DEN-5963-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

8:42 am

Dara Navaei

More
28b5f2e
changed 9 files
DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 216 more DG-DEN-7568-1 DG-DEN-5963-1

DEN-5963 addressed code review comments

- -21
- +0
./.launches/DG.launch
- History
- Source
- Diff
./.launches/DG.launch
- -1
- +1
./App/Controllers/Heaters.c
- History
- Source
- Diff
./App/Controllers/Heaters.c
- -1
- +1
./App/Controllers/ROPump.c
- History
- Source
- Diff
./App/Controllers/ROPump.c
- -17
- +36
./App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
./App/Controllers/TemperatureSensors.c
- -0
- +29
./App/Controllers/TemperatureSensors.h
- History
- Source
- Diff
./App/Controllers/TemperatureSensors.h
- -1
- +1
./App/Controllers/Thermistors.c
- History
- Source
- Diff
./App/Controllers/Thermistors.c
- -3
- +4
./App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfect.c
- -5
- +4
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -2
- +3
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h

11:05 pm

Dara Navaei

More
DG-DEN-7568-1
added pmontazemi (deleted user) and qnguyen (deleted user)

8:45 pm

Dara Navaei

More
Re: DG-DEN-5963-1
replied to qnguyen (deleted user)

I removed the = sign.

firmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Sean Nash

Sean Nash

qnguyen (deleted user)

Dara Navaei

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

Dara Navaei

qnguyen (deleted user)

Dara Navaei

qnguyen (deleted user)

qnguyen (deleted user) , pmontazemi (deleted user) and Sean Nash

Sean Nash

pmontazemi (deleted user)

Dara Navaei

qnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei