dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 30 Jul 2021
2:07 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7802: Changed according to lab test

Options
    • -13
    • +18
    ./App/Modes/ModeFill.c
    • -1
    • +1
    ./App/Services/Reservoirs.c
1:48 pm

Dara Navaei

Done.

Done.

10:55 am

Sean Nash

Need function header.

Need function header.

10:54 am

Sean Nash

Should we debounce switches before changing states? Check with Noe to see if FPGA is already debouncing these signals.

Should we debounce switches before changing states? Check with Noe to see if FPGA is already debouncing these signals.

10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -1
    • +1
    ./App/Controllers/ROPump.c
    • -1
    • +1
    ./App/DGCommon.h
    • -12
    • +6
    ./App/Services/FPGA.c
    • -2
    • +0
    ./App/Services/FPGA.h
Thursday 29 Jul 2021
4:42 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -1
    • +1
    ./App/Controllers/DrainPump.c
    • -9
    • +17
    ./App/Controllers/Switches.c
    • -8
    • +1
    ./App/Controllers/Switches.h
    • -1
    • +1
    ./App/Controllers/UVReactors.c
    • -0
    • +7
    ./App/Controllers/UVReactors.h
    • -0
    • +2
    ./App/Modes/ModeRecirculate.c
    • -10
    • +11
    ./App/Services/AlarmMgmt.h
    • -3
    • +2
    ./App/Services/Reservoirs.c
    • -3
    • +2
    ./App/Services/SystemCommMessages.c
4:40 pm

Dara Navaei

Done.

Done.

4:39 pm

Dara Navaei

I removed the enum.

I removed the enum.

4:38 pm

Dara Navaei

These fill volumes will come from non-volatile memory. I also removed the TODOs.

These fill volumes will come from non-volatile memory. I also removed the TODOs.

4:38 pm

Dara Navaei

Done.

Done.

4:35 pm

Dara Navaei

Done.

Done.

4:34 pm

Dara Navaei

Fixed it.

Fixed it.

4:33 pm

Dara Navaei

Done.

Done.

4:28 pm

Dara Navaei

If the calibration data is invalid, the function will raise an alarm. But the all the calibration records that fail CRC test will be in benign values by NVDataMgmt.c so the benign value is taken as...

If the calibration data is invalid, the function will raise an alarm. But the all the calibration records that fail CRC test will be in benign values by NVDataMgmt.c so the benign value is taken as the target flush volume.

4:26 pm

Dara Navaei

This function is called during POST to get all the pertaining calibration data but since the modes do not have have POST states, it was decided to use DrainPump.c to get the calibration information.

This function is called during POST to get all the pertaining calibration data but since the modes do not have have POST states, it was decided to use DrainPump.c to get the calibration information.

4:24 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

Bamboo will do the copyrights. It is not turned on right now but it will automatically.

Bamboo will do the copyrights. It is not turned on right now but it will automatically.