dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 06 Nov 2021
7:24 pm

Dara Navaei

DEN-9480 addressed the code review comments

Options
    • -1
    • +2
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +2
    ./App/Controllers/DrainPump.c
    • -1
    • +2
    ./App/Controllers/Fans.c
    • -1
    • +2
    ./App/Controllers/FluidLeak.c
    • -1
    • +2
    ./App/Controllers/LoadCell.c
    • -6
    • +10
    ./App/Controllers/Pressures.c
    • -17
    • +26
    ./App/Controllers/ROPump.c
    • -1
    • +2
    ./App/Controllers/Switches.c
    • -1
    • +2
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +3
    ./App/Controllers/Thermistors.c
    • -1
    • +2
    ./App/Controllers/UVReactors.c
    • -2
    • +5
    ./App/Controllers/Valves.c
    • -2
    • +3
    ./App/Controllers/Voltages.c
    • -1
    • +2
    ./App/DGCommon.h
    • -3
    • +4
    ./App/Modes/ModeChemicalDisinfect.c
  16. … 16 more files in changeset.
4:37 pm

Dara Navaei

Done.

Done.

4:36 pm

Dara Navaei

Done.

Done.

4:23 pm

Dara Navaei

I do not see this mode my local code base. It might have been git.

I do not see this mode my local code base. It might have been git.

4:07 pm

Dara Navaei

Done.

Done.

4:06 pm

Dara Navaei

The drain flow rate does not matter in any of the disinfects. The faster the drain, the better.

The drain flow rate does not matter in any of the disinfects. The faster the drain, the better.

4:04 pm

Dara Navaei

Added the TODO back.

Added the TODO back.

4:03 pm

Dara Navaei

No it is uncommented.

No it is uncommented.

4:00 pm

Dara Navaei

Subtract 0.0 was unnecessary. I deleted it.

Subtract 0.0 was unnecessary. I deleted it.

3:57 pm

Dara Navaei

This was not the right place for the function. I deleted the function.

This was not the right place for the function. I deleted the function.

3:57 pm

Dara Navaei

This function is no longer needed and I deleted it.

This function is no longer needed and I deleted it.

3:56 pm

Dara Navaei

With 2400 RPM the flow rate was ~2497.718 mL/min. I changed the target RPM to 2300.

With 2400 RPM the flow rate was ~2497.718 mL/min. I changed the target RPM to 2300.

3:48 pm

Dara Navaei

Friday 05 Nov 2021
4:57 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
4:56 pm

Dara Navaei

Removed the RTC RAM write in Fill mode. Quick fix

Options
    • -1
    • +0
    ./App/Modes/ModeFill.c
11:39 am

Sean Nash

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

11:17 am

Sean Nash

Who would call this function?

Who would call this function?

11:15 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
11:14 am

Dara Navaei

Removed a DEBUG_DENALI comment

Options
    • -2
    • +0
    ./App/Controllers/TemperatureSensors.c
11:13 am

Sean Nash

We're saving fill data to RTC RAM every 50ms?

We're saving fill data to RTC RAM every 50ms?

11:11 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
11:10 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/dg/dgfirmware into develop

Options
    • -1
    • +1
    ./App/DGCommon.h
11:10 am

Dara Navaei

Merged DEN-9480 and resolved merge conflicts

Options
    • -37
    • +114
    ./App/Controllers/DrainPump.c
    • -74
    • +130
    ./App/Controllers/Heaters.c
    • -2
    • +1
    ./App/Controllers/ROPump.c
    • -0
    • +2
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +1
    ./App/DGCommon.h
    • -31
    • +58
    ./App/Modes/ModeDrain.c
    • -28
    • +62
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Modes/ModeFlush.c
    • -2
    • +0
    ./App/Modes/ModeGenIdle.c
    • -3
    • +3
    ./App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    ./App/Services/SystemComm.c
    • -3
    • +35
    ./App/Services/SystemCommMessages.c
    • -2
    • +5
    ./App/Services/SystemCommMessages.h
11:09 am

Sean Nash

What's happening here? Why subtract 0?

What's happening here? Why subtract 0?

10:52 am

Dara Navaei

DEN-9480 tested RTC stop clock and drain mode

Options
    • -0
    • +2
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +1
    ./App/Modes/ModeService.h
9:20 am

Sean Nash

I don't see where this alarm is being triggered.

I don't see where this alarm is being triggered.

Thursday 04 Nov 2021
11:45 am

Sean Nash

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

11:44 am

Sean Nash

Should we keep the TODO for this?

Should we keep the TODO for this?

11:40 am

Sean Nash

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

11:38 am

Hung Nguyen <hnguyen@diality.com>

DEN-9906 Added new alarm ID for dialysate flow out of range

Options
    • -2
    • +1
    ./App/Controllers/DialysateFlow.c