dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Mar 2022
6:36 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per code review comments

Options
    • -15
    • +15
    ./App/Modes/ModeDrain.c
    • -1
    • +1
    ./App/Modes/ModeFill.c
    • -5
    • +6
    ./App/Modes/ModeGenIdle.c
6:30 pm

hnguyen  (deleted user)

At the end of drain, check for empty bottles

At the end of drain, check for empty bottles

6:24 pm

hnguyen  (deleted user)

Replaced else if ( ( FALSE == isAlarmActive( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME ) ) || ( FALSE == isAlarmActive( ALARM_ID_DG_BICARB_BOTTLE_LOW_VOLUME ) ) ) { with else {

Replaced
else if ( ( FALSE == isAlarmActive( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME ) ) ||
( FALSE == isAlarmActive( ALARM_ID_DG_BICARB_BOTTLE_LOW_VOLUME ) ) )
{
with
else
{

6:02 pm

hnguyen  (deleted user)

Removed setBottlesNeedPrimeFlag and use function setThisFirstFillFlag().

Removed setBottlesNeedPrimeFlag and use function setThisFirstFillFlag().

5:58 pm

hnguyen  (deleted user)

Removed fillBottlesNeedPrimeFlag and use the existing isThisFirstFill

Removed fillBottlesNeedPrimeFlag and use the existing isThisFirstFill

5:57 pm

hnguyen  (deleted user)

isAvgConductivityOutOfRange is now called in ModeGenIdle

isAvgConductivityOutOfRange is now called in ModeGenIdle

5:48 pm

hnguyen  (deleted user)

Added startFillCmd( targetFillVolumeML, getTargetFillFlowRateLPM() ); // refill to the saved target fill volume (~1500 mL)

Added
startFillCmd( targetFillVolumeML, getTargetFillFlowRateLPM() ); // refill to the saved target fill volume (~1500 mL)

5:14 pm

hnguyen  (deleted user)

Assigned MSG_ID_DG_FILL_MODE_DATA = 0xAE, ///< DG broadcast of fill mode data such as used acid & bicarb volume Updated Message List.xlsx (Denali Tab, Row = 142) with 0xAE00 DG Fill Mode Data

Assigned MSG_ID_DG_FILL_MODE_DATA = 0xAE, ///< DG broadcast of fill mode data such as used acid & bicarb volume
Updated Message List.xlsx (Denali Tab, Row = 142) with 0xAE00 DG Fill Mode Data

12:30 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
12:20 pm

Dara Navaei

Merged DEN-12224

Options
    • -83
    • +124
    ./App/Controllers/ConcentratePumps.c
    • -10
    • +14
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +1
    ./App/DGCommon.h
12:16 pm

Dara Navaei

DEN-12224, DEN-12436 removed the concentrate pumps requested flow fault alarm if it was out of range

Options
    • -82
    • +124
    ./App/Controllers/ConcentratePumps.c
    • -0
    • +2
    ./App/Controllers/ConcentratePumps.h
    • -10
    • +14
    ./App/Controllers/ConductivitySensors.c
    • -2
    • +1
    ./App/Controllers/DialysateFlow.c
    • -2
    • +6
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +1
    ./App/DGCommon.h
    • -2
    • +3
    ./App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./App/Services/AlarmMgmtSWFaults.h
Friday 18 Mar 2022
5:39 pm

Hung Nguyen <hnguyen@diality.com>

DEN-11928 Updated per peer review comments

Options
    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -15
    • +17
    ./App/Modes/ModeDrain.c
    • -50
    • +10
    ./App/Modes/ModeFill.c
    • -5
    • +1
    ./App/Modes/ModeFill.h
    • -16
    • +25
    ./App/Modes/ModeGenIdle.c
4:55 pm

hnguyen  (deleted user)

Idle mode calls BOOL isAvgConductivityOutOfRange( void ){ return fillStatus.fillAvgConductivityOutOfRange; }

Idle mode calls
BOOL isAvgConductivityOutOfRange( void )

Unknown macro: { return fillStatus.fillAvgConductivityOutOfRange; }
4:04 pm

hnguyen  (deleted user)

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

4:02 pm

hnguyen  (deleted user)

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

3:43 pm

hnguyen  (deleted user)

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

2:17 pm

hnguyen  (deleted user)

Set result = DG_HANDLE_BAD_FILL_STATE_START;

Set result = DG_HANDLE_BAD_FILL_STATE_START;

2:01 pm

hnguyen  (deleted user)

Wait here for alarm is no longer active, then transition to fill mode.

Wait here for alarm is no longer active, then transition to fill mode.

1:31 pm

hnguyen  (deleted user)

Done.

Done.

1:30 pm

hnguyen  (deleted user)

Done.

Done.

1:03 pm

hnguyen  (deleted user)

Removed flushWaterVolumeL.

Removed flushWaterVolumeL.

1:02 pm

hnguyen  (deleted user)

Removed TARGET_FLUSH_WATER_RO_FLOW_RATE_L

Removed TARGET_FLUSH_WATER_RO_FLOW_RATE_L

12:59 pm

hnguyen  (deleted user)

Replaced with activateAlarmNoData.

Replaced with activateAlarmNoData.

12:55 pm

hnguyen  (deleted user)

Changed this function to private.

Changed this function to private.

12:50 pm

hnguyen  (deleted user)

Removed requestNewOperationMode( DG_MODE_GENE );

Removed requestNewOperationMode( DG_MODE_GENE );

12:49 pm

hnguyen  (deleted user)

Removed requestNewOperationMode( DG_MODE_GENE );

Removed requestNewOperationMode( DG_MODE_GENE );

11:23 am

hnguyen  (deleted user)

Removed return.

Removed return.

11:08 am

hnguyen  (deleted user)

Changed COND_SENSOR_CPI_WARNING_HIGH to COND_SENSOR_CPI_WARNING_LOW

Changed COND_SENSOR_CPI_WARNING_HIGH to COND_SENSOR_CPI_WARNING_LOW

10:58 am

hnguyen  (deleted user)

Done.

Done.

10:53 am

hnguyen  (deleted user)

Done.

Done.