firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Fixed temperatureSensors driver with the newest faults

    • -4
    • +4
    ./App/Controllers/TemperatureSensors.c
DEN-12974, DEN-13078 correct setting of VPo when entering handleFlushModeDrainR2State.

That would also require a change to the requirements.

That would also require a change to the requirements.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-12847 Code review comments update.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.

10-20 seems like a better number, but my sample size is small so I did not change it.

10-20 seems like a better number, but my sample size is small so I did not change it.

Updated

Updated

Updated

Updated

DEN-12847 Code review comments update.

DEN-12974 Code review updates

    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

Removed blank line

Removed blank line

Will add back in.

Will add back in.

Are we sticking with this threshold?

Are we sticking with this threshold?

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).

Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).