dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
1:53 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -8
    • +10
    ./App/Controllers/ROPump.c
    • -1
    • +0
    ./App/Controllers/ROPump.h
    • -15
    • +13
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Modes/ModeInitPOST.c
    • -3
    • +0
    ./App/Services/PIControllers.h
1:51 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:50 pm

wbracken  (deleted user)

Update header.

Update header.

1:50 pm

wbracken  (deleted user)

Update header.

Update header.

1:49 pm

Michael Garthwaite

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212 The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBAC...

Testers requested the feature as feed back voltage. see http://dvm-linux02:8080/browse/DIAL-212

The static variable name is roPumpFeedbackDutyCyclePct. We get data from the INT_ADC_RO_PUMP_FEEDBACK_DUTY_CYCLE register on the FPGA in execROPumpMonitor/

No issue renaming it but is it a voltage or a duty cycle?

1:48 pm

wbracken  (deleted user)

Remove

Remove

1:48 pm

wbracken  (deleted user)

Alignment

Alignment

1:47 pm

wbracken  (deleted user)

Remove

Remove

1:47 pm

wbracken  (deleted user)

Alignment

Alignment

1:44 pm

wbracken  (deleted user)

Alignment

Alignment

1:42 pm

wbracken  (deleted user)

Alignment and commented out code.

Alignment and commented out code.

1:41 pm

wbracken  (deleted user)

Needs function header.

Needs function header.

1:40 pm

wbracken  (deleted user)

Alignment

Alignment

1:40 pm

wbracken  (deleted user)

Alignment

Alignment

1:39 pm

wbracken  (deleted user)

Alignment

Alignment

1:38 pm

wbracken  (deleted user)

Alignment

Alignment

1:37 pm

wbracken  (deleted user)

Alignment

Alignment

1:36 pm

wbracken  (deleted user)

Alignment

Alignment

1:35 pm

wbracken  (deleted user)

Remove.

Remove.

1:35 pm

wbracken  (deleted user)

Alignment

Alignment

1:34 pm

wbracken  (deleted user)

Remove commented code.

Remove commented code.

1:34 pm

wbracken  (deleted user)

Alignment

Alignment

1:29 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:29 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:28 pm

Sean Nash

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

I think it's abbreviated - should be spelled out (inactiveReservoir) I think.

1:23 pm

Sean Nash

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.

1:21 pm

Sean Nash

Add another blank line here (separates normal code from test code).

Add another blank line here (separates normal code from test code).

1:21 pm

wbracken  (deleted user)

Alignment.

Alignment.

1:19 pm

wbracken  (deleted user)

Alignment

Alignment

1:17 pm

wbracken  (deleted user)

Alignment

Alignment