dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 21 Nov 2022
2:04 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -17
    • +8
    ./App/Services/PIControllers.c
    • -1
    • +0
    ./App/Services/PIControllers.h
2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:02 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:01 pm

Michael Garthwaite

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get ...

Yes and no for the place holder. The profiles expected to change in the future. They may have different load states but for now we have tuned Kp and Ki along with our maximum PWM step limit to get the level of responsiveness we wanted to achieve with this optimization task. We can further fine tune the pump profiles with this data structure if necessary. setROPIFlowProfile will be called in when we transition operation modes when we intend to differentiate between profiles.

2:01 pm

Sean Nash

Remove blank line.

Remove blank line.

2:00 pm

Sean Nash

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

Based on function name, this function only expects to change step limit. So shouldn't need to pass signalID as param and shouldn't need a switch.

2:00 pm

wbracken  (deleted user)

Alignment

Alignment

2:00 pm

wbracken  (deleted user)

Remove blank line

Remove blank line

1:58 pm

wbracken  (deleted user)

Alignment

Alignment

1:57 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:57 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:56 pm

Michael Garthwaite

Fixed. Thanks! This complied with no issue... it was thinking inactiveRsrvr was from the inactiveRsrvr within the HEATER_STATUS_T data structure.

Fixed. Thanks!

This complied with no issue... it was thinking inactiveRsrvr was from the inactiveRsrvr within the HEATER_STATUS_T data structure.

1:55 pm

wbracken  (deleted user)

Set alarm pending here?

Set alarm pending here?

1:55 pm

wbracken  (deleted user)

Update header.

Update header.

1:54 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:54 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:54 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:54 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:54 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:53 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:53 pm

wbracken  (deleted user)

Should the pending alarm state be set here?

Should the pending alarm state be set here?

1:53 pm

Michael Garthwaite

DEN-14197: Addressed code review comments.

Options
    • -8
    • +10
    ./App/Controllers/ROPump.c
    • -1
    • +0
    ./App/Controllers/ROPump.h
    • -15
    • +13
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Modes/ModeInitPOST.c
    • -3
    • +0
    ./App/Services/PIControllers.h