dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Dec 2022
4:52 pm

Sean Nash

DEN-14307: Added support for parking concentrate pumps.

Options
    • -14
    • +252
    ./App/Controllers/ConcentratePumps.c
    • -1
    • +12
    ./App/Controllers/ConcentratePumps.h
    • -4
    • +4
    ./App/Modes/ModeChemicalDisinfect.c
    • -2
    • +2
    ./App/Modes/ModeDrain.c
    • -2
    • +2
    ./App/Modes/ModeFault.c
    • -5
    • +5
    ./App/Modes/ModeFill.c
    • -2
    • +2
    ./App/Modes/ModeFlush.c
    • -2
    • +2
    ./App/Modes/ModeGenIdle.c
    • -6
    • +6
    ./App/Modes/ModeHeatDisinfect.c
    • -4
    • +153
    ./App/Services/FPGA.c
    • -1
    • +10
    ./App/Services/FPGA.h
    • -0
    • +12
    ./App/Services/SystemComm.c
    • -1
    • +90
    ./App/Services/SystemCommMessages.c
    • -0
    • +10
    ./App/Services/SystemCommMessages.h
11:16 am

Dara Navaei

DEN-14307 updated the cleaning modes per the SRS changes

Options
    • -1
    • +1
    ./App/Controllers/ConcentratePumps.c
    • -23
    • +36
    ./App/Controllers/ConductivitySensors.c
    • -12
    • +40
    ./App/Controllers/Pressures.c
    • -33
    • +43
    ./App/Controllers/TemperatureSensors.c
    • -5
    • +37
    ./App/Modes/ModeFlush.c
    • -67
    • +59
    ./App/Modes/ModeHeatDisinfect.c
    • -1
    • +29
    ./App/Services/AlarmMgmt.c
    • -0
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -0
    • +4
    ./App/Services/SystemComm.c
    • -65
    • +108
    ./App/Services/SystemCommMessages.c
    • -0
    • +6
    ./App/Services/SystemCommMessages.h
9:35 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
9:32 am

Michael Garthwaite

Merge branch 'DEN-14433-sw-s86-mg-publish-fixes' into develop

Options
    • -2
    • +2
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Controllers/Switches.c
9:32 am

Michael Garthwaite

DEN-14433: DIAL-123: fixed broadcast messages to send if we are >= of their respective intervals instead of >.

Options
    • -1
    • +1
    ./App/Controllers/Switches.c
    • -1
    • +1
    ./App/Controllers/Thermistors.c
    • -1
    • +1
    ./App/Controllers/UVReactors.c
Thursday 15 Dec 2022
10:54 pm

Sean Nash

12:36 pm

Steve Jarpe <sjarpe@diality.com>

/DEN-14316-chemical-disinfect. Address code review. Changes due to debugging and testing.

Options
    • -367
    • +420
    ./App/Modes/ModeChemicalDisinfect.c
    • -275
    • +225
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +1
    ./App/Modes/ModeStandby.c
Saturday 10 Dec 2022
11:03 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
Thursday 08 Dec 2022
10:50 am

Michael Garthwaite

10:50 am

Michael Garthwaite

Wednesday 07 Dec 2022
3:50 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
3:49 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-13050-vpi-does-not-close-after-sample-water-returns-to-flush-idle' into develop

Options
    • -21
    • +13
    ./App/Controllers/LoadCell.c
3:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13757 - Remove unused function monitorLoadCellsWeightOutOfRange/

Options
    • -20
    • +0
    ./App/Controllers/LoadCell.c
2:49 pm

Dara Navaei

DG-DEN-13050_Vpi Does Not Close After Sample Water Returns TO Flush Idle
DG-DEN-13050_Vpi Does Not Close After Sample Water Returns TO Flush Idle
2:25 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13757 - Correction to load cell alarm.

Options
    • -2
    • +2
    ./App/Controllers/LoadCell.c
Tuesday 06 Dec 2022
5:08 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13757 - All 4 load cells have a single persistent alarm. Change to correspond to how pressure alarms are handled.

Options
    • -1
    • +13
    ./App/Controllers/LoadCell.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfect.c
3:21 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. This is a testing version. It is not yet complete.

Options
    • -272
    • +470
    ./App/Modes/ModeChemicalDisinfect.c
    • -64
    • +66
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -731
    • +667
    ./App/Modes/ModeFlush.c
    • -2
    • +2
    ./App/Modes/OperationModes.c
Monday 05 Dec 2022
12:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-13050

Options
    • -2
    • +2
    ./App/Modes/ModeHeatDisinfect.c
10:17 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
10:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./App/Controllers/FlowSensors.c
    • -1
    • +1
    ./App/Controllers/FlowSensors.h
    • -1
    • +1
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Modes/ModeDrain.c
10:16 am

Dara Navaei

9:43 am

Sean Nash

9:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:42 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Friday 02 Dec 2022
5:51 pm

Michael Garthwaite

5:50 pm

Dara Navaei

DEN-14253 addressed the code review comments

Options
    • -4
    • +5
    ./App/Controllers/FlowSensors.c
    • -1
    • +1
    ./App/Controllers/Heaters.c
5:50 pm

Dara Navaei

Done.

Done.

5:43 pm

Dara Navaei

Done.

Done.

4:50 pm

Sean Nash

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

4:43 pm

Sean Nash

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.

For both sensors, the .data should only be set once to final value. Use a temporary local variable until it's ready.