firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merged DEN-14307

    • -28
    • +300
    ./App/Controllers/ConcentratePumps.c
    • -23
    • +40
    ./App/Controllers/ConductivitySensors.c
    • -65
    • +276
    ./App/Services/SystemCommMessages.c
    • -4
    • +22
    ./App/Services/SystemCommMessages.h
DEN-14316-chemical-disinfect. Code review changes

    • -35
    • +34
    ./App/Modes/ModeChemicalDisinfect.c
    • -10
    • +10
    ./App/Modes/ModeChemicalDisinfectFlush.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +1
    ./App/Controllers/TemperatureSensors.c
    • -2
    • +2
    ./App/Controllers/TemperatureSensors.h
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfectFlush.c
  1. … 12 more files in changeset.
RESOLVED IN CODE WALKTRHOUGH.

RESOLVED IN CODE WALKTRHOUGH.

These two variables are local.

These two variables are local.

Add concCap and diaCap to header.

Add concCap and diaCap to header.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Merged staging

    • -1302
    • +856
    ./App/Modes/ModeChemicalDisinfect.c
    • -0
    • +1073
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -36
    • +288
    ./App/Services/SystemCommMessages.c
    • -1
    • +21
    ./App/Services/SystemCommMessages.h
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -5
    • +5
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -5
    • +5
    ./App/Modes/ModeChemicalDisinfectFlush.h
DEN-14316 merged staging

    • -46
    • +262
    ./App/Services/SystemCommMessages.c
    • -1
    • +20
    ./App/Services/SystemCommMessages.h
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

DEN-14307 addressed the code review comment

Done

Done

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-14316: Addressed code review comments.

    • -5
    • +6
    ./App/Modes/ModeChemicalDisinfectFlush.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

RESOLVED IN CODEWALKTHROUGH.

Should add alarmDetectedPendingTrigger and preFlushState.

Should add alarmDetectedPendingTrigger and preFlushState.