dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 10 Jan 2023
8:30 am

Sean Nash

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum). Could also create a redundant 0 enum like below and use the "first" enum to initial...

Setting first iterator to 0 seems safer (in case somebody adds a new enum before what used to be the first enum).
Could also create a redundant 0 enum like below and use the "first" enum to initialize a loop iterator safely:
enum list
{
FIRST_TEMP_SENSOR = 0,
TPI_SENSOR = FIRST_TEMP_SENSOR,
TPO_SENSOR,
TD1_SENSOR,
....
}
RESOLVED in CODE WALKTHROUGH.

8:24 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 09 Jan 2023
11:37 am

wbracken  (deleted user)

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typ...

Similar code is in other monitoring functions. monitorTemperatureSensors, monitorPressureSensors iterate over their list of sensors using U08. monitorThermistors iterates over thermistors using typedef THERMISTORS_TEMP_SENSORS_T. Changed load cells to use U08 to be consistent with temperature and pressure monitoring.

Should probably change temperature, pressure and load cells to use correct typedef.

Also, it looks like why the typedefs weren't used was in order to set the initial value of the iterator to 0 (i.e, the first sensor in the list). Seems like there should be a value that is the first item in the list, i.e. TEMPSENSORS_FIRST_SENSOR.

11:07 am

wbracken  (deleted user)

Removed.

Removed.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

Friday 06 Jan 2023
4:35 pm

Dara Navaei

4:33 pm

wbracken  (deleted user) and Sean Nash

4:02 pm

Sean Nash

Why change this to U08?

Why change this to U08?

3:00 pm

Dara Navaei

DG-DEN-14548_Alarm 247 ON DG Heat Disinfect
DG-DEN-14548_Alarm 247 ON DG Heat Disinfect
10:58 am

wbracken  (deleted user)

Add to header and alignment.

Add to header and alignment.

Thursday 05 Jan 2023
4:30 pm

Dara Navaei

4:22 pm

jtaylor  (deleted user) , wbracken  (deleted user) and Dara Navaei

11:38 am

Sean Nash

Use get function for override.

Use get function for override.

Wednesday 04 Jan 2023
3:00 pm

Dara Navaei

DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
DG-DEN-13946_Certain Temperature Sensors Trigger Wrong Alarm
3:00 pm

Dara Navaei

DG-DEN-14086_Alarm 159 Dialysate Inlet Pump Failed Flow VS Motor Speed Check
DG-DEN-14086_Alarm 159 Dialysate Inlet Pump Failed Flow VS Motor Speed Check
12:01 pm

wbracken  (deleted user)

Assume this is for testing?

Assume this is for testing?

Tuesday 03 Jan 2023
3:46 pm

Dara Navaei

1:57 pm

Sean Nash , Dara Navaei , wbracken  (deleted user) and jtaylor  (deleted user)

10:10 am

Dara Navaei

8:50 am

Sean Nash

8:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 02 Jan 2023
5:14 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:46 pm

Dara Navaei

Done

Done

4:45 pm

Dara Navaei

Done.

Done.

4:44 pm

Dara Navaei

Done.

Done.

4:32 pm

Dara Navaei

Done.

Done.

Sunday 01 Jan 2023
11:11 pm

wbracken  (deleted user)

Should be removed?

Should be removed?

11:07 pm

wbracken  (deleted user)

The description seems to be missing a few words.

The description seems to be missing a few words.