Activity dgfirmware/firmware

Tree
Accordion

Stats

Commits this week: 3

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	3

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 25 Jan 2023

1:06 pm

Michael Garthwaite

More
a445c78
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 165 more DG-DEN-14627-1

DEN-14627: updated fan temperature to reflect requirements.

- -10
- +1
./App/Controllers/Fans.c
- History
- Source
- Diff
./App/Controllers/Fans.c

11:18 am

Dara Navaei

More
DG-DEN-14645-1
left review

11:06 am

James Walter Taylor <jtaylor@diality.com>

More
4d36442
changed 1 file
DEN-14561-_release_-preprocessor-flag-specifies-code-that-conflicts-with-sw_config_-debug, DEN-14902-bootloader-for-dg, develop DG-DEN-14561-1

DG-DEN-14561

Corrected debug concentrate pump park disable behavior, in beta hardware.

- -3
- +3
./App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
./App/Controllers/ConcentratePumps.c

11:01 am

Dara Navaei

More
DG-DEN-14645-1
started review

DG-DEN-14645_Dry Self Tests DO Not Start Complete

DG-DEN-14645_Dry Self Tests DO Not Start Complete

10:27 am

Dara Navaei

More
DG-DEN-14645-1
Needs Fixing

10:27 am

Dara Navaei

More
DG-DEN-14645-1
Abandoned

9:35 am

James Walter Taylor <jtaylor@diality.com>

More
07c5d9c
changed 1 file
DEN-14561-_release_-preprocessor-flag-specifies-code-that-conflicts-with-sw_config_-debug, DEN-14902-bootloader-for-dg, develop DG-DEN-14561-1

DG-DEN-14561

Corrected double negative debug test condition.

- -1
- +1
./App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
./App/Controllers/ConcentratePumps.c

9:31 am

Dara Navaei

More
63d007f
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 166 more DG-DEN-14645-1

DEN-14645 expanded the TDi/TRo drift limit temporarily

- -2
- +2
./App/Controllers/TemperatureSensors.c
- History
- Source
- Diff
./App/Controllers/TemperatureSensors.c

Tuesday 24 Jan 2023

2:39 pm

wbracken (deleted user)

More
Re: DG-DEN-14604-1
commented on review

Comments

Comments

10:00 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

10:00 am

Michael Garthwaite

Merge branch 'DEN-14589-DIAL-211' into develop

- -4
- +4
./App/Controllers/LoadCell.c
- History
- Source
- Diff
./App/Controllers/LoadCell.c
- -1
- +5
./App/Modes/ModeInitPOST.c
- History
- Source
- Diff
./App/Modes/ModeInitPOST.c

9:59 am

Michael Garthwaite

More
e2f9ac6
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 158 more DG-DEN-14589-1

DEN-14589: fixed baro sensor to consider hw config

- -1
- +1
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c

9:43 am

Dara Navaei

More
1440a4a
changed 5 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 164 more DG-DEN-14604-1

DEN-14604 updated the code to be able to use multiple heat disinfect timers per the new requirements

- -1
- +1
./App/Controllers/ConcentratePumps.c
- History
- Source
- Diff
./App/Controllers/ConcentratePumps.c
- -6
- +8
./App/Controllers/Heaters.c
- History
- Source
- Diff
./App/Controllers/Heaters.c
- -1
- +1
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c
- -96
- +187
./App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfect.c
- -1
- +4
./App/Modes/ModeHeatDisinfect.h
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfect.h

Monday 23 Jan 2023

3:14 pm

Dara Navaei

More
c975120
changed 1 file
master, DEN-13154-heparin-syringe-empty-position-incorrect and 166 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

3:14 pm

Dara Navaei

More
4c7ef2a
changed 5 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 166 more DG-DEN-14604-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./App/Controllers/LoadCell.c
- History
- Source
- Diff
./App/Controllers/LoadCell.c
- -1
- +1
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c
- -1
- +1
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c
- -1
- +1
./App/Modes/ModeInitPOST.c
- History
- Source
- Diff
./App/Modes/ModeInitPOST.c
- -1
- +1
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

3:09 pm

Dara Navaei

More
DG-DEN-14607-1
Closed

3:02 pm

Dara Navaei

More
DG-DEN-14589-1
started review

DG-DEN-14589_Dialin_RTC_Battery_syringe

DG-DEN-14589_Dialin_RTC_Battery_syringe

10:15 am

wbracken (deleted user) and Sean Nash

More
DG-DEN-14607-1
finished reviewing

10:00 am

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:10 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:09 am

Dara Navaei

More
40567cc
changed 2 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 167 more DG-DEN-14607-1

DEN-14607 addressed the code review comments

- -6
- +0
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c
- -1
- +0
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c

8:58 am

Dara Navaei

More
Re: DG-DEN-14607-1
replied to wbracken (deleted user)

They have been aligned.

They have been aligned.

8:57 am

Dara Navaei

More
Re: DG-DEN-14607-1
replied to Sean Nash

Done

Done

8:56 am

Dara Navaei

More
Re: DG-DEN-14607-1
replied to Sean Nash

I removed the override.

I removed the override.

Sunday 22 Jan 2023

9:21 pm

wbracken (deleted user)

More
Re: DG-DEN-14607-1
commented on review

AlarmDefs changes need to be reconciled with the DG SRS

AlarmDefs changes need to be reconciled with the DG SRS

2:07 pm

Sean Nash

More
Re: DG-DEN-14607-1
commented on review

Why is there an exception for overrides? Override is gauge, right? So we should always add baro to get absolute here, right?

Why is there an exception for overrides? Override is gauge, right? So we should always add baro to get absolute here, right?

Saturday 21 Jan 2023

4:20 pm

Sean Nash

More
Re: DG-DEN-14607-1
commented on review

Remove blank line.

Remove blank line.

12:22 pm

Dara Navaei

More
616d085
changed 2 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 167 more DG-DEN-14607-1

DEN-14631 added the inlet water check functions to the POST and Standby modes

- -0
- +4
./App/Modes/ModeInitPOST.c
- History
- Source
- Diff
./App/Modes/ModeInitPOST.c
- -2
- +5
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

Friday 20 Jan 2023

5:17 pm

Dara Navaei

More
702f245
changed 3 files
master, DEN-13154-heparin-syringe-empty-position-incorrect and 167 more DG-DEN-14607-1

DEN-14607, DEN-13999 updated the fill mode the not command the VPo valve to fill state upon exiting the pause state. Updated the pressures driver to assume the overidden pressure is absolute and not add the baro pressure to make it absolute

- -2
- +2
./App/Controllers/LoadCell.c
- History
- Source
- Diff
./App/Controllers/LoadCell.c
- -3
- +10
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c
- -5
- +4
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-17 16:57 -0700