firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Fixed. Thanks!

Fixed. Thanks!

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Remove old function call.

Remove old function call.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Removed one. Thanks.

Removed one. Thanks.

This variable is assigned twice in this init function

This variable is assigned twice in this init function

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

Removed the variables.

Removed the variables.

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

I removed the variable from the documentation.

I removed the variable from the documentation.

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

DG-DEN-14859_Cleaning Modes State Timer Reset
DG-DEN-14859_Cleaning Modes State Timer Reset
Add space between ( and TRUE.

Add space between ( and TRUE.