dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Mar 2023
2:33 pm

Michael Garthwaite

2:32 pm

wbracken  (deleted user) and jtaylor  (deleted user)

Thursday 02 Mar 2023
10:29 am

Michael Garthwaite

I believe this MSG_ID is being removed in another branch

I believe this MSG_ID is being removed in another branch

10:28 am

Michael Garthwaite

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2 Ill reorganize ...

happens in FW common. This branch wasn't created at the start and our automated scripted ended up created its own code review. See: http://devapps.diality.us:8060/cru/DG-DEN-14689-2
Ill reorganize the review naming shortly.

10:21 am

Sean Nash

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

Should REQUEST be moved to end of name? Seems like there are many enum names where REQUEST is not at end of name.

10:19 am

Sean Nash

Is this a response to request above or a data broadcast?

Is this a response to request above or a data broadcast?

10:18 am

Sean Nash

Should this have _REQUEST added to end?

Should this have _REQUEST added to end?

10:13 am

Sean Nash

10:02 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:23 am

jtaylor  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Wednesday 01 Mar 2023
2:49 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:11 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:10 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Monday 27 Feb 2023
3:15 pm

Dara Navaei

3:12 pm

wbracken  (deleted user) , Michael Garthwaite and Sean Nash

3:12 pm

dcox  (deleted user)

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

Default case sets status = FALSE. Setting to TRUE here is inconsistent with that.

3:09 pm

dcox  (deleted user)

Remove old function call.

Remove old function call.

2:54 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

2:53 pm

Dara Navaei

Removed one. Thanks.

Removed one. Thanks.

2:07 pm

Michael Garthwaite

This variable is assigned twice in this init function

This variable is assigned twice in this init function

2:06 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:05 pm

Dara Navaei

Removed the variables.

Removed the variables.

2:05 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

2:03 pm

Dara Navaei

I removed the variable from the documentation.

I removed the variable from the documentation.

2:01 pm

Michael Garthwaite

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

rsrvrFillStableTimeCounter is no longer used in getRsrvrDrainStatus()

1:59 pm

Michael Garthwaite

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

targetDisinfectTime is only used in publishing. Documentation says its used in getHeatDisinfectStatus but its not used. Is it still needed?

1:42 pm

Dara Navaei

DG-DEN-14859_Cleaning Modes State Timer Reset
DG-DEN-14859_Cleaning Modes State Timer Reset
11:09 am

Sean Nash

Add space between ( and TRUE.

Add space between ( and TRUE.