firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14763 addressed the code review comments'

    • -1
    • +1
    ./App/Modes/ModeHeatDisinfectActiveCool.c
This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

Done

Done

DEN-14689: Fixed duplicate case

DEN-14689: sync'd out of message naming

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

Comment alignment.

Comment alignment.

DEN-14763 updated the heat disinfect active cool per the requirements

    • -24
    • +38
    ./App/Modes/ModeHeatDisinfectActiveCool.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DIAL-243-integrated-volume-is-not-working' into develop

DIAL-243: Fixed header.

DIAL-243: fixed integrated volume data type from u32 to f32

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DIAL-222-sys-request' into develop

DIAL-222: fixed heaters override reset.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

DEN-14763 addressed the code review comments and added inlet water conditions to the heat disinfect active cool

    • -0
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -0
    • +1
    ./App/Controllers/TemperatureSensors.c
    • -43
    • +210
    ./App/Modes/ModeHeatDisinfectActiveCool.c