Activity dgfirmware/firmware

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

8:43 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Missing comment?

8:42 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

8:36 am

Sean Nash

More
Re: DG-DEN-14763-1
commented on review

Why lower case when others are uppercase?

2:45 pm

Dara Navaei

More
40e269f
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14763-1

DEN-14763, DEN-14960 added an event to report the reservoir base weight and filled volume at the end of the fill mode.

- -0
- +1
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c

2:43 pm

Dara Navaei

More
5fae4f2
changed 3 files
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 143 more DG-DEN-14763-1

DEN-14763 addressed the code review comments'

- -1
- +1
./.ccsproject
- History
- Source
- Diff
./.ccsproject
- -47
- +47
./.cproject
- History
- Source
- Diff
./.cproject
- -1
- +1
./App/Modes/ModeHeatDisinfectActiveCool.c
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfectActiveCool.c

2:41 pm

Dara Navaei

More
Re: DG-DEN-14763-1
replied to Sean Nash

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this ch...

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

2:42 pm

Dara Navaei

More
Re: DG-DEN-14763-1
replied to wbracken (deleted user)

Done

2:18 pm

Michael Garthwaite

More
91de942
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

DEN-14689: Fixed duplicate case

- -4
- +0
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c

2:11 pm

Michael Garthwaite

More
62ab9ef
changed 1 file
DEN-14316-chemical-disinfect, DEN-14646-fpga-alarm-properties-and-timing-3 and 145 more DG-DEN-14689-1

DEN-14689: sync'd out of message naming

- -1
- +1
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c

8:56 am

jtaylor (deleted user)

More
Re: DG-DEN-14763-1
commented on review

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS". This would be more specific since "USAGE" a...

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

10:08 pm