dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Mar 2023
8:42 pm

Dara Navaei

DEN-14763 merged staging

Options
    • -3
    • +3
    ./App/Modes/ModeStandby.c
    • -2
    • +2
    ./App/Modes/OperationModes.c
    • -22
    • +22
    ./App/Services/SystemComm.c
    • -4
    • +4
    ./App/Services/SystemCommMessages.c
8:31 pm

wbracken  (deleted user) and jtaylor  (deleted user)

4:34 pm

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:32 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:01 pm

Dara Navaei

DG-DEN-14788_DIAL-243_integrated_fill_incorrect
DG-DEN-14788_DIAL-243_integrated_fill_incorrect
11:58 am

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:45 am

Michael Garthwaite

Merge branch 'DIAL-243-integrated-volume-is-not-working' into DEN-14788-DIAL-243-integrated-volume-is-not-working

Options
    • -1
    • +1
    ./App/Services/SystemCommMessages.c
9:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:45 am

Dara Navaei

DEN-14763 addressed the code review comments

Options
    • -20
    • +29
    ./App/Modes/ModeHeatDisinfectActiveCool.c
9:34 am

Dara Navaei

Done. Thanks for catching it.

Done. Thanks for catching it.

9:33 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
9:33 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/FluidLeak.c
    • -2
    • +2
    ./App/Controllers/LoadCell.c
    • -2
    • +2
    ./App/Controllers/Valves.c
    • -2
    • +2
    ./App/Drivers/CPLD.c
    • -2
    • +2
    ./App/Modes/ModeStandby.c
    • -1
    • +1
    ./App/Modes/OperationModes.c
    • -2
    • +2
    ./App/Services/AlarmMgmt.c
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
9:30 am

Michael Garthwaite

9:28 am

Dara Navaei

Done

Done

9:28 am

Dara Navaei

Done

Done

9:18 am

Sean Nash

9:15 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:14 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:09 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:57 am

Sean Nash

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:43 am

Sean Nash

Missing comment?

Missing comment?

8:42 am

Sean Nash

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

8:36 am

Sean Nash

Why lower case when others are uppercase?

Why lower case when others are uppercase?