firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

    • -7
    • +15
    ./App/Controllers/ConductivitySensors.c
    • -1
    • +2
    ./App/Controllers/TemperatureSensors.c
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

DEN-15014 addressed the code review comment

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15014 addressed the code review comment

Check the diff of the last two commits.

Check the diff of the last two commits.

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

Done

Done

Remove TODO?

Remove TODO?

DEN-15014 updated the fill mode by removing the enable RO only mode variable from the init function to not be set to FALSE every time

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

DEN-15014 addressed the code review comments

    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
Done

Done

Changed it to TRUE/FALSE.

Changed it to TRUE/FALSE.

Updated the code.

Updated the code.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done