dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
8:59 am

James Walter Taylor <jtaylor@diality.com>

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

Options
    • -9
    • +7
    ./App/Services/SystemComm.c
8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

8:36 am

jtaylor  (deleted user)

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

8:35 am

jtaylor  (deleted user)

Done

Done

8:22 am

jtaylor  (deleted user)

Reverted.

Reverted.

Thursday 30 Mar 2023
9:20 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table changes

Options
    • -1
    • +0
    ./App/Controllers/Heaters.c
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -15
    • +28
    ./App/Modes/ModeFill.c
    • -1
    • +1
    ./App/Modes/ModeFlush.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfect.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfectActiveCool.c
    • -3
    • +45
    ./App/Modes/ModeStandby.c
9:18 pm

Sean Nash

DEN-14999: Small fix to DG WD POST.

Options
    • -0
    • +5
    ./App/Services/WatchdogMgmt.c
8:18 pm

Dara Navaei

DEN-14999 updated the code based on the alarms table update

Options
    • -2
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -12
    • +0
    ./App/Controllers/Heaters.c
    • -2
    • +1
    ./App/Controllers/Pressures.c
    • -2
    • +1
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
    • -1
    • +6
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +6
    ./App/Modes/ModeFlush.c
    • -2
    • +6
    ./App/Modes/ModeHeatDisinfect.c
    • -2
    • +6
    ./App/Modes/ModeHeatDisinfectActiveCool.c
7:05 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

7:04 pm

Dara Navaei

Merged DEN-14999

Options
    • -5
    • +28
    ./App/Controllers/ConductivitySensors.c
    • -14
    • +110
    ./App/Modes/ModeFill.c
    • -1
    • +3
    ./App/Modes/ModeInitPOST.c
    • -1
    • +5
    ./App/Services/SystemComm.c
    • -9
    • +113
    ./App/Services/SystemCommMessages.c
    • -1
    • +14
    ./App/Services/SystemCommMessages.h
6:58 pm

Sean Nash

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

6:57 pm

Sean Nash

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

6:34 pm

Dara Navaei

DEN-14999 fixed the pressures self test

Options
    • -0
    • +1
    ./App/Controllers/Pressures.c
5:56 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

Options
    • -7
    • +20
    ./App/Services/SystemComm.c
5:11 pm

Sean Nash

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

Options
    • -5
    • +5
    ./App/Services/SystemCommMessages.c
5:11 pm

Sean Nash

Fixed handling of HD cmd to change DG reservoir valve config.

Options
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
5:10 pm

Dara Navaei

DEN-14999, DEN-15030 updated the start DG command function

Options
    • -5
    • +5
    ./App/Services/SystemCommMessages.c
5:06 pm

Sean Nash

DEN-14999: Updated 24V range alarms.

Options
    • -9
    • +17
    ./App/Controllers/Voltages.c
    • -1
    • +1
    ./App/Controllers/Voltages.h
2:37 pm

Dara Navaei

DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

Options
    • -6
    • +47
    ./App/Modes/ModeFill.c
    • -0
    • +2
    ./App/Modes/ModeFill.h
    • -1
    • +1
    ./App/Modes/ModeStandby.c
    • -0
    • +18
    ./App/Services/Reservoirs.c
    • -0
    • +1
    ./App/Services/Reservoirs.h
    • -5
    • +7
    ./App/Services/SystemCommMessages.c
2:36 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Changes per code review

Options
    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -3
    • +3
    ./App/Controllers/Valves.c
2:26 pm

Sean Nash

No need to increase this one.

No need to increase this one.

1:42 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Options
    • -4
    • +26
    ./App/Controllers/ConductivitySensors.c
1:35 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-14646 Update per code review

Options
    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
11:35 am

Dara Navaei

DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

Options
    • -1
    • +2
    ./App/Controllers/ConductivitySensors.c
    • -0
    • +1
    ./App/Services/Reservoirs.c
11:35 am

Sean Nash

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

10:01 am

Dara Navaei

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
8:46 am

Michael Garthwaite

DIAL-222: removed heater check for reset override command.

Options
    • -4
    • +1
    ./App/Controllers/Heaters.c
8:19 am

James Walter Taylor <jtaylor@diality.com>

DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Added a space.

Options
    • -1
    • +1
    ./App/Services/SystemComm.c
Wednesday 29 Mar 2023
11:25 pm

Sean Nash

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).

Options
    • -38
    • +1
    ./App/Controllers/Pressures.c
    • -36
    • +1
    ./App/Controllers/TemperatureSensors.c