firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

Done

Done

Reverted.

Reverted.

DEN-14999 updated the code based on the alarms table changes

    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -1
    • +1
    ./App/Modes/ModeHeatDisinfectActiveCool.c
DEN-14999: Small fix to DG WD POST.

DEN-14999 updated the code based on the alarms table update

    • -2
    • +1
    ./App/Controllers/ConductivitySensors.c
    • -2
    • +1
    ./App/Controllers/TemperatureSensors.c
    • -1
    • +6
    ./App/Modes/ModeChemicalDisinfectFlush.c
    • -2
    • +6
    ./App/Modes/ModeHeatDisinfectActiveCool.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Merged DEN-14999

    • -5
    • +28
    ./App/Controllers/ConductivitySensors.c
    • -9
    • +113
    ./App/Services/SystemCommMessages.c
    • -1
    • +14
    ./App/Services/SystemCommMessages.h
I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

DEN-14999 fixed the pressures self test

DEN-15016-system-faults-during-treatment-then-returns-to-the-standby-screen

Updates to hold off processing retries until after INIT, and after communication with HD started.

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/dg/dgfirmware into DEN-14999-alarm-table-updates

Fixed handling of HD cmd to change DG reservoir valve config.

DEN-14999, DEN-15030 updated the start DG command function

DEN-14999: Updated 24V range alarms.

DEN-14999, DEN-15031 added code to receive and support different types of acid and bicarb in the treatment

DEN-14646 Changes per code review

    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
No need to increase this one.

No need to increase this one.

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

    • -4
    • +26
    ./App/Controllers/ConductivitySensors.c
DEN-14646 Update per code review

    • -1
    • +1
    ./App/Controllers/ConductivitySensors.c
DEN-14999 merged the remote changes and updated the fill mode with the acid conductivity values

    • -1
    • +2
    ./App/Controllers/ConductivitySensors.c
I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
DIAL-222: removed heater check for reset override command.

DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Added a space.

DEN-14999: Removed alarm 203 (dg POST adc rail check for pressure sensors). Removed alarm 116 (dg temperature sensors adc rail check). Removed adc temperature sensors from alarm 115 (dg temperature sensors range check).

    • -36
    • +1
    ./App/Controllers/TemperatureSensors.c