dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
9:14 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

9:03 am

Sean Nash

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode. I imagine new system would get installed by service - would need some kind of priming do...

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

8:54 am

Michael Garthwaite

will these alarms trigger with open air? Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If...

will these alarms trigger with open air?

Ex: if a user has a device shipped to them, will they be greeted with conductivity alarms on first power up before any water has ran through the system? If so, how will they be able to fix it?

8:36 am

jtaylor  (deleted user)

Done. Does HD communicating always account for UI traffic as well?

Done. Does HD communicating always account for UI traffic as well?

8:35 am

jtaylor  (deleted user)

Done

Done

8:22 am

jtaylor  (deleted user)

Reverted.

Reverted.

Thursday 30 Mar 2023
7:04 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

6:58 pm

Sean Nash

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

6:57 pm

Sean Nash

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

2:26 pm

Sean Nash

No need to increase this one.

No need to increase this one.

11:35 am

Sean Nash

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

10:01 am

Dara Navaei

DG-DEN-14788_Dial 222 Sys Request
DG-DEN-14788_Dial 222 Sys Request
Wednesday 29 Mar 2023
4:01 pm

Dara Navaei

DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
DG-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen
2:52 pm

Sean Nash

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

11:25 am

wbracken  (deleted user)

Corrected

Corrected

8:37 am

Dara Navaei

8:08 am

Sean Nash

Tuesday 28 Mar 2023
5:19 pm

Dara Navaei

5:08 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:07 pm

Dara Navaei

Done

Done

5:03 pm

Sean Nash

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

5:00 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:59 pm

Dara Navaei

Check the diff of the last two commits.

Check the diff of the last two commits.

4:58 pm

Sean Nash

What I meant is that we don't need to send anything other than response.

What I meant is that we don't need to send anything other than response.

4:58 pm

Dara Navaei

Done

Done

4:57 pm

Sean Nash

Remove TODO?

Remove TODO?

4:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:55 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.