firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15199 addressed the code review comments

Done.

Done.

Done.

Done.

Done

Done

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Correct. This common code in between the two stacks. I can separate them using #ifndef.

Done

Done

Done

Done

I removed the memset macro.

I removed the memset macro.

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

Done

Done

Done

Done

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

Note in brief that function will return FALSE if Dialin not logged in.

Note in brief that function will return FALSE if Dialin not logged in.

testConfig is an input, not an output.

testConfig is an input, not an output.

Change "release" to "test".

Change "release" to "test".

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Add check for Dialin logged in.

Add check for Dialin logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Yes, s/w fault (for invalid config). Ignore command for not logged in.

Also, Dialin must be logged in to accept a test config command.

Also, Dialin must be logged in to accept a test config command.

memset wants a byte. Just say 0 instead of using KEY #define. Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

memset wants a byte. Just say 0 instead of using KEY #define.
Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

Add blank line between banner and #define.

Add blank line between banner and #define.

Add blank line between banner and #define.

Add blank line between banner and #define.

Are DG and HD sharing this enum?

Are DG and HD sharing this enum?

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ). Make this change everywhere getTestConfigStatus function is used.

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ).
Make this change everywhere getTestConfigStatus function is used.

DEN-15199 renamed the test configuration code

    • -7
    • +14
    ./App/Services/SystemCommMessages.c
DEN-15199 worked on the release software configuration

    • -0
    • +26
    ./App/Services/SystemCommMessages.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo