dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 14 May 2023
7:44 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15336 Updates per code review comments.

Options
    • -2
    • +0
    ./App/Services/FPGA.c
7:35 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

7:34 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

7:33 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.

5:23 pm

Sean Nash

Remove blank line.

Remove blank line.

4:45 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:45 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:43 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -2
    • +2
    ./App/Controllers/LoadCell.c
    • -2
    • +2
    ./App/Modes/ModeFill.c
    • -2
    • +0
    ./App/Modes/ModeGenIdle.c
    • -1
    • +1
    ./App/Modes/ModeGenIdle.h
    • -2
    • +1
    ./App/Services/Reservoirs.h
4:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:42 pm

Dara Navaei

Done

Done

4:42 pm

Dara Navaei

Done

Done

4:42 pm

Dara Navaei

Done

Done

4:40 pm

Dara Navaei

Yes eventually!

Yes eventually!

4:40 pm

Dara Navaei

Done

Done

4:39 pm

Dara Navaei

Done

Done

4:39 pm

Sean Nash

Remove blank line?

Remove blank line?

4:39 pm

Dara Navaei

Done

Done

4:39 pm

Sean Nash

Remove comment?

Remove comment?

4:37 pm

Dara Navaei

Fixed it.

Fixed it.

4:33 pm

Dara Navaei

DEN-15274 addressed the code review comments

Options
    • -1
    • +1
    ./App/Modes/ModeFill.c
    • -4
    • +7
    ./App/Modes/ModeGenIdle.c
    • -6
    • +2
    ./App/Services/Reservoirs.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
4:31 pm

Sean Nash

Disagree with comment change.

Disagree with comment change.

3:48 pm

Sean Nash

Let's put test config conditions last when mixing with normal conditions (both ifs).

Let's put test config conditions last when mixing with normal conditions (both ifs).

3:38 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15336 Add FE/OE to FPGA communications.

Options
    • -7
    • +39
    ./App/Services/FPGA.c
    • -4
    • +52
    ./App/Services/Interrupts.c
    • -0
    • +2
    ./App/Services/Interrupts.h
12:57 pm

Dara Navaei

Done

Done

12:55 pm

Dara Navaei

Done

Done