firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We're always ready? Why does UI need to ask if DG is ready if always ready? Replace "1" with "TRUE".

We're always ready? Why does UI need to ask if DG is ready if always ready?
Replace "1" with "TRUE".

Should this be a s/w fault?

Should this be a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

Cycle is mis-spelled.

Cycle is mis-spelled.

The check against nearly zero is pointless since we're looking for > 10 mL/min now. Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking agai...

The check against nearly zero is pointless since we're looking for > 10 mL/min now.
Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking against low speed threshold.

DEN-15522 fixed the heat disinfect active cool fill timeout not triggering. DEN-14805 fixed chemical disinfect reservoir leak alarm

    • -4
    • +13
    ./App/Modes/ModeChemicalDisinfect.c
    • -6
    • +1
    ./App/Modes/ModeHeatDisinfectActiveCool.c
Not really "off". Should be applied when going slowly (<10 mL/min).

Not really "off". Should be applied when going slowly (<10 mL/min).

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

    • -16
    • +20
    ./App/Controllers/ConcentratePumps.c
    • -8
    • +43
    ./App/Services/SystemCommMessages.c
Update function header.

Update function header.

Update function header.

Update function header.

Update function header.

Update function header.

Update function header

Update function header

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-15509 changed the reservoir threshold from 1700 to 1850 mL. DEN-15192 changed the concentrate pump low speed threshold.

    • -10
    • +14
    ./App/Controllers/ConcentratePumps.c
-DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message ID to 0x89 from UI to send the DG service record -DEN-15192 changed the concentrate pumps low speed check threshold -DEN-15509 changed the reservoir full threshold from 1700 mL to 1850 mL.

    • -8
    • +43
    ./App/Services/SystemCommMessages.c
DEN-14004 added another message to receive and send DG service record upon request from HD. The format of the payload is different from the format that is sent to UI

    • -8
    • +43
    ./App/Services/SystemCommMessages.c
Done

Done

Done

Done

DEN-15367, DEN-15389, DEN-15511, DEN-15443 added code in the mode fill to check for the conductivity of the values in the produce state and have a timeout. Removed the acid check at the end of the mode fill

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Merged DEN-15367

    • -5
    • +28
    ./App/Services/SystemCommMessages.c
DEN-15367, DEN-15404 worked on RO permeate sample mode

DEN-15367, DEN-15404 work in progress. Updated the RO permeate sample mode code to be able to receive and send ready command to HD for further dispensing or canceling the run

    • -54
    • +44
    ./App/Modes/ModeROPermeateSample.c
    • -5
    • +28
    ./App/Services/SystemCommMessages.c
Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

DEN-15367 added test configuration to be able to run chemical disinfect without PAA acid