dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 12 Jun 2023
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Controllers/DrainPump.c
5:23 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
2:47 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:44 pm

Sean Nash

We're always ready? Why does UI need to ask if DG is ready if always ready? Replace "1" with "TRUE".

We're always ready? Why does UI need to ask if DG is ready if always ready?
Replace "1" with "TRUE".

2:39 pm

Sean Nash

Should this be a s/w fault?

Should this be a s/w fault?

2:39 pm

Sean Nash

Should default be separate from DISPENSING? And should default have a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

1:59 pm

Sean Nash

Cycle is mis-spelled.

Cycle is mis-spelled.

1:55 pm

Sean Nash

The check against nearly zero is pointless since we're looking for > 10 mL/min now. Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking agai...

The check against nearly zero is pointless since we're looking for > 10 mL/min now.
Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking against low speed threshold.

1:55 pm

Dara Navaei

DEN-15522 fixed the heat disinfect active cool fill timeout not triggering. DEN-14805 fixed chemical disinfect reservoir leak alarm

Options
    • -4
    • +13
    ./App/Modes/ModeChemicalDisinfect.c
    • -6
    • +1
    ./App/Modes/ModeHeatDisinfectActiveCool.c
1:52 pm

Sean Nash

Not really "off". Should be applied when going slowly (<10 mL/min).

Not really "off". Should be applied when going slowly (<10 mL/min).

10:49 am

dcox  (deleted user)

9:10 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
8:44 am

Dara Navaei

Merge branch 'DEN-15367-hd_dg_test_configuration_setup' into develop

Options
    • -16
    • +20
    ./App/Controllers/ConcentratePumps.c
    • -237
    • +219
    ./App/Modes/ModeFill.c
    • -2
    • +6
    ./App/Services/SystemComm.c
    • -8
    • +43
    ./App/Services/SystemCommMessages.c
    • -1
    • +4
    ./App/Services/SystemCommMessages.h
1:07 am

wbracken  (deleted user)

Update function header.

Update function header.

1:03 am

wbracken  (deleted user)

Update function header.

Update function header.

1:03 am

wbracken  (deleted user)

Update function header.

Update function header.

1:02 am

wbracken  (deleted user)

Update function header

Update function header

12:55 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Sunday 11 Jun 2023
8:28 pm

Dara Navaei

DEN-15367 changed the RO permeate sample cancel water path. DEN-14004 changed the request message from UI to 0x89. DEN-15509 changed the reservoir threshold from 1700 to 1850 mL. DEN-15192 changed the concentrate pump low speed threshold.

Options
    • -10
    • +14
    ./App/Controllers/ConcentratePumps.c
    • -1
    • +1
    ./App/Modes/ModeChemicalDisinfect.c
    • -5
    • +10
    ./App/Modes/ModeROPermeateSample.c
    • -1
    • +1
    ./App/Services/SystemComm.c
2:24 pm

Dara Navaei

-DEN-15367 fixed the transition to cancel water path in RO permeate sample mode -DEN-14004 changed the request message ID to 0x89 from UI to send the DG service record -DEN-15192 changed the concentrate pumps low speed check threshold -DEN-15509 changed the reservoir full threshold from 1700 mL to 1850 mL.

Options
    • -2
    • +2
    ./App/Modes/ModeFill.c
    • -1
    • +5
    ./App/Services/SystemComm.c
    • -8
    • +43
    ./App/Services/SystemCommMessages.c
    • -1
    • +4
    ./App/Services/SystemCommMessages.h
2:24 pm

Dara Navaei

DEN-14004 added another message to receive and send DG service record upon request from HD. The format of the payload is different from the format that is sent to UI

Options
    • -2
    • +2
    ./App/Modes/ModeFill.c
    • -1
    • +5
    ./App/Services/SystemComm.c
    • -8
    • +43
    ./App/Services/SystemCommMessages.c
    • -1
    • +4
    ./App/Services/SystemCommMessages.h
12:43 pm

Dara Navaei

Done

Done

12:39 pm

Dara Navaei

Done

Done

Saturday 10 Jun 2023
6:04 pm

Dara Navaei

DEN-15367, DEN-15389, DEN-15511, DEN-15443 added code in the mode fill to check for the conductivity of the values in the produce state and have a timeout. Removed the acid check at the end of the mode fill

Options
    • -7
    • +7
    ./App/Controllers/ConcentratePumps.c
    • -237
    • +219
    ./App/Modes/ModeFill.c
Friday 09 Jun 2023
6:02 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
5:44 pm

Dara Navaei

Merged DEN-15367

Options
    • -2
    • +1
    ./App/Controllers/ConcentratePumps.c
    • -1
    • +0
    ./App/Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    ./App/Services/SystemComm.c
    • -5
    • +28
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
5:42 pm

Dara Navaei

DEN-15367, DEN-15404 worked on RO permeate sample mode

Options
    • -5
    • +5
    ./App/Controllers/ROPump.c
    • -7
    • +12
    ./App/Modes/ModeROPermeateSample.c
    • -1
    • +2
    ./App/Modes/ModeROPermeateSample.h
    • -1
    • +1
    ./App/Services/SystemCommMessages.c
9:00 am

Dara Navaei

DEN-15367, DEN-15404 work in progress. Updated the RO permeate sample mode code to be able to receive and send ready command to HD for further dispensing or canceling the run

Options
    • -1
    • +1
    ./App/Controllers/ConcentratePumps.c
    • -54
    • +44
    ./App/Modes/ModeROPermeateSample.c
    • -1
    • +0
    ./App/Services/AlarmMgmtSWFaults.h
    • -1
    • +1
    ./App/Services/SystemComm.c
    • -5
    • +28
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
Tuesday 06 Jun 2023
2:50 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
2:41 pm

Dara Navaei

DEN-15367 added test configuration to be able to run chemical disinfect without PAA acid

Options
    • -1
    • +2
    ./App/Modes/ModeChemicalDisinfect.c