Activity dgfirmware/firmware

1:33 pm

Dara Navaei

More
e7456f2
changed 3 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more DG-DEN-16125-1

DEN-15125 addressed the compiler warnings

- -8
- +3
./App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfectFlush.c
- -19
- +0
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c
- -3
- +0
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

1:16 pm

Michael Garthwaite

More
46d5a77
changed 3 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: fixed warnings

- -0
- +2
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c
- -0
- +1
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -0
- +3
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h

1:10 pm

Michael Garthwaite

More
3949d0c
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: fixed compiler error.

- -1
- +1
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c

1:09 pm

Michael Garthwaite

More
f64f930
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-UCOMMITS-39

DEN-15634: added drain mode msg_id to publish.

- -1
- +1
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c

12:42 pm

Dara Navaei

More
DG-DEN-16125-1
started review

DG-DEN-16125_DG Chem Flush DG Does Not Transition From Flush R1 TO R2 Drain R2 TO Cancel Water

12:41 pm

Dara Navaei

More
14c3c2a
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more DG-DEN-16125-1

DEN-16125 removed the code in chemical flush that was checking the drain timeout in some of the states

- -34
- +0
./App/Modes/ModeChemicalDisinfectFlush.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfectFlush.c

10:36 am

Dara Navaei

More
2f3efd7
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

10:32 am

Sean Nash

More
ac8b318
changed 2 files
develop

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

- -1
- +2
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -3
- +0
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

10:30 am

Sean Nash

More
f3929ca
changed 2 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more DG-DENBUG-59-1

DENBUG-59: Distinguish between alarms originating outside.

- -3
- +4
./App/Services/AlarmMgmt.c
- History
- Source
- Diff
./App/Services/AlarmMgmt.c
- -1
- +1
./App/Services/AlarmMgmt.h
- History
- Source
- Diff
./App/Services/AlarmMgmt.h

4:30 pm

Sean Nash

More
821d160
changed 3 files
DEN-14706-can-messge-not-acked-fix, DEN-15614-new-updated-disinfect-actuators-requirement-issues-list-4 and 74 more DG-DENBUG-59-1

DENBUG-59: Added alarm properties to prevent alarm trigger while in rinseback or post-tx states.

- -6
- +16
./App/Services/AlarmMgmt.c
- History
- Source
- Diff
./App/Services/AlarmMgmt.c
- -1
- +2
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -3
- +0
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

2:14 pm

Dara Navaei

More
DG-DENBUG-59-1
started review

DG-DENBUG-59_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow

1:38 pm

Dara Navaei

More
cf79840
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

1:38 pm

Dara Navaei

More
5fc30ce
changed 4 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 86 more DG-DEN-15634-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./App/Controllers/FlowSensors.c
- History
- Source
- Diff
./App/Controllers/FlowSensors.c
- -2
- +2
./App/Controllers/FlowSensors.h
- History
- Source
- Diff
./App/Controllers/FlowSensors.h
- -1
- +1
./App/Modes/OperationModes.c
- History
- Source
- Diff
./App/Modes/OperationModes.c
- -1
- +1
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

1:37 pm

Michael Garthwaite

More
8a9d78a
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: code review comments

- -1
- +2
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c

1:35 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to wbracken (deleted user)

Fixed. Thanks!

1:34 pm

Michael Garthwaite

More
DG-DIAL-273-1
Closed

1:26 pm

wbracken (deleted user) and Sean Nash

More
DG-DIAL-273-1
finished reviewing

1:26 pm

wbracken (deleted user)

RESOLVED IN CODE WALKTHROUGH

1:18 pm

wbracken (deleted user)

More
Re: DG-DEN-15634-1
commented on review

Add dataPublishCounter

1:17 pm

Michael Garthwaite

More
Re: DG-DIAL-273-1
replied to wbracken (deleted user)

Fixed. Thanks!

1:16 pm

wbracken (deleted user)

More
Re: DG-DIAL-273-1
commented on review

Update @param with raw

1:16 pm

Michael Garthwaite

More
65e9ace
changed 4 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: implemented drain mode broadcast overrides.

- -0
- +52
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c
- -0
- +3
./App/Modes/ModeDrain.h
- History
- Source
- Diff
./App/Modes/ModeDrain.h
- -0
- +4
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -0
- +32
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

1:15 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to Sean Nash

Missed calling it in the exec function. Good catch. fixed.

1:14 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to Sean Nash

Fixed. Thanks!

1:14 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to Sean Nash

Fixed. Thanks!

1:14 pm

Michael Garthwaite

More
Re: DG-DEN-15634-1
replied to Sean Nash

Fixed. Thanks!

12:54 pm

Michael Garthwaite

More
2b66814
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 85 more DG-DEN-15634-1

DEN-15634: fixed drain mode publish not being called. code review comments.

- -0
- +3
./App/Modes/ModeDrain.c
- History
- Source
- Diff
./App/Modes/ModeDrain.c
- -0
- +2
./App/Modes/ModeDrain.h
- History
- Source
- Diff
./App/Modes/ModeDrain.h

12:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

12:00 pm

Michael Garthwaite

More
Re: DG-DIAL-273-1
replied to Sean Nash

Fixed. Thanks!

11:31 am

Michael Garthwaite

More
bb87f31
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 87 more DG-DIAL-273-1

code review comments.

- -1
- +0
./App/Modes/OperationModes.c
- History
- Source
- Diff
./App/Modes/OperationModes.c

firmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

wbracken (deleted user) and Sean Nash

wbracken (deleted user)

wbracken (deleted user)

Michael Garthwaite

wbracken (deleted user)

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Sean Nash

Michael Garthwaite

Michael Garthwaite