dgfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 24 Aug 2023
5:21 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
4:46 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
4:46 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Services/AlarmMgmt.c
    • -2
    • +2
    ./App/Services/AlarmMgmt.h
    • -2
    • +2
    ./App/Services/Reservoirs.c
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
3:42 pm

Dara Navaei

3:41 pm

Dara Navaei

3:41 pm

Dara Navaei

2:09 pm

wbracken  (deleted user) and jtaylor  (deleted user)

2:02 pm

jtaylor  (deleted user)

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely re...

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.

12:58 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
12:58 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./App/Controllers/Heaters.c
    • -2
    • +2
    ./App/Controllers/Voltages.c
    • -1
    • +1
    ./App/Controllers/Voltages.h
    • -1
    • +1
    ./App/Drivers/SafetyShutdown.c
    • -1
    • +1
    ./App/Services/WatchdogMgmt.c
12:57 pm

Dara Navaei

12:46 pm

wbracken  (deleted user) and Sean Nash

12:37 pm

wbracken  (deleted user) , Sean Nash and jtaylor  (deleted user)

11:27 am

Sean Nash

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature? FYI - getHDOperationMode()...

We don't trigger inlet water conductivity alarm in post-treatment mode? Any reason why we're not just saying "== MODE_POST"? What about inlet water pressure/temperature?

FYI - getHDOperationMode() was not working - HD op mode handler was mishandling message - fixed in my DENBUG-59 branch, but not yet in staging.

11:04 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
10:55 am

Sean Nash

Merged staging to DENBUG-59.

Options
    • -23
    • +88
    ./App/Services/Reservoirs.c
    • -4
    • +69
    ./App/Services/SystemComm.c
    • -7
    • +169
    ./App/Services/SystemCommMessages.c
10:20 am

Dara Navaei

DEN-16091 changed the trimmer heater's persistent alarm from 10 seconds to 12 seconds

Options
    • -3
    • +4
    ./App/Controllers/Heaters.c
9:58 am

Dara Navaei

DG-DEN-16308_Srsdg 53 Not Met
DG-DEN-16308_Srsdg 53 Not Met
9:57 am

Dara Navaei

DG-DIAL-276_DG Event Event ID 15 Prints Duplicate Events With Different State Time
DG-DIAL-276_DG Event Event ID 15 Prints Duplicate Events With Different State Time
9:50 am

Dara Navaei

DEN-16308 updated the DG watchdog and safety shutdown POSTs

Options
    • -0
    • +16
    ./App/Controllers/Voltages.c
    • -0
    • +1
    ./App/Controllers/Voltages.h
    • -4
    • +4
    ./App/Drivers/SafetyShutdown.c
    • -7
    • +7
    ./App/Services/WatchdogMgmt.c
9:48 am

Michael Garthwaite

DIAL-276: fixed op status event duplicating on op mode change only.

Options
    • -2
    • +1
    ./App/Modes/OperationModes.c
Wednesday 23 Aug 2023
2:14 pm

Sean Nash

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for ala...

Checking for alarm in this function means we will check when in control to flow or control to pressure states. Also checked only once per control interval which is maybe ok, but not typical for alarm checks.
We do control to flow for treatment modes. Control to pressure is used in some cleaning modes. Not sure we want this alarm enforced in cleaning modes.

2:09 pm

Sean Nash

Remove blank line.

Remove blank line.

2:09 pm

Sean Nash

Put declarations at top of function. Use our BOOL type. Put ternary in ().

Put declarations at top of function. Use our BOOL type. Put ternary in ().

2:07 pm

Sean Nash

No point to having non-zero clear persistence - it's a fault.

No point to having non-zero clear persistence - it's a fault.

1:14 pm

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
1:10 pm

Sean Nash

Merge branch 'DENBUG-59-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

Options
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
1:09 pm

Sean Nash

DENBUG-59: Fixed DG handling of HD op mode broadcast messages.

Options
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
11:56 am

Dara Navaei

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/DGCommon.h
11:55 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-16280-stuck-in-post-treatment-when-inlet-water-alarm-appears' into develop

Options
    • -1
    • +5
    ./App/Controllers/ConductivitySensors.c
    • -3
    • +2
    ./App/Modes/ModeFill.c
    • -23
    • +88
    ./App/Services/Reservoirs.c
    • -3
    • +56
    ./App/Services/SystemComm.c
    • -1
    • +65
    ./App/Services/SystemCommMessages.c
    • -1
    • +7
    ./App/Services/SystemCommMessages.h