firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This if doesn't appear to be doing anything. Remove.

This if doesn't appear to be doing anything. Remove.

This should be inverse of what you had before. I think this is too brief.

This should be inverse of what you had before. I think this is too brief.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Too many () after &&?

Too many () after &&?

Remove extra blank line.

Remove extra blank line.

Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
DG-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

Please remove the blank line.

Please remove the blank line.

DG-DEN-15791_DG Software Design Description
DG-DEN-15791_DG Software Design Description
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Please add _MS to be consistent with the reset of times which are all in milliseconds.

Please add _MS to be consistent with the reset of times which are all in milliseconds.

DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
DG-DIAL-281_Requesting Heat Disinfect Timer Overrides
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.