Activity dgfirmware/firmware

4:38 pm

Dara Navaei

More
b220330
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

4:38 pm

Dara Navaei

More
8ee0169
changed 3 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15791-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./App/Modes/ModeFill.c
- History
- Source
- Diff
./App/Modes/ModeFill.c
- -2
- +2
./App/Services/Reservoirs.c
- History
- Source
- Diff
./App/Services/Reservoirs.c
- -2
- +2
./App/Services/Reservoirs.h
- History
- Source
- Diff
./App/Services/Reservoirs.h

4:36 pm

Dara Navaei , Sean Nash and wbracken (deleted user)

More
DG-DEN-16314-1
finished reviewing

4:13 pm

Sean Nash

More
Re: DG-DEN-16314-1
replied to jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH.

3:55 pm

jtaylor (deleted user)

More
Re: DG-DEN-16314-1
replied to Sean Nash

Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.

3:32 pm

Dara Navaei

More
57a6c33
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

3:32 pm

Dara Navaei

More
becd984
changed 6 files
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./App/Controllers/Pressures.c
- History
- Source
- Diff
./App/Controllers/Pressures.c
- -2
- +2
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c
- -1
- +1
./App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfect.c
- -1
- +1
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c
- -2
- +2
./App/Modes/OperationModes.c
- History
- Source
- Diff
./App/Modes/OperationModes.c
- -2
- +2
./App/Modes/OperationModes.h
- History
- Source
- Diff
./App/Modes/OperationModes.h

3:31 pm

Dara Navaei

More
DG-DEN-15973-2
Closed

2:43 pm

jtaylor (deleted user) , wbracken (deleted user) and Sean Nash

More
DG-DEN-15973-2
finished reviewing

8:52 am

Dara Navaei

More
6e3d60b
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

8:50 am

Dara Navaei

More
3223b2c
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 updated the chemical disinfect

- -1
- +7
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c

6:06 pm

Dara Navaei

More
27fd909
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

6:04 pm

Dara Navaei

More
3835a00
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 updated chem disinfect

- -1
- +3
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c

5:45 pm

Dara Navaei

More
effee51
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

5:37 pm

Dara Navaei

More
e6ecfc3
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 updated chemical disinfect

- -1
- +1
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c

5:01 pm

Dara Navaei

More
efa2127
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-16432 fixed the heat disinfect temperature out of range trial count error

- -2
- +3
./App/Modes/ModeHeatDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeHeatDisinfect.c

4:23 pm

Sean Nash

More
Re: DG-DEN-16314-1
commented on review

You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?

4:05 pm

Dara Navaei

More
DG-DIAL-285-1
started review

DG-DIAL-285_Event Log 15 Missing Fill Prime Concentrate State

3:36 pm

Dara Navaei

More
5d0f80b
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

3:35 pm

Dara Navaei

More
719abb7
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 updated the chemical disinfect

- -2
- +3
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c

1:28 pm

Dara Navaei

More
e1d40cf
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

1:27 pm

Dara Navaei

More
0e4ac22
changed 3 files
develop

Merged DEN-15973

- -1
- +1
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -2
- +2
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -2
- +2
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h

1:26 pm

Dara Navaei

More
ddad43b
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 updated chemical disinfect

- -1
- +1
./App/Modes/ModeChemicalDisinfect.c
- History
- Source
- Diff
./App/Modes/ModeChemicalDisinfect.c

1:17 pm

Dara Navaei

More
df56922
changed 1 file
develop

Bamboo Commit: Updated DGCommon.h with build versions from Bamboo

- -1
- +1
./App/DGCommon.h
- History
- Source
- Diff
./App/DGCommon.h

10:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:28 am

Dara Navaei

More
Re: DG-DEN-15973-2
replied to Sean Nash

Done

10:27 am

Dara Navaei

More
c47dc63
changed 1 file
DEN-15791-dg-software-design-description, DEN-16204-ui-fw-pure-water-mode-turning-intermittently-staging and 61 more DG-DEN-15973-2

DEN-15973 addressed the code review comments

- -4
- +4
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

9:53 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

9:52 am

Sean Nash

More
Re: DG-DEN-15973-2
replied to Sean Nash

Dara, I mean inline comments for the magic numbers. Explain what 40 and 32 mean and why you're using those values.

firmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Dara Navaei

Dara Navaei , Sean Nash and wbracken (deleted user)

Sean Nash

jtaylor (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

jtaylor (deleted user) , wbracken (deleted user) and Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Sean Nash

Dara Navaei

Dara Navaei

Sean Nash

Sean Nash

Sean Nash