Activity dgfirmware/firmware

4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

1:05 pm

Dara Navaei and jtaylor (deleted user)

More
DG-DEN-15791-1
finished reviewing

11:16 am

jtaylor (deleted user)

More
Re: DG-DEN-16446-1
replied to jtaylor (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

8:56 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to jtaylor (deleted user)

Done

8:33 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to Sean Nash

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

More
Re: DG-DEN-16446-1
replied to jtaylor (deleted user)

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

4:40 pm

jtaylor (deleted user)

More
Re: DG-DEN-16446-1
commented on review

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

More
Re: DG-DEN-16446-1
commented on review

What's left? When would this code ever become reachable?

8:30 am

jtaylor (deleted user)

More
Re: DG-DEN-16446-1
commented on review

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

1:30 pm