Activity dialin/

7:21 pm

Behrouz NematiPour

More
0f18251
changed 2 files
master, DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up and 200 more DIALIN-BUG-S63-1 DIALIN-UI-S63-1

DIALIN-BUG-S63: DIALIN-BUG-S63-1

- Addressed code review comments.

- -25
- +20
/dialin/ui/hd_simulator.py
- History
- Source
- Diff
/dialin/ui/hd_simulator.py
- -1
- +1
/dialin/ui/unittests.py
- History
- Source
- Diff
/dialin/ui/unittests.py

4:54 pm

Behrouz NematiPour

That is correct and I have something in mind to improve the code. But I believe this is more related to Dialin bugs: 1 - First one which we talked about that Dialin creates all the objects even it...

That is correct and I have something in mind to improve the code.

But I believe this is more related to Dialin bugs:
1 - First one which we talked about that Dialin creates all the objects even it is not being used in the _init_.py files which cause different use-cases of the API to be not compatible together and can't be used together.
2 - the other issue is that the Dialin as an API should by nature be a passive code and just have the capabilities to be extended those observers have to be removed from Dialin.

For now, I'll put a workaround for this, and later we should discuss the better implementation of the Dialin API.

3:32 pm

Behrouz NematiPour

Separate functions have been created to keep the string representations clearer. It is not safe to use something like "b" or "B" since anyone can even but something like "hello" which probably does...

Separate functions have been created to keep the string representations clearer.
It is not safe to use something like "b" or "B" since anyone can even but something like "hello" which probably doesn't mean anything and is an error.
to overcome this flow the different functions implemented here have to be used.

Also since the intention of the function here is clear the length has been calculated regarding the type conversion in each function.
which helps have a lot of clearer code.
Please refer to the usage in:
d9b45e5b52db2540a79cbc8795d82dda4fd3984b on dialin develop branch.

the code has changed from:

        major = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MAJOR:self.END_POS_MAJOR]))
        minor = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MINOR:self.END_POS_MINOR]))
        micro = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MICRO:self.END_POS_MICRO]))
        build = struct.unpack('H', bytearray(
            message['message'][self.START_POS_BUILD:self.END_POS_BUILD]))
        compatibility = struct.unpack('H', bytearray(
            message['message'][self.START_POS_COMPAT:self.END_POS_COMPAT]))

which was so error-prone to the following code:

        major, index = bytearray_to_byte(payload, index, False)
        minor, index = bytearray_to_byte(payload, index, False)
        micro, index = bytearray_to_byte(payload, index, False)
        build, index = bytearray_to_short(payload, index, False)
        compt, index = bytearray_to_integer(payload, index, False)

3:17 pm

Behrouz NematiPour

I don't think that is a good idea to get a hug class like logging to be involved in here. It would be better to use the logging in the class which using these very basic functions.

I don't think that is a good idea to get a hug class like logging to be involved in here.
It would be better to use the logging in the class which using these very basic functions.

10:28 am

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)