1. DIALIN-UCOMMITS

DIALIN-UCOMMITS-16

Join Review Tools
closed on 03 Aug 23
Author
Moderator
Reviewers

DIALIN Staging Unreviewed Commits

Activity

DIALIN-UCOMMITS-16 0

Keyboard shortcuts  
    • Summarize the review outcomes (optional)
    Preview wiki syntax help
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    wbracken  (deleted user)
    		Author & Moderator 0m    
    Dara Navaei
    Reviewer completed
    		Reviewer - Complete 13m    
    Sean Nash
    Reviewer completed
    		Reviewer - Complete 4m    
    Behrouz NematiPour
    		Reviewer - 0% reviewed      
    Total   18m 0  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /.idea/dictionaries/fw.xml Deleted
    Open in IDE #permalink
    /.idea/inspectionProfiles/profiles_settings.xml Deleted
    Open in IDE #permalink
    /.idea/DenaliSerialMessenger.iml Deleted
    Open in IDE #permalink
    /.idea/misc.xml Deleted
    Open in IDE #permalink
    /.idea/modules.xml Deleted
    Open in IDE #permalink
    /.idea/vcs.xml Deleted
    Open in IDE #permalink
    /.idea/workspace.xml Deleted
    Open in IDE #permalink
    /Miscellaneous/DG_Firmware_Simulator.py Changed
    /__pycache__/DialityCoreSerialProtocol.cpython-36.pyc Deleted
    Open in IDE #permalink
    /dialin/common/alarm_defs.py Changed
    /dialin/common/dg_defs.py Changed
    /dialin/common/msg_defs.py Changed
    /dialin/common/msg_ids.py Changed
    Open in IDE #permalink
    /dialin/dg/cpld.py Changed
    /dialin/dg/fans.py Changed
    Open in IDE #permalink
    /dialin/dg/flush.py Changed
    /dialin/dg/heat_disinfect.py Changed
    /dialin/dg/temperatures.py Changed
    /dialin/hd/alarms.py Changed
    /dialin/hd/blood_flow.py Changed
    /dialin/hd/calibration_record.py Changed
    Open in IDE #permalink
    /dialin/hd/fans.py Changed
    Open in IDE #permalink
    /dialin/hd/hemodialysis_device.py Changed
    /dialin/hd/temperatures.py Changed
    /dialin/hd/treatment.py Changed
    /dialin/hd/ui_proxy.py Changed
    Open in IDE #permalink
    /dialin/ui/hd_simulator.py Changed
    /dialin/utils/nv_ops_utils.py Changed
    /dialin/version.py Changed
    /document/html/search/all_0.html Deleted
    Open in IDE #permalink
    /document/html/search/all_0.js Deleted
    Open in IDE #permalink
    /document/html/search/all_1.html Deleted
    Open in IDE #permalink
    /document/html/search/all_1.js Deleted
    Open in IDE #permalink
    /document/html/search/all_2.html Deleted
    Open in IDE #permalink
    /document/html/search/all_2.js Deleted
    Open in IDE #permalink
    /document/html/search/all_3.html Deleted
    Open in IDE #permalink
    /document/html/search/all_3.js Deleted
    Open in IDE #permalink
    /document/html/search/all_4.html Deleted
    Open in IDE #permalink
    /document/html/search/all_4.js Deleted
    Open in IDE #permalink
    /document/html/search/all_5.html Deleted
    Open in IDE #permalink
    /document/html/search/all_5.js Deleted
    Open in IDE #permalink
    /document/html/search/all_6.html Deleted
    Open in IDE #permalink
    /document/html/search/all_6.js Deleted
    Open in IDE #permalink
    /document/html/search/all_7.html Deleted
    Open in IDE #permalink
    /document/html/search/all_7.js Deleted
    Open in IDE #permalink
    /document/html/search/all_8.html Deleted
    Open in IDE #permalink
    /document/html/search/all_8.js Deleted
    Open in IDE #permalink
    /document/html/search/all_9.html Deleted
    Open in IDE #permalink
    /document/html/search/all_9.js Deleted
    Open in IDE #permalink
    /document/html/search/all_a.html Deleted
    Open in IDE #permalink
    /document/html/search/all_a.js Deleted
    Open in IDE #permalink
    /document/html/search/all_b.html Deleted
    Open in IDE #permalink
    /document/html/search/all_b.js Deleted
    Open in IDE #permalink
    /document/html/search/all_c.html Deleted
    Open in IDE #permalink
    /document/html/search/all_c.js Deleted
    Open in IDE #permalink
    /document/html/search/all_d.html Deleted
    Open in IDE #permalink
    /document/html/search/all_d.js Deleted
    Open in IDE #permalink
    /document/html/search/classes_0.html Deleted
    Open in IDE #permalink
    /document/html/search/classes_0.js Deleted
    Open in IDE #permalink
    /document/html/search/close.png Deleted
    Open in IDE #permalink
    /document/html/search/files_0.html Deleted
    Open in IDE #permalink
    /document/html/search/files_0.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_0.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_0.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_1.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_1.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_2.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_2.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_3.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_3.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_4.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_4.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_5.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_5.js Deleted
    Open in IDE #permalink
    /document/html/search/functions_6.html Deleted
    Open in IDE #permalink
    /document/html/search/functions_6.js Deleted
    Open in IDE #permalink
    /document/html/search/mag_sel.png Deleted
    Open in IDE #permalink
    /document/html/search/namespaces_0.html Deleted
    Open in IDE #permalink
    /document/html/search/namespaces_0.js Deleted
    Open in IDE #permalink
    /document/html/search/nomatches.html Deleted
    Open in IDE #permalink
    /document/html/search/pages_0.html Deleted
    Open in IDE #permalink
    /document/html/search/pages_0.js Deleted
    Open in IDE #permalink
    /document/html/search/search.css Deleted
    Open in IDE #permalink
    /document/html/search/search.js Deleted
    Open in IDE #permalink
    /document/html/search/search_l.png Deleted
    Open in IDE #permalink
    /document/html/search/search_m.png Deleted
    Open in IDE #permalink
    /document/html/search/search_r.png Deleted
    Open in IDE #permalink
    /document/html/search/searchdata.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_0.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_0.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_1.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_1.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_2.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_2.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_3.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_3.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_4.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_4.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_5.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_5.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_6.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_6.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_7.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_7.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_8.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_8.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_9.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_9.js Deleted
    Open in IDE #permalink
    /document/html/search/variables_a.html Deleted
    Open in IDE #permalink
    /document/html/search/variables_a.js Deleted
    Open in IDE #permalink
    /document/html/DG_8py.html Deleted
    Open in IDE #permalink
    /document/html/DG__Firmware__Simulator_8py.html Deleted
    Open in IDE #permalink
    /document/html/DenaliSerialMessengerTester_8py.html Deleted
    Open in IDE #permalink
    /document/html/DenaliSerialMessenger_8py.html Deleted
    Open in IDE #permalink
    /document/html/DialityCoreSerialProtocol_8py.html Deleted
    Open in IDE #permalink
    /document/html/DialitySerialMessenger_8py.html Deleted
    Open in IDE #permalink
    /document/html/DialysateGenerator_8py.html Deleted
    Open in IDE #permalink
    /document/html/annotated.html Deleted
    Open in IDE #permalink
    /document/html/bc_s.png Deleted
    Open in IDE #permalink
    /document/html/bdwn.png Deleted
    Open in IDE #permalink
    /document/html/classDG-members.html Deleted
    Open in IDE #permalink
    /document/html/classDG.html Deleted
    Open in IDE #permalink
    /document/html/classDG_1_1DG-members.html Deleted
    Open in IDE #permalink
    /document/html/classDG_1_1DG.html Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State-members.html Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State.html Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DenaliSerialMessenger-members.html Deleted
    Open in IDE #permalink
    /document/html/classDenaliSerialMessenger_1_1DenaliSerialMessenger.html Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State-members.html Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State.html Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DialitySerialMessenger-members.html Deleted
    Open in IDE #permalink
    /document/html/classDialityCoreSerialProtocol_1_1DialitySerialMessenger.html Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State-members.html Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State.html Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DialitySerialMessenger-members.html Deleted
    Open in IDE #permalink
    /document/html/classDialitySerialMessenger_1_1DialitySerialMessenger.html Deleted
    Open in IDE #permalink
    /document/html/classDialysateGenerator_1_1DG-members.html Deleted
    Open in IDE #permalink
    /document/html/classDialysateGenerator_1_1DG.html Deleted
    Open in IDE #permalink
    /document/html/classes.html Deleted
    Open in IDE #permalink
    /document/html/closed.png Deleted
    Open in IDE #permalink
    /document/html/dg_object-example.html Deleted
    Open in IDE #permalink
    /document/html/doc.png Deleted
    Open in IDE #permalink
    /document/html/doxygen.css Deleted
    Open in IDE #permalink
    /document/html/doxygen.png Deleted
    Open in IDE #permalink
    /document/html/dynsections.js Deleted
    Open in IDE #permalink
    /document/html/examples.html Deleted
    Open in IDE #permalink
    /document/html/files.html Deleted
    Open in IDE #permalink
    /document/html/folderclosed.png Deleted
    Open in IDE #permalink
    /document/html/folderopen.png Deleted
    Open in IDE #permalink
    /document/html/functions.html Deleted
    Open in IDE #permalink
    /document/html/functions_func.html Deleted
    Open in IDE #permalink
    /document/html/functions_vars.html Deleted
    Open in IDE #permalink
    /document/html/graph_legend.dot Deleted
    Open in IDE #permalink
    /document/html/graph_legend.html Deleted
    Open in IDE #permalink
    /document/html/graph_legend.md5 Deleted
    Open in IDE #permalink
    /document/html/hierarchy.html Deleted
    Open in IDE #permalink
    /document/html/index.html Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_0.dot Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_0.md5 Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_1.dot Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_1.md5 Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_2.dot Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_2.md5 Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_3.dot Deleted
    Open in IDE #permalink
    /document/html/inherit_graph_3.md5 Deleted
    Open in IDE #permalink
    /document/html/inherits.html Deleted
    Open in IDE #permalink
    /document/html/jquery.js Deleted
    Open in IDE #permalink
    /document/html/logo.jpg Deleted
    Open in IDE #permalink
    /document/html/menu.js Deleted
    Open in IDE #permalink
    /document/html/menudata.js Deleted
    Open in IDE #permalink
    /document/html/namespaceDG.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDG__Firmware__Simulator.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDenaliSerialMessenger.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDenaliSerialMessengerTester.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDialityCoreSerialProtocol.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDialitySerialMessenger.html Deleted
    Open in IDE #permalink
    /document/html/namespaceDialysateGenerator.html Deleted
    Open in IDE #permalink
    /document/html/namespacemembers.html Deleted
    Open in IDE #permalink
    /document/html/namespacemembers_func.html Deleted
    Open in IDE #permalink
    /document/html/namespacemembers_vars.html Deleted
    Open in IDE #permalink
    /document/html/namespaces.html Deleted
    Open in IDE #permalink
    /document/html/nav_f.png Deleted
    Open in IDE #permalink
    /document/html/nav_g.png Deleted
    Open in IDE #permalink
    /document/html/nav_h.png Deleted
    Open in IDE #permalink
    /document/html/open.png Deleted
    Open in IDE #permalink
    /document/html/splitbar.png Deleted
    Open in IDE #permalink
    /document/html/sync_off.png Deleted
    Open in IDE #permalink
    /document/html/sync_on.png Deleted
    Open in IDE #permalink
    /document/html/tab_a.png Deleted
    Open in IDE #permalink
    /document/html/tab_b.png Deleted
    Open in IDE #permalink
    /document/html/tab_h.png Deleted
    Open in IDE #permalink
    /document/html/tab_s.png Deleted
    Open in IDE #permalink
    /document/html/tabs.css Deleted
    Open in IDE #permalink
    /document/latex/DG_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DG__Firmware__Simulator_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DenaliSerialMessengerTester_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DenaliSerialMessenger_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DialityCoreSerialProtocol_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DialitySerialMessenger_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/DialysateGenerator_8py.tex Deleted
    Open in IDE #permalink
    /document/latex/Makefile Deleted
    Open in IDE #permalink
    /document/latex/annotated.tex Deleted
    Open in IDE #permalink
    /document/latex/classDG.tex Deleted
    Open in IDE #permalink
    /document/latex/classDG_1_1DG.tex Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State.tex Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State.tex.tmp Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDenaliSerialMessenger_1_1DenaliSerialMessenger.tex Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State.tex Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State.tex.tmp Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDialityCoreSerialProtocol_1_1DialitySerialMessenger.tex Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State.tex Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State.tex.tmp Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State__coll__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State__coll__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State__inherit__graph.dot Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DSM__State__inherit__graph.md5 Deleted
    Open in IDE #permalink
    /document/latex/classDialitySerialMessenger_1_1DialitySerialMessenger.tex Deleted
    Open in IDE #permalink
    /document/latex/classDialysateGenerator_1_1DG.tex Deleted
    Open in IDE #permalink
    /document/latex/dg_object-example.tex Deleted
    Open in IDE #permalink
    /document/latex/doxygen.sty Deleted
    Open in IDE #permalink
    /document/latex/examples.tex Deleted
    Open in IDE #permalink
    /document/latex/files.tex Deleted
    Open in IDE #permalink
    /document/latex/hierarchy.tex Deleted
    Open in IDE #permalink
    /document/latex/index.tex Deleted
    Open in IDE #permalink
    /document/latex/logo.jpg Deleted
    Open in IDE #permalink
    /document/latex/namespaceDG.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDG__Firmware__Simulator.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDenaliSerialMessenger.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDenaliSerialMessengerTester.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDialityCoreSerialProtocol.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDialitySerialMessenger.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaceDialysateGenerator.tex Deleted
    Open in IDE #permalink
    /document/latex/namespaces.tex Deleted
    Open in IDE #permalink
    /document/latex/refman.tex Deleted
    Open in IDE #permalink
    /document/Doxyfile Changed
    /document/Doxyfile Changed
    Open in IDE #permalink
    /tests/SeansUFTest.py Changed
    /tests/dg_heat_and_chemical_disinfect_test.py Changed
    /tests/dg_heat_disinfect_test.py Changed
    /tests/dg_nvm_scripts.py Changed
    /tests/dg_nvm_scripts.py Changed
    /tests/dg_tests.py Changed
    /tests/test_hd_dg_fans.py Changed
    /.gitignore Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /DialityCoreCanProtocol.py Changed
    /DialityCoreSerialProtocol.py Changed
    /DialysateGenerator.py Changed
    /HemodialysisDevice.py Changed
    /HemodialysisDevice.py Changed
    /README.md Changed
    /build.sh Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time