dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Feb 2022
8:33 pm

Dara Navaei

DEN-11705 worked on the software configuration

Options
    • -1
    • +2
    /dialin/hd/sw_config.py
    • -3
    • +11
    /dialin/utils/excel_ops.py
    • -17
    • +31
    /dialin/utils/nv_ops_utils.py
    • -2
    • +2
    /tests/dg_tests.py
    • -14
    • +45
    /tests/peter/test_dg_records.py
    • -4
    • +5
    /tests/peter/test_hd_records.py
4:29 pm

Michael Garthwaite

These are all the same changes from http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

These are all the same changes from

http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

4:28 pm

Michael Garthwaite

These are all the same changes from http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

These are all the same changes from

http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

8:35 am

Sean Nash

This looks backwards. double should be 8, float should be 4.

This looks backwards. double should be 8, float should be 4.

8:27 am

Sean Nash

Header suggests there are only 2 parameters. What is this 3rd param and why is it zero?

Header suggests there are only 2 parameters. What is this 3rd param and why is it zero?

Monday 07 Feb 2022
6:15 pm

Dara Navaei

DIALIN-UI-S63
DIALIN-UI-S63
6:06 pm

Behrouz NematiPour

Merge branch 'UI_S63' into develop

Options
    • -27
    • +21
    /dialin/ui/hd_simulator.py
3:43 pm

Behrouz NematiPour

Band-aid the Blood prime message for now

- UI and Dialin are not in sync with the MessageList.

Options
    • -0
    • +1
    /dialin/ui/hd_simulator.py
10:25 am

Michael Garthwaite

Merge branch 'DEN-11980-sw_dev-sprint-64' into develop

Options
    • -1
    • +13
    /dialin/hd/hemodialysis_device.py
10:22 am

Michael Garthwaite

DIAL-145: Added get function for UI version. Removed debugging statement.

Options
    • -1
    • +13
    /dialin/hd/hemodialysis_device.py
Friday 04 Feb 2022
10:31 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
10:31 am

Dara Navaei

DEN-11750 updated the calibration record

Options
    • -1
    • +1
    /dialin/dg/calibration_record.py
10:21 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -0
    • +2
    /dialin/hd/hemodialysis_device.py
10:20 am

Dara Navaei

DEN-11750 updated the nv_ops_utils.py

Options
    • -6
    • +2
    /dialin/utils/nv_ops_utils.py
9:29 am

Michael Garthwaite

Merge branch 'DEN-11980-sw_dev-sprint-64' into develop

Options
9:23 am

Michael Garthwaite

DIAL-145: Implemented UI version request in hemodialysis_device.py. Handler method as well.

Options
    • -0
    • +63
    /dialin/hd/hemodialysis_device.py
Thursday 03 Feb 2022
8:38 pm

Dara Navaei

DEN-11750 updated the software configurations

Options
    • -31
    • +5
    /dialin/hd/calibration_record.py
    • -4
    • +3
    /dialin/hd/sw_config.py
    • -2
    • +14
    /dialin/utils/excel_ops.py
    • -5
    • +10
    /dialin/utils/nv_ops_utils.py
    • -6
    • +6
    /tests/peter/test_dg_records.py
    • -7
    • +12
    /tests/peter/test_hd_records.py
Wednesday 02 Feb 2022
12:16 pm

Behrouz NematiPour

10:25 am

Michael Garthwaite

Overall the use of this file is a bit funny. If this is ran within a Squish test, maybe we should rename/move the file (Ex: system_env_BAT.py) to be more coherent as it currently implies that it is...

Overall the use of this file is a bit funny. If this is ran within a Squish test, maybe we should rename/move the file (Ex: system_env_BAT.py) to be more coherent as it currently implies that it is unit testing something in this folder when it is testing the ENV and CAN.

10:10 am

Michael Garthwaite

Totally in favor of the workaround.

Totally in favor of the workaround.

10:03 am

Michael Garthwaite

RESOLVED.

RESOLVED.

Tuesday 01 Feb 2022
8:53 pm

Dara Navaei

RESOLVED.

RESOLVED.

8:53 pm

Dara Navaei

RESOLVED.

RESOLVED.

7:23 pm

Behrouz NematiPour

Fixed.

Fixed.

7:21 pm

Behrouz NematiPour

DIALIN-BUG-S63: DIALIN-BUG-S63-1

- Addressed code review comments.

Options
    • -25
    • +20
    /dialin/ui/hd_simulator.py
    • -1
    • +1
    /dialin/ui/unittests.py
4:54 pm

Behrouz NematiPour

That is correct and I have something in mind to improve the code. But I believe this is more related to Dialin bugs: 1 - First one which we talked about that Dialin creates all the objects even it...

That is correct and I have something in mind to improve the code.

But I believe this is more related to Dialin bugs:
1 - First one which we talked about that Dialin creates all the objects even it is not being used in the _init_.py files which cause different use-cases of the API to be not compatible together and can't be used together.
2 - the other issue is that the Dialin as an API should by nature be a passive code and just have the capabilities to be extended those observers have to be removed from Dialin.

For now, I'll put a workaround for this, and later we should discuss the better implementation of the Dialin API.

3:32 pm

Behrouz NematiPour

Separate functions have been created to keep the string representations clearer. It is not safe to use something like "b" or "B" since anyone can even but something like "hello" which probably does...

Separate functions have been created to keep the string representations clearer.
It is not safe to use something like "b" or "B" since anyone can even but something like "hello" which probably doesn't mean anything and is an error.
to overcome this flow the different functions implemented here have to be used.

Also since the intention of the function here is clear the length has been calculated regarding the type conversion in each function.
which helps have a lot of clearer code.
Please refer to the usage in:
d9b45e5b52db2540a79cbc8795d82dda4fd3984b on dialin develop branch.

the code has changed from:

        major = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MAJOR:self.END_POS_MAJOR]))
        minor = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MINOR:self.END_POS_MINOR]))
        micro = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MICRO:self.END_POS_MICRO]))
        build = struct.unpack('H', bytearray(
            message['message'][self.START_POS_BUILD:self.END_POS_BUILD]))
        compatibility = struct.unpack('H', bytearray(
            message['message'][self.START_POS_COMPAT:self.END_POS_COMPAT]))

which was so error-prone to the following code:

        major, index = bytearray_to_byte(payload, index, False)
        minor, index = bytearray_to_byte(payload, index, False)
        micro, index = bytearray_to_byte(payload, index, False)
        build, index = bytearray_to_short(payload, index, False)
        compt, index = bytearray_to_integer(payload, index, False)
3:17 pm

Behrouz NematiPour

I don't think that is a good idea to get a hug class like logging to be involved in here. It would be better to use the logging in the class which using these very basic functions.

I don't think that is a good idea to get a hug class like logging to be involved in here.
It would be better to use the logging in the class which using these very basic functions.

Monday 31 Jan 2022
10:28 am

Dara Navaei

DEN-11750 worked on the software configurations

Options
    • -1
    • +8
    /dialin/hd/sw_config.py
    • -24
    • +39
    /tests/dg_tests.py
    • -2
    • +4
    /tests/hd_blood_leak_data.py
    • -6
    • +6
    /tests/peter/test_dg_records.py
    • -1
    • +6
    /tests/test_hd_dg_fans.py
Thursday 27 Jan 2022
9:46 am

Dara Navaei

DEN-11750 work in progress

Options
    • -4
    • +4
    /dialin/dg/sw_config.py
    • -0
    • +2
    /dialin/hd/hemodialysis_device.py
    • -0
    • +299
    /dialin/hd/sw_config.py
    • -11
    • +34
    /tests/hd_blood_leak_data.py
    • -2
    • +34
    /tests/hd_valves_test.py
    • -8
    • +8
    /tests/peter/set_RTCs.py
    • -3
    • +3
    /tests/peter/test_dg_records.py
    • -1
    • +28
    /tests/peter/test_hd_records.py