Activity dialin/

You are right, It is just a temporary fix to make the API work with the current UI which is not updated to the latest Messages list, for the LTTS to get them unblocked. As part of the LTTS support ...

You are right,
It is just a temporary fix to make the API work with the current UI which is not updated to the latest Messages list, for the LTTS to get them unblocked.
As part of the LTTS support and the messages list update/sync it will be removed/fixed.

2:31 pm

Behrouz NematiPour

More
Re: DIALIN-UI-S63-1
replied to Sean Nash

Great catch, Thanks, fixed. Fortunately, it wasn't being used anywhere.

Great catch,
Thanks, fixed.
Fortunately, it wasn't being used anywhere.

2:30 pm

Behrouz NematiPour

More
fcfc61f
changed 1 file
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update and 198 more DIALIN-BUG-S63-1 DIALIN-UI-S63-1

DIALIN-UI-S63: DIALIN-UI-S63-1

- Addressed the code review comments.

- -2
- +2
/dialin/utils/conversions.py
- History
- Source
- Diff
/dialin/utils/conversions.py

2:29 pm

Dara Navaei

More
8aae8b7
changed 3 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update and 196 more

DEN-11750 work in progress

- -14
- +16
/dialin/hd/sw_config.py
- History
- Source
- Diff
/dialin/hd/sw_config.py
- -0
- +1
/dialin/utils/nv_ops_utils.py
- History
- Source
- Diff
/dialin/utils/nv_ops_utils.py
- -2
- +2
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py

2:00 pm

Michael Garthwaite

More
8da7657
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-11980-sw_dev-sprint-64' into develop

- -5
- +1
/dialin/hd/treatment.py
- History
- Source
- Diff
/dialin/hd/treatment.py

1:59 pm

Michael Garthwaite

More
cd08a00
changed 4 files
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update and 197 more DIALIN-DEN-11980-1

DIAL-139

Updated hd_defs with UF and Saline operation enums. Updated Alarms def and msg_id's. Fixed current treatment parameters not following HEX sequence, syncing with FW.

- -291
- +291
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py
- -3
- +7
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -2
- +17
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -371
- +380
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py

12:37 pm

Behrouz NematiPour

Thanks for your attention to the details. I think you are right. Probably the code review is duplicate, my bad.

Thanks for your attention to the details.
I think you are right.
Probably the code review is duplicate, my bad.

12:33 pm

Behrouz NematiPour

It could be since both of the code reviews are for the S63 changes. Probably the same commit has been added.

It could be since both of the code reviews are for the S63 changes.
Probably the same commit has been added.

10:39 am

Michael Garthwaite

More
a40950b
changed 1 file
DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up, DEN-11928-dg-conductivity-update and 197 more DIALIN-DEN-11980-1

DIAL-129 implementation.

DIAL-129 implementation. Message protocol no longer contains blood_prime_safety_cum_vol. Removed blood_prime_ind_cum_vol to sync with current message protocol.