dialin

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12224, DEN-12232 added commands to DG and HD fans to be able to set the RPM alarm start time offset

DEN-11928 Log DG sub mode

DEN-11928 Log data in fill mode

    • -0
    • +132
    /tests/test_conductivity.py
Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

DEN-12121: Fixed swapped heparin values for request treatment parameters.

To be consistent with rest of the code and what has been decided use the standard docstring format as: @param (int): <description> @return (int): <description>

To be consistent with rest of the code and what has been decided use the standard docstring format as:
@param (int): <description>
@return (int): <description>

Please use the new conversion methods, from now on. I believe we decided to use them until you find time to update all the others.

Please use the new conversion methods, from now on.
I believe we decided to use them until you find time to update all the others.

unnecessary empty lines.

unnecessary empty lines.

please follow the standard: @retrurn: (int) <description>

please follow the standard:
@retrurn: (int) <description>

Please add the simulator functions for the newly added models, like the: *DG Conductivity Data *HD blood leak data *HD air bubbles data *Air Trap Data *.....

Please add the simulator functions for the newly added models, like the:

  • DG Conductivity Data
  • HD blood leak data
  • HD air bubbles data
  • Air Trap Data
  • .....
update the docstring.

update the docstring.

the docstring says it is bool, which is correct.

the docstring says it is bool, which is correct.

Please align the pipes ( | ) fix #5 to #6

Please align the pipes ( | )
fix #5 to #6

Please update doctring here and above.

Please update doctring here and above.

Please update docstring here and above.

Please update docstring here and above.

Please update the docstring here and on top.

Please update the docstring here and on top.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 13 more files in changeset.
Merged DEN-11750

DEN-11750 changed the temperatures

DIALIN-DEN-12121_SW Dev Sprint 65
DIALIN-DEN-12121_SW Dev Sprint 65
RESOLVED.

RESOLVED.

DEN-11750 addressed the code review comments

This variable was very temporary. I deleted it.

This variable was very temporary. I deleted it.

DEN-11750 updated the code

DEN-11750 updated the sw_config to sw_configs

Merged DEN-11750

    • -0
    • +289
    /dialin/dg/sw_configs.py
    • -0
    • +320
    /dialin/hd/sw_configs.py
DEN-11750 Updated the sw_config file to sw_configs

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?

I don't have an issue with temporary features or variables being merged into staging but could we not name them so vaguely? Ex: calc_rpm_start_time_removable or calc_rpm_start_time_temporary?