Activity dialin/

11:31 am

Michael Garthwaite

More
8904c14
changed 2 files
DEN-11928-dg-conductivity-update, DEN-12121-sw_dev-sprint-65 and 195 more DIALIN-DEN-12121-1

Merge branch 'staging' into DEN-12121-sw_dev-sprint-65

- -4
- +4
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -11
- +12
/dialin/hd/treatment.py
- History
- Source
- Diff
/dialin/hd/treatment.py

11:31 am

Michael Garthwaite

Fixed. Thanks!

11:31 am

Michael Garthwaite

Fixed. Thanks!

11:31 am

Michael Garthwaite

Fixed. Thanks!

11:18 am

Michael Garthwaite

More
1622d05
changed 2 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

- -1
- +2
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -31
- +106
/dialin/ui/hd_simulator.py
- History
- Source
- Diff
/dialin/ui/hd_simulator.py

11:15 am

Michael Garthwaite

More
d78c6ab
changed 6 files
DEN-11928-dg-conductivity-update, DEN-12121-sw_dev-sprint-65 and 195 more DIALIN-DEN-12121-1

DEN-12121: Updates per code review. Updated HD simulator to contain HD broadcast messages for UI testing. Changed HD communication status override to control the bool instead of setting to TRUE only.

- -13
- +14
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -1
- +2
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -8
- +7
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -7
- +9
/dialin/hd/post_treatment.py
- History
- Source
- Diff
/dialin/hd/post_treatment.py
- -0
- +24
/dialin/ui/dg_simulator.py
- History
- Source
- Diff
/dialin/ui/dg_simulator.py
- -34
- +109
/dialin/ui/hd_simulator.py
- History
- Source
- Diff
/dialin/ui/hd_simulator.py

8:37 pm

Dara Navaei

More
Re: DIALIN-DEN-12121-1
commented on review

This should be 0xA04F.

8:35 pm

Dara Navaei

More
Re: DIALIN-DEN-12121-1
commented on review

For consistency, HD_PRIME_PAUSE and HD_PRIME_COMPLETE should have STATE at the end of their names.

5:27 pm

Dara Navaei

More
dc34d36
changed 9 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merged DEN-12224 and resolved the merge conflicts

- -1
- +3
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -1
- +1
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -1
- +1
/dialin/dg/ro_pump.py
- History
- Source
- Diff
/dialin/dg/ro_pump.py
- -1
- +1
/dialin/dg/temperatures.py
- History
- Source
- Diff
/dialin/dg/temperatures.py
- -35
- +32
/dialin/hd/fans.py
- History
- Source
- Diff
/dialin/hd/fans.py
- -2
- +2
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -1
- +1
/dialin/hd/treatment.py
- History
- Source
- Diff
/dialin/hd/treatment.py
- -2
- +2
/dialin/version.py
- History
- Source
- Diff
/dialin/version.py
- -0
- +15
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py

5:25 pm

Dara Navaei

More
d69bbb9
changed 4 files
DEN-12224-dg_hd_dev-switches-monitor, DEN-12358-sw_dev-sprint-67_mg and 186 more DIALIN-DEN-12224-1

DEN-12224, DEN-12232 added commands to DG and HD fans to be able to set the RPM alarm start time offset

- -0
- +2
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -34
- +31
/dialin/dg/fans.py
- History
- Source
- Diff
/dialin/dg/fans.py
- -34
- +31
/dialin/hd/fans.py
- History
- Source
- Diff
/dialin/hd/fans.py
- -10
- +4
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py

11:37 am

Hung Nguyen <hnguyen@diality.com>

More
da38ea2
changed 1 file
DEN-11928-dg-conductivity-update, DEN-12224-dg_hd_dev-switches-monitor and 193 more

DEN-11928 Log DG sub mode

- -0
- +2
/tests/test_conductivity.py
- History
- Source
- Diff
/tests/test_conductivity.py

10:45 am

Hung Nguyen <hnguyen@diality.com>

More
ca1fa9e
added 1 file
DEN-11928-dg-conductivity-update, DEN-12224-dg_hd_dev-switches-monitor and 193 more DIALIN-DEN-11928-1 DIALIN-DEN-12716-1

DEN-11928 Log data in fill mode

- -0
- +132
/tests/test_conductivity.py
- History
- Source
/tests/test_conductivity.py

2:45 pm

Michael Garthwaite

More
d4468c2
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-12121-sw_dev-sprint-65' into develop

- -2
- +2
/dialin/hd/treatment.py
- History
- Source
- Diff
/dialin/hd/treatment.py

2:45 pm

Michael Garthwaite

More
e93b8f3
changed 1 file
DEN-11928-dg-conductivity-update, DEN-12121-sw_dev-sprint-65 and 195 more DIALIN-DEN-12121-1

DEN-12121: Fixed swapped heparin values for request treatment parameters.

- -2
- +2
/dialin/hd/treatment.py
- History
- Source
- Diff
/dialin/hd/treatment.py

12:37 am

Behrouz NematiPour

More
Re: DIALIN-DEN-12121-1
commented on review

To be consistent with rest of the code and what has been decided use the standard docstring format as: @param (int): <description> @return (int): <description>

To be consistent with rest of the code and what has been decided use the standard docstring format as:
@param (int): <description>
@return (int): <description>

12:35 am

Behrouz NematiPour

More
Re: DIALIN-DEN-12121-1
commented on review

Please use the new conversion methods, from now on. I believe we decided to use them until you find time to update all the others.

Please use the new conversion methods, from now on.
I believe we decided to use them until you find time to update all the others.

12:34 am

Behrouz NematiPour

More
Re: DIALIN-DEN-12121-1
commented on review

unnecessary empty lines.

12:34 am

Behrouz NematiPour

More
Re: DIALIN-DEN-12121-1
commented on review

please follow the standard: @retrurn: (int) <description>

please follow the standard:
@retrurn: (int) <description>

12:32 am

Behrouz NematiPour

More
Re: DIALIN-DEN-12121-1
commented on review

Please add the simulator functions for the newly added models, like the: *DG Conductivity Data *HD blood leak data *HD air bubbles data *Air Trap Data *.....

Please add the simulator functions for the newly added models, like the: