dialin

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12224 updated the HD SW configuration

Merged DEN-12224

DEN-12224 updated the hd nvm code

DEN-12224 updated the dg nvm code

DEN-12224: Fixed post treatment handler to use the helper methods in conversions.py

DEN-12224 updated the DG software configurations

I don't see any reference/use to the created object. Why do we need to create all the objects while we don't even use them? This approach creates a lot of dependencies and also makes Dialin a very ...

I don't see any reference/use to the created object.
Why do we need to create all the objects while we don't even use them?
This approach creates a lot of dependencies and also makes Dialin a very heavy API to load.

Unnecessary/confusing use of ternary-if. please change to: self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1

Unnecessary/confusing use of ternary-if.
please change to:

self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1
It is big data to be reserved and filled with just default values, There should be a better way.

It is big data to be reserved and filled with just default values, There should be a better way.

Please use conversions.py

Please use conversions.py

Sean Nash, Dara Navaei, Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build. It should be d...

Sean Nash, Dara Navaei,
Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build.
It should be done when the actual code is changed in the common repo, not the dialin.
I am going to update UI now but the comment is for later.

Same here [ using conversaions.py ]

Same here [ using conversaions.py ]

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone. We should plan soon to ...

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone.
We should plan soon to make these changes.

DEN-12358: updated pre-treatment no cartridge self-test states enum.

DEN-12358: updated pre-treatment no cartridge self-test states enum.

Merge branch 'DEN-12358-sw_dev-sprint-67_mg' into develop

DEN-12358: Fixed HD alarms bugs.

DIALIN-DEN-12258_UI BN S66
DIALIN-DEN-12258_UI BN S66
Merged DEN-12224

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

DEN-12224 added the switches monitor software configuration

Merge branch 'DEN-12258-UI-BN-S66' into develop

DEN-12514: LTS: Support/Development

- Added an observer method to get the sent message from UI application over the CANBus in through Dialin.

- Added the AlarmTrigger new 3 extra parameters.

- Updated the Dialin APIs to use the new unsigned_integer_to_bytearray function name.

Please change the byte order for struct.unpack

Please change the byte order for struct.unpack

the old comment is correct. The else branch statement handles no content.

the old comment is correct. The else branch statement handles no content.

Please change the byte order for struct.unpack

Please change the byte order for struct.unpack

Please change the byte order of struct.unpack

Please change the byte order of struct.unpack

As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.

As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.

Please implement a getter for wet_self_test_states

Please implement a getter for wet_self_test_states