dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 Apr 2022
2:56 pm

Dara Navaei

DEN-12224 updated the HD SW configuration

Options
    • -1
    • +1
    /dialin/hd/sw_configs.py
2:21 pm

Dara Navaei

Merged DEN-12224

Options
    • -1
    • +1
    /dialin/utils/conversions.py
    • -10
    • +31
    /tests/dg_tests.py
2:18 pm

Dara Navaei

DEN-12224 updated the hd nvm code

Options
    • -0
    • +1
    /dialin/dg/sw_configs.py
    • -0
    • +1
    /dialin/hd/sw_configs.py
    • -0
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
1:09 pm

Dara Navaei

DEN-12224 updated the dg nvm code

Options
    • -17
    • +17
    /dialin/dg/sw_configs.py
    • -3
    • +3
    /dialin/hd/post_treatment.py
    • -2
    • +2
    /tests/dg_hd_switches_test.py
    • -18
    • +47
    /tests/dg_nvm_scripts.py
1:09 pm

Michael Garthwaite

DEN-12224: Fixed post treatment handler to use the helper methods in conversions.py

Options
    • -10
    • +4
    /dialin/hd/post_treatment.py
Monday 18 Apr 2022
11:18 pm

Dara Navaei

DEN-12224 updated the DG software configurations

Options
    • -0
    • +5
    /dialin/common/dg_defs.py
    • -1
    • +2
    /dialin/dg/pressures.py
    • -5
    • +20
    /dialin/dg/sw_configs.py
    • -5
    • +25
    /dialin/hd/post_treatment.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -8
    • +22
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
Friday 08 Apr 2022
9:48 am

Sean Nash

Thursday 07 Apr 2022
2:25 pm

Behrouz NematiPour

I don't see any reference/use to the created object. Why do we need to create all the objects while we don't even use them? This approach creates a lot of dependencies and also makes Dialin a very ...

I don't see any reference/use to the created object.
Why do we need to create all the objects while we don't even use them?
This approach creates a lot of dependencies and also makes Dialin a very heavy API to load.

2:17 pm

Behrouz NematiPour

Unnecessary/confusing use of ternary-if. please change to: self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1

Unnecessary/confusing use of ternary-if.
please change to:

self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1
2:11 pm

Behrouz NematiPour

It is big data to be reserved and filled with just default values, There should be a better way.

It is big data to be reserved and filled with just default values, There should be a better way.

2:10 pm

Behrouz NematiPour

Please use conversions.py

Please use conversions.py

1:32 pm

Behrouz NematiPour

Sean Nash, Dara Navaei, Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build. It should be d...

Sean Nash, Dara Navaei,
Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build.
It should be done when the actual code is changed in the common repo, not the dialin.
I am going to update UI now but the comment is for later.

12:27 pm

Behrouz NematiPour

Same here [ using conversaions.py ]

Same here [ using conversaions.py ]

12:27 pm

Behrouz NematiPour

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone. We should plan soon to ...

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone.
We should plan soon to make these changes.

Wednesday 06 Apr 2022
12:25 pm

Sean Nash

DEN-12358: updated pre-treatment no cartridge self-test states enum.

Options
    • -6
    • +5
    /dialin/common/hd_defs.py
10:50 am

Sean Nash

DEN-12358: updated pre-treatment no cartridge self-test states enum.

Options
    • -11
    • +9
    /dialin/common/hd_defs.py
8:28 am

Sean Nash

Merge branch 'DEN-12358-sw_dev-sprint-67_mg' into develop

Options
8:27 am

Sean Nash

DEN-12358: Fixed HD alarms bugs.

Options
    • -4
    • +3
    /dialin/hd/alarms.py
Monday 04 Apr 2022
11:06 am

Dara Navaei

DIALIN-DEN-12258_UI BN S66
DIALIN-DEN-12258_UI BN S66
10:33 am

Dara Navaei

Merged DEN-12224

Options
    • -2
    • +2
    /tests/dg_nvm_scripts.py
    • -9
    • +9
    /tests/dg_tests.py
9:51 am

Dara Navaei

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

Options
    • -0
    • +4
    /dialin/dg/dialysate_generator.py
    • -4
    • +4
    /dialin/dg/ro_pump.py
9:51 am

Dara Navaei

DEN-12224 added the switches monitor software configuration

Options
    • -0
    • +1
    /dialin/hd/sw_configs.py
    • -0
    • +3
    /tests/dg_tests.py
    • -3
    • +3
    /tests/hd_nvm_scripts.py
Saturday 02 Apr 2022
11:20 pm

Behrouz NematiPour

Merge branch 'DEN-12258-UI-BN-S66' into develop

Options
    • -29
    • +92
    /dialin/protocols/CAN.py
10:35 pm

Behrouz NematiPour

DEN-12514: LTS: Support/Development

- Added an observer method to get the sent message from UI application over the CANBus in through Dialin.

- Added the AlarmTrigger new 3 extra parameters.

- Updated the Dialin APIs to use the new unsigned_integer_to_bytearray function name.

Options
    • -29
    • +92
    /dialin/protocols/CAN.py
    • -15
    • +38
    /dialin/ui/hd_simulator.py
    • -2
    • +11
    /dialin/ui/hd_simulator_alarms.py
Friday 01 Apr 2022
11:02 am

Michael Garthwaite

Please change the byte order for struct.unpack

Please change the byte order for struct.unpack

11:01 am

Michael Garthwaite

the old comment is correct. The else branch statement handles no content.

the old comment is correct. The else branch statement handles no content.

10:57 am

Michael Garthwaite

Please change the byte order for struct.unpack

Please change the byte order for struct.unpack

10:57 am

Michael Garthwaite

Please change the byte order of struct.unpack

Please change the byte order of struct.unpack

10:56 am

Michael Garthwaite

As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.

As much as I dont like this (Values should be left numerical. Let the API user convert it to something easier to read if they want), please add the same value check for wet_self_test_state.

10:52 am

Michael Garthwaite

Please implement a getter for wet_self_test_states

Please implement a getter for wet_self_test_states