dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 May 2022
10:32 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/vv/dialin into develop

Options
    • -2
    • +2
    /dialin/common/dg_defs.py
    • -2
    • +2
    /dialin/common/msg_ids.py
    • -2
    • +2
    /dialin/dg/dialysate_generator.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
10:31 am

Dara Navaei

Merged DEN-12224

Options
    • -0
    • +2
    /dialin/dg/dialysate_generator.py
    • -0
    • +2
    /dialin/hd/hemodialysis_device.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -20
    • +27
    /tests/dg_tests.py
10:28 am

Sean Nash

10:28 am

Dara Navaei

DEN-12224 updated the blood leak sensor embedded mode commands

Options
    • -0
    • +3
    /dialin/common/msg_ids.py
    • -1
    • +1
    /dialin/dg/sw_configs.py
    • -2
    • +142
    /dialin/hd/blood_leak.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -6
    • +6
    /tests/dg_nvm_scripts.py
    • -10
    • +15
    /tests/dg_tests.py
    • -6
    • +17
    /tests/hd_blood_leak_data.py
    • -0
    • +1
    /tests/hd_nvm_scripts.py
Wednesday 11 May 2022
8:49 am

Sean Nash

I'm ok with this either way. Ternary should not be viewed as confusing, but agree it is unnecessary.

I'm ok with this either way. Ternary should not be viewed as confusing, but agree it is unnecessary.

8:47 am

Sean Nash

Mike, can you please look at updating these (and perhaps many others throughout Dialin)?

Mike, can you please look at updating these (and perhaps many others throughout Dialin)?

8:46 am

Sean Nash

I'm open to suggestions. It's been this way forever and has been working fine, so I'm also good leaving this as is.

I'm open to suggestions. It's been this way forever and has been working fine, so I'm also good leaving this as is.

8:45 am

Sean Nash

By "case", you mean a Jira bug? Sure, we can do that.

By "case", you mean a Jira bug? Sure, we can do that.

Friday 06 May 2022
1:03 pm

Michael Garthwaite

Merge branch 'DEN-12609-sw_dev-sprint-69_mg' into develop

Options
    • -2
    • +2
    /dialin/common/dg_defs.py
    • -2
    • +2
    /dialin/common/msg_ids.py
    • -2
    • +2
    /dialin/dg/conductivity_sensors.py
    • -2
    • +2
    /dialin/dg/dialysate_generator.py
    • -3
    • +3
    /dialin/ui/dg_simulator.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
1:02 pm

Michael Garthwaite

DEN-12704: DIAL-162: Implemented getter for target_flow_rate.

Options
    • -8
    • +16
    /dialin/dg/ro_pump.py
11:23 am

Michael Garthwaite

Merge branch 'staging' into DEN-12609-sw_dev-sprint-69_mg

Options
Thursday 05 May 2022
3:12 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /dialin/protocols/CAN.py
    • -3
    • +3
    /dialin/ui/dg_simulator.py
    • -2
    • +2
    /dialin/ui/hd_simulator.py
    • -2
    • +2
    /dialin/ui/hd_simulator_alarms.py
    • -1
    • +1
    /dialin/utils/conversions.py
3:11 pm

Behrouz NematiPour

Merge branch 'DEN-12258-UI-BN-S66' into staging

Options
Thursday 28 Apr 2022
10:11 pm

Dara Navaei

DEN-12224 initial commit of the HD/DG usage information scripts. Updated the NV data scripts

Options
    • -1
    • +0
    /dialin/common/dg_defs.py
    • -0
    • +6
    /dialin/common/msg_ids.py
    • -0
    • +2
    /dialin/dg/dialysate_generator.py
    • -3
    • +3
    /dialin/dg/sw_configs.py
    • -1
    • +1
    /dialin/dg/system_record.py
    • -0
    • +270
    /dialin/dg/usage_info_record.py
    • -0
    • +2
    /dialin/hd/hemodialysis_device.py
    • -0
    • +270
    /dialin/hd/usage_info_record.py
    • -2
    • +10
    /dialin/utils/nv_ops_utils.py
    • -0
    • +3
    /tests/dg_nvm_scripts.py
    • -4
    • +13
    /tests/dg_tests.py
    • -4
    • +4
    /tests/hd_nvm_scripts.py
11:35 am

Michael Garthwaite

Wednesday 20 Apr 2022
2:56 pm

Dara Navaei

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

Options
2:56 pm

Dara Navaei

DEN-12224 updated the HD SW configuration

Options
    • -1
    • +1
    /dialin/hd/sw_configs.py
2:21 pm

Dara Navaei

Merged DEN-12224

Options
    • -1
    • +1
    /dialin/utils/conversions.py
    • -10
    • +31
    /tests/dg_tests.py
2:18 pm

Dara Navaei

DEN-12224 updated the hd nvm code

Options
    • -0
    • +1
    /dialin/dg/sw_configs.py
    • -0
    • +1
    /dialin/hd/sw_configs.py
    • -0
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
1:09 pm

Dara Navaei

DEN-12224 updated the dg nvm code

Options
    • -17
    • +17
    /dialin/dg/sw_configs.py
    • -3
    • +3
    /dialin/hd/post_treatment.py
    • -2
    • +2
    /tests/dg_hd_switches_test.py
    • -18
    • +47
    /tests/dg_nvm_scripts.py
1:09 pm

Michael Garthwaite

DEN-12224: Fixed post treatment handler to use the helper methods in conversions.py

Options
    • -10
    • +4
    /dialin/hd/post_treatment.py
Monday 18 Apr 2022
11:18 pm

Dara Navaei

DEN-12224 updated the DG software configurations

Options
    • -0
    • +5
    /dialin/common/dg_defs.py
    • -1
    • +2
    /dialin/dg/pressures.py
    • -5
    • +20
    /dialin/dg/sw_configs.py
    • -5
    • +25
    /dialin/hd/post_treatment.py
    • -1
    • +1
    /dialin/utils/conversions.py
    • -8
    • +22
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
Friday 08 Apr 2022
9:48 am

Sean Nash

Thursday 07 Apr 2022
2:25 pm

Behrouz NematiPour

I don't see any reference/use to the created object. Why do we need to create all the objects while we don't even use them? This approach creates a lot of dependencies and also makes Dialin a very ...

I don't see any reference/use to the created object.
Why do we need to create all the objects while we don't even use them?
This approach creates a lot of dependencies and also makes Dialin a very heavy API to load.

2:17 pm

Behrouz NematiPour

Unnecessary/confusing use of ternary-if. please change to: self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1

Unnecessary/confusing use of ternary-if.
please change to:

self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1
2:11 pm

Behrouz NematiPour

It is big data to be reserved and filled with just default values, There should be a better way.

It is big data to be reserved and filled with just default values, There should be a better way.

2:10 pm

Behrouz NematiPour

Please use conversions.py

Please use conversions.py

1:32 pm

Behrouz NematiPour

Sean Nash, Dara Navaei, Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build. It should be d...

Sean Nash, Dara Navaei,
Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build.
It should be done when the actual code is changed in the common repo, not the dialin.
I am going to update UI now but the comment is for later.

12:27 pm

Behrouz NematiPour

Same here [ using conversaions.py ]

Same here [ using conversaions.py ]

12:27 pm

Behrouz NematiPour

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone. We should plan soon to ...

We had a conversation with Michael Garthwaite and all these functions are going to use the functions in the conversions.py since this method of doing it is very error-prone.
We should plan soon to make these changes.