dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Jun 2022
8:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/common/dg_defs.py
    • -2
    • +2
    /dialin/common/hd_defs.py
    • -1
    • +1
    /dialin/common/msg_ids.py
    • -2
    • +2
    /dialin/dg/chemical_disinfect.py
    • -1
    • +1
    /dialin/dg/concentrate_pumps.py
    • -1
    • +1
    /dialin/dg/conductivity_sensors.py
    • -2
    • +2
    /dialin/dg/dialysate_generator.py
    • -1
    • +1
    /dialin/dg/fans.py
    • -1
    • +1
    /dialin/dg/flush.py
    • -1
    • +1
    /dialin/dg/heaters.py
    • -2
    • +2
    /dialin/dg/pressures.py
    • -1
    • +1
    /dialin/dg/sw_configs.py
    • -1
    • +1
    /dialin/dg/switches.py
    • -1
    • +1
    /dialin/dg/system_record.py
    • -3
    • +3
    /dialin/dg/usage_info_record.py
  16. … 20 more files in changeset.
8:25 pm

Dara Navaei

8:21 pm

Behrouz NematiPour and Michael Garthwaite

3:16 pm

Dara Navaei

DEN-12224 updated the heaters

Options
    • -9
    • +5
    /dialin/dg/heaters.py
    • -6
    • +6
    /tests/dg_nvm_scripts.py
    • -7
    • +7
    /tests/dg_tests.py
    • -6
    • +2
    /tests/hd_nvm_scripts.py
    • -2
    • +2
    /tests/peter/set_RTCs.py
2:05 pm

Dara Navaei

Merge branch 'staging' into DEN-12224-dg_hd_dev-switches-monitor

Options
    • -2
    • +2
    /dialin/common/dg_defs.py
    • -2
    • +2
    /dialin/common/msg_ids.py
    • -2
    • +2
    /dialin/dg/conductivity_sensors.py
    • -2
    • +2
    /dialin/dg/dialysate_generator.py
    • -2
    • +16
    /dialin/utils/conversions.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_nvm_scripts.py
2:00 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

2:00 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:59 pm

Michael Garthwaite

RESOLVED.

RESOLVED.

1:56 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:56 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:55 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

1:55 pm

Dara Navaei

Will be addressed in in DIAL-171.

Will be addressed in in DIAL-171.

Saturday 18 Jun 2022
2:56 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -41
    • +15
    /dialin/hd/pretreatment.py
2:55 pm

Dara Navaei

Done.

Done.

2:54 pm

Dara Navaei

Done.

Done.

2:45 pm

Dara Navaei

DEN-12224 updated the test scripts for various tests

Options
    • -3
    • +3
    /tests/dg_nvm_scripts.py
    • -3
    • +6
    /tests/dg_tests.py
    • -1
    • +3
    /tests/hd_blood_leak_data.py
    • -8
    • +10
    /tests/peter/set_RTCs.py
    • -3
    • +3
    /tests/peter/test_dg_records.py
    • -3
    • +5
    /tests/peter/test_hd_records.py
Wednesday 15 Jun 2022
10:16 am

Dara Navaei

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

Options
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +6
    /tests/hd_nvm_scripts.py
10:16 am

Dara Navaei

DEN-12224 updated the blood leak observer class

Options
    • -2
    • +8
    /dialin/hd/blood_leak.py
    • -3
    • +4
    /dialin/hd/hemodialysis_device.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -4
    • +30
    /tests/hd_blood_leak_data.py
    • -1
    • +6
    /tests/hd_nvm_scripts.py
    • -2
    • +2
    /tests/peter/test_hd_records.py
Tuesday 14 Jun 2022
9:49 am

Sean Nash

Agree with Behrouz's initial proposed change above.

Agree with Behrouz's initial proposed change above.

9:35 am

Sean Nash

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans. If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly. I think the c...

alarm_cto[0] is an integer - not a boolean. alarm_clr_top_only[] is an array of booleans.
If Python boolean "True" is equivalent to integer "1", then I suppose we can assign directly.
I think the current way this assignment is coded is making no assumptions and explicitly converting integer to boolean which is ok with me.

Thursday 09 Jun 2022
9:02 am

Behrouz NematiPour

I not I understand the answer and how that related to my question. I think what I am trying to say is: *Why do we create an object that we have no use for it, yet. *Why create an object for every...

I not I understand the answer and how that related to my question.
I think what I am trying to say is:

  • Why do we create an object that we have no use for it, yet.
  • Why create an object for every class before even being used.
  • Or Why it is not being created when it is needed and where it is going to be used.


And could you please help understand what is "QoL feature"?

8:56 am

Behrouz NematiPour

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary. alarm_cto[0] == 1 it...

what I meant is the following statement is a binary why it has been compared with True/False once, and put in trinary once more just to compare a binary statement with binary.

alarm_cto[0] == 1

it is double the unnecessary work and confusing.

8:52 am

Behrouz NematiPour

We should improve the Dialin coding someday! RESOLVED

We should improve the Dialin coding someday!
RESOLVED

8:51 am

Behrouz NematiPour

Yes, Sean Nash, a Jira task, I meant. RESOLVED.

Yes, Sean Nash, a Jira task, I meant.
RESOLVED.

Wednesday 08 Jun 2022
11:19 am

Michael Garthwaite

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_...

This is a QoL feature for users. Otherwise they would have to create the CAN interface themselves and assign it themselves. V&V has had issues like this before where they would create VV_submodule_class and it ends up interfering with their data collection.

11:13 am

Michael Garthwaite

RESOLVED

RESOLVED

10:55 am

Dong Nguyen <dnguyen@diality.com>

Update the script for testing syringe pump operations.

Options
    • -9
    • +12
    /tests/test_syringe.py