dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 08 Dec 2022
2:26 pm

Dara Navaei

DEN-14001 addressed a code review comments

Options
    • -0
    • +1
    /dialin/common/msg_ids.py
2:25 pm

Dara Navaei

Done.

Done.

2:19 pm

Sean Nash

May not be needed, but can we just add 0xB8 too for completeness?

May not be needed, but can we just add 0xB8 too for completeness?

1:01 pm

Michael Garthwaite

1:01 pm

Dara Navaei

DEN-14001 merged staging

Options
    • -11
    • +20
    /dialin/common/msg_ids.py
    • -6
    • +6
    /dialin/hd/hemodialysis_device.py
11:35 am

Sean Nash

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only look...

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only looking at the first value (index 0) parsed.
Firmware is sending everything as U32. So we should be using "I" for unsigned int.

11:31 am

Sean Nash

RESOLVED.

RESOLVED.

11:29 am

Dara Navaei

Please look at the green lines at the bottom of these comments

Please look at the green lines at the bottom of these comments

11:26 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:22 am

Sean Nash

first get function still missing header.

first get function still missing header.

11:21 am

Sean Nash

RESOLVED.

RESOLVED.

11:21 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

Must have worked. I think just one H is all that's needed for unsigned short. Not sure why type "int" is being parsed as unsigned short though.

Must have worked. I think just one H is all that's needed for unsigned short. Not sure why type "int" is being parsed as unsigned short though.

11:16 am

Sean Nash

RESOLVED.

RESOLVED.

11:07 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:07 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:04 am

Dara Navaei

DEN-14001 addressed the code review comments

Options
    • -32
    • +25
    /dialin/hd/battery.py
11:04 am

Dara Navaei

Done.

Done.

11:03 am

Dara Navaei

That is right. Done.

That is right. Done.

11:02 am

Dara Navaei

Done.

Done.

11:00 am

Dara Navaei

Done.

Done.

11:00 am

Dara Navaei

Done.

Done.

10:59 am

Dara Navaei

Done.

Done.

10:58 am

Dara Navaei

The authors and dates will be addressed automatically once the copyright script is run in staging build.

The authors and dates will be addressed automatically once the copyright script is run in staging build.

10:57 am

Dara Navaei

Done

Done

10:50 am

Dara Navaei

Done.

Done.

10:47 am

Michael Garthwaite

Does this work? struct.unpack does not have an HH option.

Does this work? struct.unpack does not have an HH option.