dialin

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: generated the code change report

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

RESOLVED.

RESOLVED.

DEN-14001 addressed a code review comments

Done.

Done.

May not be needed, but can we just add 0xB8 too for completeness?

May not be needed, but can we just add 0xB8 too for completeness?

DEN-14001 merged staging

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only look...

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only looking at the first value (index 0) parsed.
Firmware is sending everything as U32. So we should be using "I" for unsigned int.

RESOLVED.

RESOLVED.

Please look at the green lines at the bottom of these comments

Please look at the green lines at the bottom of these comments

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

first get function still missing header.

first get function still missing header.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Must have worked. I think just one H is all that's needed for unsigned short. Not sure why type "int" is being parsed as unsigned short though.

Must have worked. I think just one H is all that's needed for unsigned short. Not sure why type "int" is being parsed as unsigned short though.

RESOLVED.

RESOLVED.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

DEN-14001 addressed the code review comments

Done.

Done.

That is right. Done.

That is right. Done.

Done.

Done.

Done.

Done.

Done.

Done.