Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 14 Dec 2022

9:11 am

Sean Nash

More
e4a565f
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' into develop

- -1
- +48
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py

9:10 am

Sean Nash

More
bdc19aa
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 165 more DIALIN-DEN-14307-1

DEN-14307: Added handling of new alarm info broadcast params for alarm response button blocker flags.

- -1
- +48
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py

Tuesday 13 Dec 2022

1:37 pm

Dara Navaei

More
e9ecd37
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Bamboo Commit: generated the code change report

- -3
- +15
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

1:35 pm

Dara Navaei

More
ab24503
changed 5 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merged DEN-14307

- -1
- +0
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py
- -2
- +4
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -0
- +26
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py
- -90
- +16
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -4
- +38
/tests/hd_nvm_scripts.py
- History
- Source
- Diff
/tests/hd_nvm_scripts.py

1:33 pm

Dara Navaei

More
683488d
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 165 more DIALIN-DEN-14307-1

DEN-14307 updated the DG NV record CRC override message ID due to a conflict

- -1
- +3
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py

1:29 pm

Dara Navaei

More
e8862e7
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 165 more DIALIN-DEN-14307-1

DEN-14307 changed the message ID of the DG crc NV record override due to conflict

- -1
- +3
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py

1:21 pm

Dara Navaei

More
5ea9bb5
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 165 more DIALIN-DEN-14307-1

DEN-14307 updated the DG tests

- -77
- +17
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py

Monday 12 Dec 2022

3:42 pm

Dara Navaei

More
79a4567
changed 1 file
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Bamboo Commit: generated the code change report

- -5
- +44
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

3:40 pm

Dara Navaei

More
f63e267
changed 3 files
DEN-14262-vba-homing-fails-when-cartridge-is-loaded-on-device, DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault and 127 more

Merged staging with the latest changes

- -2
- +5
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -27
- +204
/dialin/hd/battery.py
- History
- Source
- Diff
/dialin/hd/battery.py
- -0
- +2
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py

3:21 pm

Behrouz NematiPour

More
DIALIN-DEN-13965-1
Closed

Friday 09 Dec 2022

10:39 am

Dara Navaei

More
490dfc7
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 166 more

Bamboo Commit: generated the code change report

- -1
- +48
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

10:37 am

Dara Navaei

More
4f5af68
changed 3 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 166 more DIALIN-DEN-14316-1 DIALIN-DEN-14344-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -6
- +6
/dialin/hd/battery.py
- History
- Source
- Diff
/dialin/hd/battery.py
- -2
- +2
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py

10:33 am

Dara Navaei

More
DIALIN-DEN-14001-1
Closed

5:11 am

Behrouz NematiPour

More
DIALIN-DEN-14001-1
finished reviewing

Thursday 08 Dec 2022

2:28 pm

Sean Nash and Michael Garthwaite

More
DIALIN-DEN-14001-1
finished reviewing

2:28 pm

Sean Nash

RESOLVED.

RESOLVED.

2:26 pm

Dara Navaei

More
1547dc9
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 167 more DIALIN-DEN-14001-1

DEN-14001 addressed a code review comments

- -0
- +1
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py

2:25 pm

Dara Navaei

Done.

Done.

2:19 pm

Sean Nash

More
Re: DIALIN-DEN-14001-1
commented on review

May not be needed, but can we just add 0xB8 too for completeness?

May not be needed, but can we just add 0xB8 too for completeness?

1:01 pm

Dara Navaei

More
c931cb0
changed 2 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-13903-s80-mg-DIAL-205 and 167 more DIALIN-DEN-14001-1

DEN-14001 merged staging

- -11
- +20
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -6
- +6
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py

11:35 am

Sean Nash

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only look...

Looking at unpack functionality a little more, I believe HH will parse a 32-bit byte array as 2 unsigned shorts. I think it's kind of working because byte array is little endian and we're only looking at the first value (index 0) parsed.
Firmware is sending everything as U32. So we should be using "I" for unsigned int.

11:31 am

Sean Nash

RESOLVED.

RESOLVED.

11:29 am

Dara Navaei

Please look at the green lines at the bottom of these comments

Please look at the green lines at the bottom of these comments

11:26 am

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:22 am

Sean Nash

first get function still missing header.

first get function still missing header.

11:21 am

Sean Nash

RESOLVED.

RESOLVED.

11:21 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

11:20 am

Sean Nash

RESOLVED.

RESOLVED.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-11 15:05 -0800