dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
8:55 am

Sean Nash

DEN-14316: Addressed code review comments.

Options
    • -2
    • +3
    /dialin/common/dg_defs.py
    • -1
    • +0
    /dialin/dg/chemical_disinfect_flush.py
    • -13
    • +1
    /dialin/dg/dialysate_generator.py
8:53 am

Sean Nash

RESOLVED.

RESOLVED.

8:52 am

Sean Nash

RESOLVED.

RESOLVED.

8:52 am

Sean Nash

RESOLVED.

RESOLVED.

Monday 19 Dec 2022
5:11 pm

Sean Nash

Isn't this function already declared in air_trap.py?

Isn't this function already declared in air_trap.py?

5:09 pm

Sean Nash

Add Publish list.

Add Publish list.

5:08 pm

Sean Nash

RESOLVED.

RESOLVED.

5:07 pm

Sean Nash

Need function header.

Need function header.

5:07 pm

Sean Nash

Need class header.

Need class header.

5:05 pm

Sean Nash

Does HD need a compatibility rev too (like you added to DG)?

Does HD need a compatibility rev too (like you added to DG)?

4:00 pm

Michael Garthwaite

Does this message need a broadcast override for V&V?

Does this message need a broadcast override for V&V?

3:58 pm

Michael Garthwaite

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

3:05 pm

Sean Nash

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

3:04 pm

Sean Nash

Should add chem flush = 11 to this enum.

Should add chem flush = 11 to this enum.

3:02 pm

Sean Nash

Remove blank line.

Remove blank line.

1:10 pm

Dara Navaei

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/vv/dialin into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

Options
1:10 pm

Dara Navaei

DEN-14307, DIAL-218 added HD functions to be able to override the NV records' CRC in HD

Options
    • -1
    • +1
    /dialin/common/dg_defs.py
    • -1
    • +10
    /dialin/dg/calibration_record.py
    • -2
    • +10
    /dialin/dg/service_record.py
    • -1
    • +10
    /dialin/dg/system_record.py
    • -1
    • +10
    /dialin/dg/usage_info_record.py
    • -2
    • +34
    /dialin/hd/calibration_record.py
    • -2
    • +34
    /dialin/hd/service_record.py
    • -1
    • +34
    /dialin/hd/system_record.py
    • -1
    • +34
    /dialin/hd/usage_info_record.py
    • -3
    • +4
    /tests/dg_nvm_scripts.py
    • -3
    • +6
    /tests/dg_tests.py
9:02 am

Sean Nash

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/vv/dialin into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

Options
    • -0
    • +10
    /dialin/common/msg_ids.py
9:02 am

Sean Nash

DEN-14307: Added park related commands to concentrate_pumps.

Options
    • -0
    • +3
    /dialin/common/msg_ids.py
    • -1
    • +135
    /dialin/dg/concentrate_pumps.py
8:19 am

Dara Navaei

DEN-14307 initial commit of the heat disinfect active cool mode. Added commands in DG to be able to override the NV records' CRC

Options
    • -1
    • +1
    /dialin/common/alarm_defs.py
    • -2
    • +13
    /dialin/common/dg_defs.py
    • -0
    • +10
    /dialin/common/msg_ids.py
    • -4
    • +25
    /dialin/dg/calibration_record.py
    • -0
    • +2
    /dialin/dg/dialysate_generator.py
    • -0
    • +31
    /dialin/dg/hd_proxy.py
    • -9
    • +8
    /dialin/dg/heat_disinfect.py
    • -0
    • +74
    /dialin/dg/heat_disinfect_active_cool.py
    • -1
    • +25
    /dialin/dg/service_record.py
    • -0
    • +2
    /dialin/dg/sw_configs.py
    • -2
    • +25
    /dialin/dg/system_record.py
    • -2
    • +26
    /dialin/dg/usage_info_record.py
    • -1
    • +11
    /dialin/utils/nv_ops_utils.py
    • -3
    • +14
    /tests/dg_tests.py
Thursday 15 Dec 2022
12:07 pm

Steve Jarpe <sjarpe@diality.com>

DEN-14316-chemical-disinfect. Added temperature logging to chem disinfect flush.

Options
    • -2
    • +4
    /tests/dg_tests.py
Wednesday 14 Dec 2022
10:29 am

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -0
    • +19
    /tools/Code_Report.csv
10:27 am

Sean Nash

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' into develop

Options
    • -8
    • +8
    /dialin/hd/alarms.py
10:26 am

Dara Navaei

DEN-14307 fixed the alarm table button blockers failed unit test

Options
    • -8
    • +8
    /dialin/hd/alarms.py
9:11 am

Sean Nash

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' into develop

Options
    • -1
    • +48
    /dialin/hd/alarms.py
9:10 am

Sean Nash

DEN-14307: Added handling of new alarm info broadcast params for alarm response button blocker flags.

Options
    • -1
    • +48
    /dialin/hd/alarms.py
Tuesday 13 Dec 2022
1:37 pm

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -3
    • +15
    /tools/Code_Report.csv
1:35 pm

Dara Navaei

Merged DEN-14307

Options
    • -1
    • +0
    /dialin/common/msg_defs.py
    • -2
    • +4
    /dialin/common/msg_ids.py
    • -0
    • +26
    /dialin/hd/ui_proxy.py
    • -90
    • +16
    /tests/dg_tests.py
    • -4
    • +38
    /tests/hd_nvm_scripts.py
1:33 pm

Dara Navaei

DEN-14307 updated the DG NV record CRC override message ID due to a conflict

Options
    • -1
    • +3
    /dialin/common/msg_ids.py
1:29 pm

Dara Navaei

DEN-14307 changed the message ID of the DG crc NV record override due to conflict

Options
    • -1
    • +3
    /dialin/common/msg_ids.py