dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 21 Dec 2022
3:08 pm

Dara Navaei

DEN-14307 merged staging

Options
    • -0
    • +10
    /dialin/common/alarm_defs.py
    • -24
    • +35
    /dialin/common/dg_defs.py
    • -4
    • +9
    /dialin/common/msg_ids.py
    • -12
    • +3
    /dialin/dg/dialysate_generator.py
    • -0
    • +31
    /dialin/dg/hd_proxy.py
    • -1
    • +1
    /dialin/hd/alarms.py
    • -7
    • +60
    /tests/dg_tests.py
3:02 pm

Michael Garthwaite

RESOLVED

RESOLVED

3:02 pm

Michael Garthwaite

Discussion with V&V has determined that we dont need an override for the time being.

Discussion with V&V has determined that we dont need an override for the time being.

3:01 pm

Michael Garthwaite

RESOLVED

RESOLVED

1:37 pm

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -15
    • +41
    /tools/Code_Report.csv
1:36 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/common/dg_defs.py
    • -1
    • +1
    /dialin/common/msg_ids.py
    • -5
    • +5
    /dialin/dg/chemical_disinfect_flush.py
    • -2
    • +2
    /dialin/dg/dialysate_generator.py
    • -2
    • +2
    /dialin/dg/hd_proxy.py
    • -2
    • +2
    /dialin/hd/alarms.py
    • -2
    • +2
    /tests/dg_heaters_test.py
    • -2
    • +2
    /tests/dg_nvm_scripts.py
    • -2
    • +2
    /tests/dg_tests.py
1:34 pm

Dara Navaei

1:33 pm

Sean Nash and Dara Navaei

1:30 pm

Dara Navaei

DEN-14316 merged staging

Options
    • -2
    • +11
    /dialin/common/msg_ids.py
1:26 pm

Dara Navaei

DEN-14307 updated the scripts

Options
    • -10
    • +6
    /dialin/common/dg_defs.py
    • -4
    • +4
    /tests/dg_nvm_scripts.py
    • -7
    • +11
    /tests/dg_tests.py
    • -3
    • +4
    /tests/hd_nvm_scripts.py
1:05 pm

Sean Nash

I think he meant do we need an override for the broadcast interval.

I think he meant do we need an override for the broadcast interval.

11:42 am

Sean Nash

Prefer Dialin script writers see T/F for these. F/W sends BOOL which is essentially a U32. Just using unpack 'I' since it's best fit.

Prefer Dialin script writers see T/F for these. F/W sends BOOL which is essentially a U32. Just using unpack 'I' since it's best fit.

11:24 am

Dara Navaei

No these are only broadcast data. We do not override the states of a mode.

No these are only broadcast data. We do not override the states of a mode.

11:23 am

Dara Navaei

Sean Nash could you please respond to this comment?

Sean Nash could you please respond to this comment?

8:55 am

Sean Nash

DEN-14316: Addressed code review comments.

Options
    • -2
    • +3
    /dialin/common/dg_defs.py
    • -1
    • +0
    /dialin/dg/chemical_disinfect_flush.py
    • -13
    • +1
    /dialin/dg/dialysate_generator.py
8:53 am

Sean Nash

RESOLVED.

RESOLVED.

8:52 am

Sean Nash

RESOLVED.

RESOLVED.

8:52 am

Sean Nash

RESOLVED.

RESOLVED.

Monday 19 Dec 2022
5:11 pm

Sean Nash

Isn't this function already declared in air_trap.py?

Isn't this function already declared in air_trap.py?

5:09 pm

Sean Nash

Add Publish list.

Add Publish list.

5:08 pm

Sean Nash

RESOLVED.

RESOLVED.

5:07 pm

Sean Nash

Need function header.

Need function header.

5:07 pm

Sean Nash

Need class header.

Need class header.

5:05 pm

Sean Nash

Does HD need a compatibility rev too (like you added to DG)?

Does HD need a compatibility rev too (like you added to DG)?

4:00 pm

Michael Garthwaite

Does this message need a broadcast override for V&V?

Does this message need a broadcast override for V&V?

3:58 pm

Michael Garthwaite

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

3:05 pm

Sean Nash

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

3:04 pm

Sean Nash

Should add chem flush = 11 to this enum.

Should add chem flush = 11 to this enum.

3:02 pm

Sean Nash

Remove blank line.

Remove blank line.

1:10 pm

Dara Navaei

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/vv/dialin into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6

Options