dialin

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14307 merged staging

RESOLVED

RESOLVED

Discussion with V&V has determined that we dont need an override for the time being.

Discussion with V&V has determined that we dont need an override for the time being.

RESOLVED

RESOLVED

Bamboo Commit: generated the code change report

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -5
    • +5
    /dialin/dg/chemical_disinfect_flush.py
DEN-14316 merged staging

DEN-14307 updated the scripts

I think he meant do we need an override for the broadcast interval.

I think he meant do we need an override for the broadcast interval.

Prefer Dialin script writers see T/F for these. F/W sends BOOL which is essentially a U32. Just using unpack 'I' since it's best fit.

Prefer Dialin script writers see T/F for these. F/W sends BOOL which is essentially a U32. Just using unpack 'I' since it's best fit.

No these are only broadcast data. We do not override the states of a mode.

No these are only broadcast data. We do not override the states of a mode.

Sean Nash could you please respond to this comment?

Sean Nash could you please respond to this comment?

DEN-14316: Addressed code review comments.

    • -1
    • +0
    /dialin/dg/chemical_disinfect_flush.py
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Isn't this function already declared in air_trap.py?

Isn't this function already declared in air_trap.py?

Add Publish list.

Add Publish list.

RESOLVED.

RESOLVED.

Need function header.

Need function header.

Need class header.

Need class header.

Does HD need a compatibility rev too (like you added to DG)?

Does HD need a compatibility rev too (like you added to DG)?

Does this message need a broadcast override for V&V?

Does this message need a broadcast override for V&V?

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

Can these fields be a value that is not 0 or 1? Seems weird to have them be unpacked and casted as a bool only to have the override parameters have int instead of bool.

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

Maybe we should just refer to the DG op modes enum in dg_defs.py? Otherwise this is likely to get out of sync w/ enum.

Should add chem flush = 11 to this enum.

Should add chem flush = 11 to this enum.

Remove blank line.

Remove blank line.

Merge branch 'DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6' of ssh://dvm-linux02:7999/vv/dialin into DEN-14307-dg_hd_dev-hd_dg_dvt-update-part-6