Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Wednesday 11 Jan 2023

1:34 pm

Dara Navaei

More
772e970
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497 updated the comments

- -1
- +1
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py

1:27 pm

Sean Nash

RESOLVED.

RESOLVED.

1:26 pm

Dara Navaei

More
54b46a9
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497 addressed the code review comments

- -18
- +24
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py

1:25 pm

Dara Navaei

Done

Done

1:24 pm

Dara Navaei

Done

Done

12:56 pm

Sean Nash

Why not? Don't we want to say something about it for our Dialin documentation?

Why not? Don't we want to say something about it for our Dialin documentation?

12:56 pm

Sean Nash

Resolved.

Resolved.

12:55 pm

Sean Nash

RESOLVED.

RESOLVED.

12:55 pm

Sean Nash

Done where?

Done where?

12:54 pm

Sean Nash

RESOLVED.

RESOLVED.

11:35 am

Dara Navaei

More
ffe7108
changed 11 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

- -1
- +1
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -3
- +4
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -5
- +6
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -1
- +1
/dialin/dg/drain_pump.py
- History
- Source
- Diff
/dialin/dg/drain_pump.py
- -1
- +1
/dialin/dg/fluid_leak.py
- History
- Source
- Diff
/dialin/dg/fluid_leak.py
- -1
- +1
/dialin/dg/heaters.py
- History
- Source
- Diff
/dialin/dg/heaters.py
- -1
- +1
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py
- -1
- +1
/dialin/hd/fluid_leak.py
- History
- Source
- Diff
/dialin/hd/fluid_leak.py
- -1
- +1
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -1
- +1
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py
- -1
- +1
/tests/hd_blood_leak_data.py
- History
- Source
- Diff
/tests/hd_blood_leak_data.py

11:34 am

Dara Navaei

More
da7d431
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

Merge branch 'DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7' of ssh://dvm-linux02:7999/vv/dialin into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

- -1
- +16
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py

11:34 am

Dara Navaei

More
16a0f3e
changed 3 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497 addressed the code review comments

- -26
- +25
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -5
- +8
/dialin/hd/blood_leak.py
- History
- Source
- Diff
/dialin/hd/blood_leak.py
- -0
- +2
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py

11:30 am

Dara Navaei

We do not have headers for enum classes.

We do not have headers for enum classes.

11:26 am

Dara Navaei

Done

Done

11:25 am

Dara Navaei

Done

Done

11:22 am

Dara Navaei

No this is command schedules the entire zero command sequence while the other embedded mode commands are atomic.

No this is command schedules the entire zero command sequence while the other embedded mode commands are atomic.

11:11 am

Dara Navaei

Done

Done

10:29 am

Sean Nash

More
bc39c08
changed 2 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497: Updated events enums. Added HD events for buttons and safety line.

- -4
- +14
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -1
- +16
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py

Sunday 08 Jan 2023

1:36 pm

Dara Navaei

More
d81b808
changed 0 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more

Merge branch 'DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7' of ssh://dvm-linux02:7999/vv/dialin into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

1:36 pm

Dara Navaei

More
90fd2bc
changed 4 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497 updated the drain pump target pressure to target flow

- -3
- +3
/dialin/dg/drain_pump.py
- History
- Source
- Diff
/dialin/dg/drain_pump.py
- -3
- +3
/dialin/dg/heaters.py
- History
- Source
- Diff
/dialin/dg/heaters.py
- -3
- +3
/tests/dg_nvm_scripts.py
- History
- Source
- Diff
/tests/dg_nvm_scripts.py
- -3
- +4
/tests/dg_tests.py
- History
- Source
- Diff
/tests/dg_tests.py

Thursday 05 Jan 2023

1:25 pm

Sean Nash

More
Re: DIALIN-DEN-14497-1
commented on review

Should you validate given command before using it to index list?

Should you validate given command before using it to index list?

1:24 pm

Sean Nash

More
Re: DIALIN-DEN-14497-1
commented on review

Another constraint is that embedded command mode command must be given first. Should also recommend a minimum time between embedded commands constraint to prevent f/w queue from overflowing.

Another constraint is that embedded command mode command must be given first.
Should also recommend a minimum time between embedded commands constraint to prevent f/w queue from overflowing.

1:22 pm

Sean Nash

More
Re: DIALIN-DEN-14497-1
commented on review

Is this command "embedded"? Is it redundant with generic embedded command function below? Will it go into f/w embedded command queue?

Is this command "embedded"? Is it redundant with generic embedded command function below? Will it go into f/w embedded command queue?

1:18 pm

Sean Nash

More
Re: DIALIN-DEN-14497-1
commented on review

Gets the most recent embedded mode command response for a given command.

Gets the most recent embedded mode command response for a given command.

1:16 pm

Sean Nash

More
Re: DIALIN-DEN-14497-1
commented on review

Class should have header.

Class should have header.

Wednesday 04 Jan 2023

1:22 pm

Sean Nash

More
58c1ab4
changed 2 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

DEN-14497: Renamed fluid leak override parameter name per user feedback.

- -3
- +3
/dialin/dg/fluid_leak.py
- History
- Source
- Diff
/dialin/dg/fluid_leak.py
- -3
- +3
/dialin/hd/fluid_leak.py
- History
- Source
- Diff
/dialin/hd/fluid_leak.py

Tuesday 03 Jan 2023

4:07 pm

Dara Navaei

More
faeb2ee
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 160 more DIALIN-DEN-14497-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py

4:06 pm

Dara Navaei

More
DIALIN-DEN-13903-2
Closed

4:05 pm

Dara Navaei and Michael Garthwaite

More
DIALIN-DEN-13903-2
finished reviewing

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-29 21:32 -0700