dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Jan 2023
4:51 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /dialin/common/dg_defs.py
    • -1
    • +1
    /dialin/common/hd_defs.py
    • -1
    • +1
    /dialin/common/msg_ids.py
    • -1
    • +1
    /dialin/dg/drain_pump.py
    • -2
    • +2
    /dialin/dg/fluid_leak.py
    • -1
    • +1
    /dialin/dg/heaters.py
    • -1
    • +1
    /dialin/hd/blood_leak.py
    • -2
    • +2
    /dialin/hd/fluid_leak.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_blood_leak_data.py
4:49 pm

Dara Navaei

4:07 pm

Behrouz NematiPour and Sean Nash

4:06 pm

Behrouz NematiPour

what is 6?

what is 6?

4:06 pm

Behrouz NematiPour

what is Z?

what is Z?

4:04 pm

Behrouz NematiPour

I think we decided to define the return type for at least functions that have return values other than None.

I think we decided to define the return type for at least functions that have return values other than None.

4:00 pm

Behrouz NematiPour

why dict() is used instead of simply use {}?

why dict() is used instead of simply use {}?

2:01 pm

Sean Nash

RESOLVED.

RESOLVED.

1:34 pm

Dara Navaei

DEN-14497 updated the comments

Options
    • -1
    • +1
    /dialin/hd/blood_leak.py
1:27 pm

Sean Nash

RESOLVED.

RESOLVED.

1:26 pm

Dara Navaei

DEN-14497 addressed the code review comments

Options
    • -18
    • +24
    /dialin/hd/blood_leak.py
1:25 pm

Dara Navaei

Done

Done

1:24 pm

Dara Navaei

Done

Done

12:56 pm

Sean Nash

Why not? Don't we want to say something about it for our Dialin documentation?

Why not? Don't we want to say something about it for our Dialin documentation?

12:56 pm

Sean Nash

Resolved.

Resolved.

12:55 pm

Sean Nash

RESOLVED.

RESOLVED.

12:55 pm

Sean Nash

Done where?

Done where?

12:54 pm

Sean Nash

RESOLVED.

RESOLVED.

11:35 am

Dara Navaei

Merge branch 'staging' into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
    • -1
    • +1
    /dialin/common/dg_defs.py
    • -3
    • +4
    /dialin/common/hd_defs.py
    • -5
    • +6
    /dialin/common/msg_ids.py
    • -1
    • +1
    /dialin/dg/drain_pump.py
    • -1
    • +1
    /dialin/dg/fluid_leak.py
    • -1
    • +1
    /dialin/dg/heaters.py
    • -1
    • +1
    /dialin/hd/blood_leak.py
    • -1
    • +1
    /dialin/hd/fluid_leak.py
    • -1
    • +1
    /tests/dg_nvm_scripts.py
    • -1
    • +1
    /tests/dg_tests.py
    • -1
    • +1
    /tests/hd_blood_leak_data.py
11:34 am

Dara Navaei

Merge branch 'DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7' of ssh://dvm-linux02:7999/vv/dialin into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
    • -1
    • +16
    /dialin/common/hd_defs.py
11:34 am

Dara Navaei

DEN-14497 addressed the code review comments

Options
    • -26
    • +25
    /dialin/common/hd_defs.py
    • -5
    • +8
    /dialin/hd/blood_leak.py
    • -0
    • +2
    /tests/dg_tests.py
11:30 am

Dara Navaei

We do not have headers for enum classes.

We do not have headers for enum classes.

11:26 am

Dara Navaei

Done

Done

11:25 am

Dara Navaei

Done

Done

11:22 am

Dara Navaei

No this is command schedules the entire zero command sequence while the other embedded mode commands are atomic.

No this is command schedules the entire zero command sequence while the other embedded mode commands are atomic.

11:11 am

Dara Navaei

Done

Done

10:29 am

Sean Nash

DEN-14497: Updated events enums. Added HD events for buttons and safety line.

Options
    • -4
    • +14
    /dialin/common/dg_defs.py
    • -1
    • +16
    /dialin/common/hd_defs.py
Sunday 08 Jan 2023
1:36 pm

Dara Navaei

Merge branch 'DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7' of ssh://dvm-linux02:7999/vv/dialin into DEN-14497-dg_hd_dev-hd_dg_dvt-update-part-7

Options
1:36 pm

Dara Navaei

DEN-14497 updated the drain pump target pressure to target flow

Options
    • -3
    • +3
    /dialin/dg/drain_pump.py
    • -3
    • +3
    /dialin/dg/heaters.py
    • -3
    • +3
    /tests/dg_nvm_scripts.py
    • -3
    • +4
    /tests/dg_tests.py
Thursday 05 Jan 2023
1:25 pm

Sean Nash

Should you validate given command before using it to index list?

Should you validate given command before using it to index list?