Activity dialin/

9:38 am

Dara Navaei

More
858a23e
changed 5 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 155 more DIALIN-DEN-14549-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -2
- +2
/dialin/dg/valves.py
- History
- Source
- Diff
/dialin/dg/valves.py
- -2
- +2
/dialin/hd/air_trap.py
- History
- Source
- Diff
/dialin/hd/air_trap.py
- -2
- +2
/dialin/hd/alarms.py
- History
- Source
- Diff
/dialin/hd/alarms.py
- -1
- +1
/dialin/hd/syringe_pump.py
- History
- Source
- Diff
/dialin/hd/syringe_pump.py

9:37 am

Michael Garthwaite

More
ac298c3
changed 0 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 155 more

Merge branch 'DEN-14589-DIAL-221-DIAL-224' into staging

9:36 am

Michael Garthwaite

More
74140c2
changed 0 files
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 155 more

Merge branch 'staging' into DEN-14589-DIAL-221-DIAL-224

9:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

8:50 am

Michael Garthwaite

More
d304a13
changed 1 file
DEN-13154-heparin-syringe-empty-position-incorrect, DEN-14159-hd-air-trap-override-not-working and 155 more DIALIN-DEN-14589-1

DEN-14589: code review comments

- -1
- +1
/dialin/dg/valves.py
- History
- Source
- Diff
/dialin/dg/valves.py

8:48 am

Sean Nash

Ok, not sure how this got into staging already. Will have to add it back later. RESOLVED in CODE WALKTHROUGH.

Ok, not sure how this got into staging already. Will have to add it back later.
RESOLVED in CODE WALKTHROUGH.

8:47 am

Sean Nash

It does not look aligned with firmware. firmware has: fill, inlet, reserved, ... you now have fill, reserved, drain, ...

It does not look aligned with firmware.
firmware has: fill, inlet, reserved, ...
you now have fill, reserved, drain, ...

5:35 pm

Dara Navaei

The reserved space belongs to the former reservoir drain valve that was broken into VRD1 and VRD2.

1:34 pm

Michael Garthwaite

This is currently in sync with the VALVES_T struct in the DG firmware. /// Enumeration of valves. typedef enum Valves VRF = 0, ///< Valve Reservoir Fill VRI, ///< Valve Reservoir Inlet RSRVD_SPAC...

This is currently in sync with the VALVES_T struct in the DG firmware.

/// Enumeration of valves.
typedef enum Valves

VRF = 0, ///< Valve Reservoir Fill
VRI, ///< Valve Reservoir Inlet
RSRVD_SPACE, ///< This space has been reserved
VRO, ///< Valve Reservoir Outlet
VPO, ///< Valve Pressure Outlet
VBF, ///< Valve Bypass Filter
VRC, ///< Valve Recirculate
VDR, ///< Valve Drain
VPI, ///< Valve Pressure Inlet
VSP, ///< Valve Sampling Port
VRD1, ///< Valve Reservoir 1 Drain
VRD2, ///< Valve Reservoir 2 Drain
VPD, ///< Valve Production Drain
NUM_OF_VALVES ///< Number of valves
VALVES_T;

Dara Navaei may be able to clarify as to why

1:30 pm

Michael Garthwaite

They are currently out of sync with latest staging builds. Kendrick is currently failing his testing using staging builds if he uses enum 18 to get the HD_EVENT_SUB_STATE_CHANGE that was done in ht...

They are currently out of sync with latest staging builds. Kendrick is currently failing his testing using staging builds if he uses enum 18 to get the HD_EVENT_SUB_STATE_CHANGE that was done in http://devapps.diality.us:8060/cru/HD-DEN-14328-1#details

How do you wish to resolve this?

1:16 pm